* [PATCH] soc: imx: imx93-src: No need to set device_driver owner
@ 2022-12-22 17:57 ` Deepak R Varma
0 siblings, 0 replies; 4+ messages in thread
From: Deepak R Varma @ 2022-12-22 17:57 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-arm-kernel, linux-kernel
Cc: Saurabh Singh Sengar, Praveen Kumar, drv
There is no need to exclusively set the .owner member of the struct
device_driver when defining the platform_driver struct. The Linux core
takes care of setting the .owner member as part of the call to
module_platform_driver() helper function.
Issue identified using the platform_no_drv_owner.cocci Coccinelle
semantic patch.
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
Note: Proposed change compile tested only using ARM64 defconfig.
drivers/soc/imx/imx93-src.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/soc/imx/imx93-src.c b/drivers/soc/imx/imx93-src.c
index 4d74921cae0f..f1c2e22d5cbd 100644
--- a/drivers/soc/imx/imx93-src.c
+++ b/drivers/soc/imx/imx93-src.c
@@ -21,7 +21,6 @@ MODULE_DEVICE_TABLE(of, imx93_src_ids);
static struct platform_driver imx93_src_driver = {
.driver = {
.name = "imx93_src",
- .owner = THIS_MODULE,
.of_match_table = imx93_src_ids,
},
.probe = imx93_src_probe,
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] soc: imx: imx93-src: No need to set device_driver owner
@ 2022-12-22 17:57 ` Deepak R Varma
0 siblings, 0 replies; 4+ messages in thread
From: Deepak R Varma @ 2022-12-22 17:57 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-arm-kernel, linux-kernel
Cc: Saurabh Singh Sengar, Praveen Kumar, drv
There is no need to exclusively set the .owner member of the struct
device_driver when defining the platform_driver struct. The Linux core
takes care of setting the .owner member as part of the call to
module_platform_driver() helper function.
Issue identified using the platform_no_drv_owner.cocci Coccinelle
semantic patch.
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
Note: Proposed change compile tested only using ARM64 defconfig.
drivers/soc/imx/imx93-src.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/soc/imx/imx93-src.c b/drivers/soc/imx/imx93-src.c
index 4d74921cae0f..f1c2e22d5cbd 100644
--- a/drivers/soc/imx/imx93-src.c
+++ b/drivers/soc/imx/imx93-src.c
@@ -21,7 +21,6 @@ MODULE_DEVICE_TABLE(of, imx93_src_ids);
static struct platform_driver imx93_src_driver = {
.driver = {
.name = "imx93_src",
- .owner = THIS_MODULE,
.of_match_table = imx93_src_ids,
},
.probe = imx93_src_probe,
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: imx: imx93-src: No need to set device_driver owner
2022-12-22 17:57 ` Deepak R Varma
@ 2023-01-01 5:29 ` Shawn Guo
-1 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2023-01-01 5:29 UTC (permalink / raw)
To: Deepak R Varma
Cc: Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-arm-kernel, linux-kernel,
Saurabh Singh Sengar, Praveen Kumar
On Thu, Dec 22, 2022 at 11:27:03PM +0530, Deepak R Varma wrote:
> There is no need to exclusively set the .owner member of the struct
> device_driver when defining the platform_driver struct. The Linux core
> takes care of setting the .owner member as part of the call to
> module_platform_driver() helper function.
>
> Issue identified using the platform_no_drv_owner.cocci Coccinelle
> semantic patch.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: imx: imx93-src: No need to set device_driver owner
@ 2023-01-01 5:29 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2023-01-01 5:29 UTC (permalink / raw)
To: Deepak R Varma
Cc: Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-arm-kernel, linux-kernel,
Saurabh Singh Sengar, Praveen Kumar
On Thu, Dec 22, 2022 at 11:27:03PM +0530, Deepak R Varma wrote:
> There is no need to exclusively set the .owner member of the struct
> device_driver when defining the platform_driver struct. The Linux core
> takes care of setting the .owner member as part of the call to
> module_platform_driver() helper function.
>
> Issue identified using the platform_no_drv_owner.cocci Coccinelle
> semantic patch.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-01 5:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-22 17:57 [PATCH] soc: imx: imx93-src: No need to set device_driver owner Deepak R Varma
2022-12-22 17:57 ` Deepak R Varma
2023-01-01 5:29 ` Shawn Guo
2023-01-01 5:29 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.