All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Michał Grzelak" <mig@semihalf.com>
Cc: linux-kernel@vger.kernel.org, sebastian.hesselbarth@gmail.com,
	gregory.clement@bootlin.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	mw@semihalf.com, upstream@semihalf.com, mchl.grzlk@gmail.com
Subject: Re: [PATCH v2] ARM: dts: dove.dtsi: Move ethphy to fix schema error
Date: Thu, 29 Dec 2022 02:32:22 +0100	[thread overview]
Message-ID: <Y6zuJrb+8j+XCksN@lunn.ch> (raw)
In-Reply-To: <20221228200234.86391-1-mig@semihalf.com>

On Wed, Dec 28, 2022 at 09:02:34PM +0100, Michał Grzelak wrote:
> Running 'make dtbs_check' with schema in net/marvell,orion-mdio.yaml
> gives the following warnings:
> mdio-bus@72004: Unevaluated properties are not allowed
> ('ethernet-phy' was unexpected)
> 	arch/arm/boot/dts/dove-cubox.dtb
> 	arch/arm/boot/dts/dove-cubox-es.dtb
> 	arch/arm/boot/dts/dove-d2plug.dtb
> 	arch/arm/boot/dts/dove-d2plug.dtb
> 	arch/arm/boot/dts/dove-dove-db.dtb
> 	arch/arm/boot/dts/dove-d3plug.dtb
> 	arch/arm/boot/dts/dove-sbc-a510.dtb
> Fix them by removing empty ethphy subnode from dove.dtsi and describe
> PHY on the relevant board .dts files level.

I don't think your description is correct. What i think is causing the
problem is that the ethphy subnode in dove.dtsi does not have an @X.

By moving it into the .dts file, you can then give it the correct @1,
or @3, which makes the linter happy. The kernel itself does not care
about this, it is an example of the linter being much more strict than
the kernel.

If you agree with me, please update the description.

   Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: "Michał Grzelak" <mig@semihalf.com>
Cc: linux-kernel@vger.kernel.org, sebastian.hesselbarth@gmail.com,
	gregory.clement@bootlin.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	mw@semihalf.com, upstream@semihalf.com, mchl.grzlk@gmail.com
Subject: Re: [PATCH v2] ARM: dts: dove.dtsi: Move ethphy to fix schema error
Date: Thu, 29 Dec 2022 02:32:22 +0100	[thread overview]
Message-ID: <Y6zuJrb+8j+XCksN@lunn.ch> (raw)
In-Reply-To: <20221228200234.86391-1-mig@semihalf.com>

On Wed, Dec 28, 2022 at 09:02:34PM +0100, Michał Grzelak wrote:
> Running 'make dtbs_check' with schema in net/marvell,orion-mdio.yaml
> gives the following warnings:
> mdio-bus@72004: Unevaluated properties are not allowed
> ('ethernet-phy' was unexpected)
> 	arch/arm/boot/dts/dove-cubox.dtb
> 	arch/arm/boot/dts/dove-cubox-es.dtb
> 	arch/arm/boot/dts/dove-d2plug.dtb
> 	arch/arm/boot/dts/dove-d2plug.dtb
> 	arch/arm/boot/dts/dove-dove-db.dtb
> 	arch/arm/boot/dts/dove-d3plug.dtb
> 	arch/arm/boot/dts/dove-sbc-a510.dtb
> Fix them by removing empty ethphy subnode from dove.dtsi and describe
> PHY on the relevant board .dts files level.

I don't think your description is correct. What i think is causing the
problem is that the ethphy subnode in dove.dtsi does not have an @X.

By moving it into the .dts file, you can then give it the correct @1,
or @3, which makes the linter happy. The kernel itself does not care
about this, it is an example of the linter being much more strict than
the kernel.

If you agree with me, please update the description.

   Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-12-29  1:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-28 20:02 [PATCH v2] ARM: dts: dove.dtsi: Move ethphy to fix schema error Michał Grzelak
2022-12-28 20:02 ` Michał Grzelak
2022-12-29  1:32 ` Andrew Lunn [this message]
2022-12-29  1:32   ` Andrew Lunn
2022-12-29 14:14   ` Michał Grzelak
2022-12-29 14:14     ` Michał Grzelak
2022-12-29 17:10     ` Andrew Lunn
2022-12-29 17:10       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y6zuJrb+8j+XCksN@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchl.grzlk@gmail.com \
    --cc=mig@semihalf.com \
    --cc=mw@semihalf.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=upstream@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.