gpmc wait pin regression from 89aed3cd5cb9

gpmc wait pin regression from 89aed3cd5cb9

[Colin Foster]

I'm working to get suport on a Phytec OMAP 4460 SOM that has an SMSC
9221 attached to the GPMC bus.

While my DT isn't mainline yet, I used existing OMAP device trees as my
basis.

After commit 89aed3cd5cb9 ("memory: omap-gpmc: wait pin additions") the
SMSC stops working because existing device trees don't have a default
"gpmc,wait-pin" defined.

I fixed the issue for myself by adding this to my .dtsi, but I imagine
any existing device trees that use the OMAP / SMSC combination will be
similarly broken in 6.2-rc2.

My latest DT submission shows the use of the omap-gpmc-smsc9221.dtsi
without the addition of gpmc,wait-pin which worked in 6.1:
https://lore.kernel.org/lkml/20221123233209.1854806-1-colin.foster@in-advantage.com/

Thanks, and let me know if there's something you want me to test.

Re: gpmc wait pin regression from 89aed3cd5cb9

[Sicelo]

Hi Colin

On Tue, Jan 03, 2023 at 02:11:47PM -0800, Colin Foster wrote:
> 
> After commit 89aed3cd5cb9 ("memory: omap-gpmc: wait pin additions") the
> SMSC stops working because existing device trees don't have a default
> "gpmc,wait-pin" defined.
> 
> I fixed the issue for myself by adding this to my .dtsi, but I imagine
> any existing device trees that use the OMAP / SMSC combination will be
> similarly broken in 6.2-rc2.
> 
> My latest DT submission shows the use of the omap-gpmc-smsc9221.dtsi
> without the addition of gpmc,wait-pin which worked in 6.1:

I also had the same issue in 6.2-rc2. However, I found the problem has
already been fixed at:

https://lore.kernel.org/linux-omap/20221209123147.591982-1-benedikt.niedermayr@siemens.com/

Hope this helps you

Sicelo