All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] netlink: fix spelling mistake in dump size assert
@ 2023-01-23 22:22 Jakub Kicinski
  2023-01-24  7:37 ` Ido Schimmel
  2023-01-25  1:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Jakub Kicinski @ 2023-01-23 22:22 UTC (permalink / raw)
  To: davem
  Cc: netdev, edumazet, pabeni, Jakub Kicinski, Ido Schimmel, jiri,
	pablo, kadlec, fw, johannes, ecree.xilinx, netfilter-devel,
	coreteam

Commit 2c7bc10d0f7b ("netlink: add macro for checking dump ctx size")
misspelled the name of the assert as asset, missing an R.

Reported-by: Ido Schimmel <idosch@idosch.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: jiri@nvidia.com
CC: pablo@netfilter.org
CC: kadlec@netfilter.org
CC: fw@strlen.de
CC: johannes@sipsolutions.net
CC: ecree.xilinx@gmail.com
CC: netfilter-devel@vger.kernel.org
CC: coreteam@netfilter.org
---
 include/linux/netlink.h              | 2 +-
 net/devlink/devl_internal.h          | 2 +-
 net/netfilter/nf_conntrack_netlink.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/netlink.h b/include/linux/netlink.h
index 38f6334f408c..fa4d86da0ec7 100644
--- a/include/linux/netlink.h
+++ b/include/linux/netlink.h
@@ -263,7 +263,7 @@ struct netlink_callback {
 	};
 };
 
-#define NL_ASSET_DUMP_CTX_FITS(type_name)				\
+#define NL_ASSERT_DUMP_CTX_FITS(type_name)				\
 	BUILD_BUG_ON(sizeof(type_name) >				\
 		     sizeof_field(struct netlink_callback, ctx))
 
diff --git a/net/devlink/devl_internal.h b/net/devlink/devl_internal.h
index 1aa1a9549549..d0d889038138 100644
--- a/net/devlink/devl_internal.h
+++ b/net/devlink/devl_internal.h
@@ -135,7 +135,7 @@ int devlink_nl_instance_iter_dump(struct sk_buff *msg,
 static inline struct devlink_nl_dump_state *
 devlink_dump_state(struct netlink_callback *cb)
 {
-	NL_ASSET_DUMP_CTX_FITS(struct devlink_nl_dump_state);
+	NL_ASSERT_DUMP_CTX_FITS(struct devlink_nl_dump_state);
 
 	return (struct devlink_nl_dump_state *)cb->ctx;
 }
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c
index 90672e293e57..308fc0023c7e 100644
--- a/net/netfilter/nf_conntrack_netlink.c
+++ b/net/netfilter/nf_conntrack_netlink.c
@@ -3866,7 +3866,7 @@ static int __init ctnetlink_init(void)
 {
 	int ret;
 
-	NL_ASSET_DUMP_CTX_FITS(struct ctnetlink_list_dump_ctx);
+	NL_ASSERT_DUMP_CTX_FITS(struct ctnetlink_list_dump_ctx);
 
 	ret = nfnetlink_subsys_register(&ctnl_subsys);
 	if (ret < 0) {
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] netlink: fix spelling mistake in dump size assert
  2023-01-23 22:22 [PATCH net-next] netlink: fix spelling mistake in dump size assert Jakub Kicinski
@ 2023-01-24  7:37 ` Ido Schimmel
  2023-01-25  1:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Ido Schimmel @ 2023-01-24  7:37 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: davem, netdev, edumazet, pabeni, jiri, pablo, kadlec, fw,
	johannes, ecree.xilinx, netfilter-devel, coreteam

On Mon, Jan 23, 2023 at 02:22:24PM -0800, Jakub Kicinski wrote:
> Commit 2c7bc10d0f7b ("netlink: add macro for checking dump ctx size")
> misspelled the name of the assert as asset, missing an R.
> 
> Reported-by: Ido Schimmel <idosch@idosch.org>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] netlink: fix spelling mistake in dump size assert
  2023-01-23 22:22 [PATCH net-next] netlink: fix spelling mistake in dump size assert Jakub Kicinski
  2023-01-24  7:37 ` Ido Schimmel
@ 2023-01-25  1:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-01-25  1:00 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: davem, netdev, edumazet, pabeni, idosch, jiri, pablo, kadlec, fw,
	johannes, ecree.xilinx, netfilter-devel, coreteam

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 23 Jan 2023 14:22:24 -0800 you wrote:
> Commit 2c7bc10d0f7b ("netlink: add macro for checking dump ctx size")
> misspelled the name of the assert as asset, missing an R.
> 
> Reported-by: Ido Schimmel <idosch@idosch.org>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: jiri@nvidia.com
> CC: pablo@netfilter.org
> CC: kadlec@netfilter.org
> CC: fw@strlen.de
> CC: johannes@sipsolutions.net
> CC: ecree.xilinx@gmail.com
> CC: netfilter-devel@vger.kernel.org
> CC: coreteam@netfilter.org
> 
> [...]

Here is the summary with links:
  - [net-next] netlink: fix spelling mistake in dump size assert
    https://git.kernel.org/netdev/net-next/c/ec8f7d495b3d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-25  1:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23 22:22 [PATCH net-next] netlink: fix spelling mistake in dump size assert Jakub Kicinski
2023-01-24  7:37 ` Ido Schimmel
2023-01-25  1:00 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.