* [PATCH] firmware: arm_scmi: Clean up a return statement
@ 2023-01-23 15:07 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2023-01-23 15:07 UTC (permalink / raw)
To: Sudeep Holla, Cristian Marussi
Cc: linux-arm-kernel, linux-kernel, kernel-janitors
The comments say "enabled" where "disabled" is intended. Also it's
cleaner to return zero explicitly instead of ret.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/firmware/arm_scmi/driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index d21c7eafd641..703f16ef3953 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev)
if (ret)
goto clear_dev_req_notifier;
- /* Bail out anyway when coex enabled */
- return ret;
+ /* Bail out anyway when coex disabled. */
+ return 0;
}
/* Coex enabled, carry on in any case. */
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] firmware: arm_scmi: Clean up a return statement
@ 2023-01-23 15:07 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2023-01-23 15:07 UTC (permalink / raw)
To: Sudeep Holla, Cristian Marussi
Cc: linux-arm-kernel, linux-kernel, kernel-janitors
The comments say "enabled" where "disabled" is intended. Also it's
cleaner to return zero explicitly instead of ret.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/firmware/arm_scmi/driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index d21c7eafd641..703f16ef3953 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev)
if (ret)
goto clear_dev_req_notifier;
- /* Bail out anyway when coex enabled */
- return ret;
+ /* Bail out anyway when coex disabled. */
+ return 0;
}
/* Coex enabled, carry on in any case. */
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] firmware: arm_scmi: Clean up a return statement
2023-01-23 15:07 ` Dan Carpenter
@ 2023-01-24 9:20 ` Cristian Marussi
-1 siblings, 0 replies; 6+ messages in thread
From: Cristian Marussi @ 2023-01-24 9:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sudeep Holla, linux-arm-kernel, linux-kernel, kernel-janitors
On Mon, Jan 23, 2023 at 06:07:07PM +0300, Dan Carpenter wrote:
> The comments say "enabled" where "disabled" is intended. Also it's
> cleaner to return zero explicitly instead of ret.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> drivers/firmware/arm_scmi/driver.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index d21c7eafd641..703f16ef3953 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev)
> if (ret)
> goto clear_dev_req_notifier;
>
> - /* Bail out anyway when coex enabled */
> - return ret;
> + /* Bail out anyway when coex disabled. */
> + return 0;
> }
>
> /* Coex enabled, carry on in any case. */
> --
Indeed.
Thanks,
Cristian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] firmware: arm_scmi: Clean up a return statement
@ 2023-01-24 9:20 ` Cristian Marussi
0 siblings, 0 replies; 6+ messages in thread
From: Cristian Marussi @ 2023-01-24 9:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sudeep Holla, linux-arm-kernel, linux-kernel, kernel-janitors
On Mon, Jan 23, 2023 at 06:07:07PM +0300, Dan Carpenter wrote:
> The comments say "enabled" where "disabled" is intended. Also it's
> cleaner to return zero explicitly instead of ret.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> drivers/firmware/arm_scmi/driver.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index d21c7eafd641..703f16ef3953 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -2739,8 +2739,8 @@ static int scmi_probe(struct platform_device *pdev)
> if (ret)
> goto clear_dev_req_notifier;
>
> - /* Bail out anyway when coex enabled */
> - return ret;
> + /* Bail out anyway when coex disabled. */
> + return 0;
> }
>
> /* Coex enabled, carry on in any case. */
> --
Indeed.
Thanks,
Cristian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] firmware: arm_scmi: Clean up a return statement
2023-01-23 15:07 ` Dan Carpenter
@ 2023-03-09 14:10 ` Sudeep Holla
-1 siblings, 0 replies; 6+ messages in thread
From: Sudeep Holla @ 2023-03-09 14:10 UTC (permalink / raw)
To: Cristian Marussi, Dan Carpenter
Cc: Sudeep Holla, linux-arm-kernel, linux-kernel, kernel-janitors
On Mon, 23 Jan 2023 18:07:07 +0300, Dan Carpenter wrote:
> The comments say "enabled" where "disabled" is intended. Also it's
> cleaner to return zero explicitly instead of ret.
>
>
Applied to sudeep.holla/linux (for-next/scmi/fixes), thanks!
[1/1] firmware: arm_scmi: Clean up a return statement
https://git.kernel.org/sudeep.holla/c/8ab5059dc4f4
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] firmware: arm_scmi: Clean up a return statement
@ 2023-03-09 14:10 ` Sudeep Holla
0 siblings, 0 replies; 6+ messages in thread
From: Sudeep Holla @ 2023-03-09 14:10 UTC (permalink / raw)
To: Cristian Marussi, Dan Carpenter
Cc: Sudeep Holla, linux-arm-kernel, linux-kernel, kernel-janitors
On Mon, 23 Jan 2023 18:07:07 +0300, Dan Carpenter wrote:
> The comments say "enabled" where "disabled" is intended. Also it's
> cleaner to return zero explicitly instead of ret.
>
>
Applied to sudeep.holla/linux (for-next/scmi/fixes), thanks!
[1/1] firmware: arm_scmi: Clean up a return statement
https://git.kernel.org/sudeep.holla/c/8ab5059dc4f4
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-09 14:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23 15:07 [PATCH] firmware: arm_scmi: Clean up a return statement Dan Carpenter
2023-01-23 15:07 ` Dan Carpenter
2023-01-24 9:20 ` Cristian Marussi
2023-01-24 9:20 ` Cristian Marussi
2023-03-09 14:10 ` Sudeep Holla
2023-03-09 14:10 ` Sudeep Holla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.