* [PATCH] drm/amdgpu: Add a missing tab
@ 2023-01-13 10:07 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2023-01-13 10:07 UTC (permalink / raw)
To: Alex Deucher, Mario Limonciello
Cc: Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
Hawking Zhang, Lang Yu, Felix Kuehling, Haohui Mai, Evan Quan,
Jack Xiao, Lijo Lazar, amd-gfx, kernel-janitors
This tab was deleted accidentally and triggers a Smatch warning:
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:1006 gfx_v8_0_init_microcode()
warn: inconsistent indenting
Add it back.
Fixes: 0aaafb7359d2 ("drm/amd: Use `amdgpu_ucode_*` helpers for GFX8")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 4fb577d047fd..b1f2684d854a 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
@@ -1003,7 +1003,7 @@ static int gfx_v8_0_init_microcode(struct amdgpu_device *adev)
err = amdgpu_ucode_request(adev, &adev->gfx.me_fw, fw_name);
if (err == -ENODEV) {
snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_me.bin", chip_name);
- err = amdgpu_ucode_request(adev, &adev->gfx.me_fw, fw_name);
+ err = amdgpu_ucode_request(adev, &adev->gfx.me_fw, fw_name);
}
} else {
snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_me.bin", chip_name);
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/amdgpu: Add a missing tab
@ 2023-01-13 10:07 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2023-01-13 10:07 UTC (permalink / raw)
To: Alex Deucher, Mario Limonciello
Cc: Jack Xiao, Lijo Lazar, kernel-janitors, David Airlie,
Felix Kuehling, Pan, Xinhui, Haohui Mai, amd-gfx, Daniel Vetter,
Evan Quan, Lang Yu, Christian König, Hawking Zhang
This tab was deleted accidentally and triggers a Smatch warning:
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:1006 gfx_v8_0_init_microcode()
warn: inconsistent indenting
Add it back.
Fixes: 0aaafb7359d2 ("drm/amd: Use `amdgpu_ucode_*` helpers for GFX8")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 4fb577d047fd..b1f2684d854a 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
@@ -1003,7 +1003,7 @@ static int gfx_v8_0_init_microcode(struct amdgpu_device *adev)
err = amdgpu_ucode_request(adev, &adev->gfx.me_fw, fw_name);
if (err == -ENODEV) {
snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_me.bin", chip_name);
- err = amdgpu_ucode_request(adev, &adev->gfx.me_fw, fw_name);
+ err = amdgpu_ucode_request(adev, &adev->gfx.me_fw, fw_name);
}
} else {
snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_me.bin", chip_name);
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: Add a missing tab
2023-01-13 10:07 ` Dan Carpenter
@ 2023-01-13 19:07 ` Alex Deucher
-1 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2023-01-13 19:07 UTC (permalink / raw)
To: Dan Carpenter
Cc: Alex Deucher, Mario Limonciello, Jack Xiao, Lijo Lazar,
kernel-janitors, David Airlie, Felix Kuehling, Pan, Xinhui,
Haohui Mai, amd-gfx, Daniel Vetter, Evan Quan, Lang Yu,
Christian König, Hawking Zhang
Applied. Thanks!
Alex
On Fri, Jan 13, 2023 at 9:46 AM Dan Carpenter <error27@gmail.com> wrote:
>
> This tab was deleted accidentally and triggers a Smatch warning:
>
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:1006 gfx_v8_0_init_microcode()
> warn: inconsistent indenting
>
> Add it back.
>
> Fixes: 0aaafb7359d2 ("drm/amd: Use `amdgpu_ucode_*` helpers for GFX8")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> index 4fb577d047fd..b1f2684d854a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> @@ -1003,7 +1003,7 @@ static int gfx_v8_0_init_microcode(struct amdgpu_device *adev)
> err = amdgpu_ucode_request(adev, &adev->gfx.me_fw, fw_name);
> if (err == -ENODEV) {
> snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_me.bin", chip_name);
> - err = amdgpu_ucode_request(adev, &adev->gfx.me_fw, fw_name);
> + err = amdgpu_ucode_request(adev, &adev->gfx.me_fw, fw_name);
> }
> } else {
> snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_me.bin", chip_name);
> --
> 2.35.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu: Add a missing tab
@ 2023-01-13 19:07 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2023-01-13 19:07 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jack Xiao, Pan, Xinhui, Haohui Mai, Felix Kuehling, Lijo Lazar,
kernel-janitors, Lang Yu, amd-gfx, Mario Limonciello,
Daniel Vetter, Alex Deucher, Evan Quan, David Airlie,
Christian König, Hawking Zhang
Applied. Thanks!
Alex
On Fri, Jan 13, 2023 at 9:46 AM Dan Carpenter <error27@gmail.com> wrote:
>
> This tab was deleted accidentally and triggers a Smatch warning:
>
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:1006 gfx_v8_0_init_microcode()
> warn: inconsistent indenting
>
> Add it back.
>
> Fixes: 0aaafb7359d2 ("drm/amd: Use `amdgpu_ucode_*` helpers for GFX8")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> index 4fb577d047fd..b1f2684d854a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> @@ -1003,7 +1003,7 @@ static int gfx_v8_0_init_microcode(struct amdgpu_device *adev)
> err = amdgpu_ucode_request(adev, &adev->gfx.me_fw, fw_name);
> if (err == -ENODEV) {
> snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_me.bin", chip_name);
> - err = amdgpu_ucode_request(adev, &adev->gfx.me_fw, fw_name);
> + err = amdgpu_ucode_request(adev, &adev->gfx.me_fw, fw_name);
> }
> } else {
> snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_me.bin", chip_name);
> --
> 2.35.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-13 19:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 10:07 [PATCH] drm/amdgpu: Add a missing tab Dan Carpenter
2023-01-13 10:07 ` Dan Carpenter
2023-01-13 19:07 ` Alex Deucher
2023-01-13 19:07 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.