* nvkm_devinit_func.disable() to be made void
@ 2023-01-14 14:40 ` Deepak R Varma
0 siblings, 0 replies; 5+ messages in thread
From: Deepak R Varma @ 2023-01-14 14:40 UTC (permalink / raw)
To: Ben Skeggs, Karol Herbst, Lyude Paul, David Airlie,
Daniel Vetter, dri-devel, nouveau, linux-kernel
Cc: Saurabh Singh Sengar, Praveen Kumar
Hello,
It appears that the callback function disable() of struct nvkm_devinit_func does
not need return U64 and can be transformed to be a void. This will impact a few
drivers that have currently implementation of this callback since those always
return 0ULL. So,
Change from
8 struct nvkm_devinit_func {
... ...
15 u64 (*disable)(struct nvkm_devinit *);
1 };
Change to
8 struct nvkm_devinit_func {
... ...
15 void (*disable)(struct nvkm_devinit *);
1 };
I am unsure if this change will have any UAPI impact. Hence wanted to confirm
with you if you think this transformation is useful. If yes, I will be happy to
submit a patch for your consideration.
Please let me know.
Thank you,
./drv
^ permalink raw reply [flat|nested] 5+ messages in thread
* nvkm_devinit_func.disable() to be made void
@ 2023-01-14 14:40 ` Deepak R Varma
0 siblings, 0 replies; 5+ messages in thread
From: Deepak R Varma @ 2023-01-14 14:40 UTC (permalink / raw)
To: Ben Skeggs, Karol Herbst, Lyude Paul, David Airlie,
Daniel Vetter, dri-devel, nouveau, linux-kernel
Cc: Praveen Kumar, Saurabh Singh Sengar
Hello,
It appears that the callback function disable() of struct nvkm_devinit_func does
not need return U64 and can be transformed to be a void. This will impact a few
drivers that have currently implementation of this callback since those always
return 0ULL. So,
Change from
8 struct nvkm_devinit_func {
... ...
15 u64 (*disable)(struct nvkm_devinit *);
1 };
Change to
8 struct nvkm_devinit_func {
... ...
15 void (*disable)(struct nvkm_devinit *);
1 };
I am unsure if this change will have any UAPI impact. Hence wanted to confirm
with you if you think this transformation is useful. If yes, I will be happy to
submit a patch for your consideration.
Please let me know.
Thank you,
./drv
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: nvkm_devinit_func.disable() to be made void
2023-01-14 14:40 ` Deepak R Varma
(?)
@ 2023-01-16 17:27 ` Deepak R Varma
-1 siblings, 0 replies; 5+ messages in thread
From: Deepak R Varma @ 2023-01-16 17:27 UTC (permalink / raw)
To: Ben Skeggs, Karol Herbst, Lyude Paul, David Airlie,
Daniel Vetter, dri-devel, nouveau, linux-kernel
Cc: Praveen Kumar, Deepak R Varma, Saurabh Singh Sengar
On Sat, Jan 14, 2023 at 08:10:43PM +0530, Deepak R Varma wrote:
> Hello,
> It appears that the callback function disable() of struct nvkm_devinit_func does
> not need return U64 and can be transformed to be a void. This will impact a few
> drivers that have currently implementation of this callback since those always
> return 0ULL. So,
>
> Change from
> 8 struct nvkm_devinit_func {
> ... ...
> 15 u64 (*disable)(struct nvkm_devinit *);
> 1 };
>
> Change to
> 8 struct nvkm_devinit_func {
> ... ...
> 15 void (*disable)(struct nvkm_devinit *);
> 1 };
>
>
> I am unsure if this change will have any UAPI impact. Hence wanted to confirm
> with you if you think this transformation is useful. If yes, I will be happy to
> submit a patch for your consideration.
Hello,
May I request a response on my query? Shall I proceed with submitting a patch
proposal for consideration?
Thank you,
./drv
>
> Please let me know.
>
> Thank you,
> ./drv
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: nvkm_devinit_func.disable() to be made void
@ 2023-01-16 17:27 ` Deepak R Varma
0 siblings, 0 replies; 5+ messages in thread
From: Deepak R Varma @ 2023-01-16 17:27 UTC (permalink / raw)
To: Ben Skeggs, Karol Herbst, Lyude Paul, David Airlie,
Daniel Vetter, dri-devel, nouveau, linux-kernel
Cc: Saurabh Singh Sengar, Praveen Kumar, Deepak R Varma
On Sat, Jan 14, 2023 at 08:10:43PM +0530, Deepak R Varma wrote:
> Hello,
> It appears that the callback function disable() of struct nvkm_devinit_func does
> not need return U64 and can be transformed to be a void. This will impact a few
> drivers that have currently implementation of this callback since those always
> return 0ULL. So,
>
> Change from
> 8 struct nvkm_devinit_func {
> ... ...
> 15 u64 (*disable)(struct nvkm_devinit *);
> 1 };
>
> Change to
> 8 struct nvkm_devinit_func {
> ... ...
> 15 void (*disable)(struct nvkm_devinit *);
> 1 };
>
>
> I am unsure if this change will have any UAPI impact. Hence wanted to confirm
> with you if you think this transformation is useful. If yes, I will be happy to
> submit a patch for your consideration.
Hello,
May I request a response on my query? Shall I proceed with submitting a patch
proposal for consideration?
Thank you,
./drv
>
> Please let me know.
>
> Thank you,
> ./drv
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Nouveau] nvkm_devinit_func.disable() to be made void
@ 2023-01-16 17:27 ` Deepak R Varma
0 siblings, 0 replies; 5+ messages in thread
From: Deepak R Varma @ 2023-01-16 17:27 UTC (permalink / raw)
To: Ben Skeggs, Karol Herbst, Lyude Paul, David Airlie,
Daniel Vetter, dri-devel, nouveau, linux-kernel
Cc: Praveen Kumar, Deepak R Varma, Saurabh Singh Sengar
On Sat, Jan 14, 2023 at 08:10:43PM +0530, Deepak R Varma wrote:
> Hello,
> It appears that the callback function disable() of struct nvkm_devinit_func does
> not need return U64 and can be transformed to be a void. This will impact a few
> drivers that have currently implementation of this callback since those always
> return 0ULL. So,
>
> Change from
> 8 struct nvkm_devinit_func {
> ... ...
> 15 u64 (*disable)(struct nvkm_devinit *);
> 1 };
>
> Change to
> 8 struct nvkm_devinit_func {
> ... ...
> 15 void (*disable)(struct nvkm_devinit *);
> 1 };
>
>
> I am unsure if this change will have any UAPI impact. Hence wanted to confirm
> with you if you think this transformation is useful. If yes, I will be happy to
> submit a patch for your consideration.
Hello,
May I request a response on my query? Shall I proceed with submitting a patch
proposal for consideration?
Thank you,
./drv
>
> Please let me know.
>
> Thank you,
> ./drv
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-04 12:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-14 14:40 nvkm_devinit_func.disable() to be made void Deepak R Varma
2023-01-14 14:40 ` Deepak R Varma
2023-01-16 17:27 ` Deepak R Varma
2023-01-16 17:27 ` [Nouveau] " Deepak R Varma
2023-01-16 17:27 ` Deepak R Varma
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.