* [dm-devel] [PATCH] md: dm-table: ensure dev_t is initialized
@ 2023-01-31 11:15 Tomas Melin
2023-02-01 16:20 ` [dm-devel] " Mike Snitzer
0 siblings, 1 reply; 2+ messages in thread
From: Tomas Melin @ 2023-01-31 11:15 UTC (permalink / raw)
To: agk, snitzer; +Cc: dm-devel, Tomas Melin
Avoid returning uninitialized value in case
lookup fails.
Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
---
drivers/md/dm-table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 8fc44c9f746a..71c59455bf3b 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -331,7 +331,7 @@ static int upgrade_mode(struct dm_dev_internal *dd, fmode_t new_mode,
*/
dev_t dm_get_dev_t(const char *path)
{
- dev_t dev;
+ dev_t dev = 0;
if (lookup_bdev(path, &dev))
dev = name_to_dev_t(path);
--
2.35.1
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [dm-devel] md: dm-table: ensure dev_t is initialized
2023-01-31 11:15 [dm-devel] [PATCH] md: dm-table: ensure dev_t is initialized Tomas Melin
@ 2023-02-01 16:20 ` Mike Snitzer
0 siblings, 0 replies; 2+ messages in thread
From: Mike Snitzer @ 2023-02-01 16:20 UTC (permalink / raw)
To: Tomas Melin; +Cc: dm-devel, agk
On Tue, Jan 31 2023 at 6:15P -0500,
Tomas Melin <tomas.melin@vaisala.com> wrote:
> Avoid returning uninitialized value in case
> lookup fails.
>
> Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
> ---
> drivers/md/dm-table.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
> index 8fc44c9f746a..71c59455bf3b 100644
> --- a/drivers/md/dm-table.c
> +++ b/drivers/md/dm-table.c
> @@ -331,7 +331,7 @@ static int upgrade_mode(struct dm_dev_internal *dd, fmode_t new_mode,
> */
> dev_t dm_get_dev_t(const char *path)
> {
> - dev_t dev;
> + dev_t dev = 0;
>
> if (lookup_bdev(path, &dev))
> dev = name_to_dev_t(path);
dev_t dm_get_dev_t(const char *path)
{
dev_t dev;
if (lookup_bdev(path, &dev))
dev = name_to_dev_t(path);
return dev;
}
If lookup fails then:
dev = name_to_dev_t(path);
name_to_dev_t() will initialize dev no matter what.
Nacked-by: Mike Snitzer <snitzer@kernel.org>
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-01 16:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-31 11:15 [dm-devel] [PATCH] md: dm-table: ensure dev_t is initialized Tomas Melin
2023-02-01 16:20 ` [dm-devel] " Mike Snitzer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.