All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Hugues Fruchet <hugues.fruchet@st.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: c8sectpfe: convert to gpio descriptors
Date: Wed, 1 Feb 2023 20:35:55 +0200	[thread overview]
Message-ID: <Y9qxCyB9Tw7ehFJs@smile.fi.intel.com> (raw)
In-Reply-To: <CAKdAkRQt15PNbwzDv0sciE5xfQ8LT76cyPepzmMdNsAYg1P1vA@mail.gmail.com>

On Tue, Jan 31, 2023 at 07:29:37PM -0800, Dmitry Torokhov wrote:
> On Mon, Jan 30, 2023 at 5:31 AM Arnd Bergmann <arnd@kernel.org> wrote:

...

> > +               tsin->rst_gpio = devm_fwnode_gpiod_get_index(dev,
> > +                                                            of_node_to_fwnode(child),

Actually, please use of_fwnode_handle() and not IRQ framework custom grown
duplicate.

> > +                                                            "reset-gpios",
> 
> Wrong name.
> 
> > +                                                            0, GPIOD_OUT_LOW,
> > +                                                            "NIM reset");

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Hugues Fruchet <hugues.fruchet@st.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: c8sectpfe: convert to gpio descriptors
Date: Wed, 1 Feb 2023 20:35:55 +0200	[thread overview]
Message-ID: <Y9qxCyB9Tw7ehFJs@smile.fi.intel.com> (raw)
In-Reply-To: <CAKdAkRQt15PNbwzDv0sciE5xfQ8LT76cyPepzmMdNsAYg1P1vA@mail.gmail.com>

On Tue, Jan 31, 2023 at 07:29:37PM -0800, Dmitry Torokhov wrote:
> On Mon, Jan 30, 2023 at 5:31 AM Arnd Bergmann <arnd@kernel.org> wrote:

...

> > +               tsin->rst_gpio = devm_fwnode_gpiod_get_index(dev,
> > +                                                            of_node_to_fwnode(child),

Actually, please use of_fwnode_handle() and not IRQ framework custom grown
duplicate.

> > +                                                            "reset-gpios",
> 
> Wrong name.
> 
> > +                                                            0, GPIOD_OUT_LOW,
> > +                                                            "NIM reset");

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2023-02-01 18:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30 13:09 [PATCH] media: c8sectpfe: convert to gpio descriptors Arnd Bergmann
2023-01-30 13:09 ` Arnd Bergmann
2023-01-30 17:18 ` Andy Shevchenko
2023-01-30 17:18   ` Andy Shevchenko
2023-01-30 18:17   ` Arnd Bergmann
2023-01-30 18:17     ` Arnd Bergmann
2023-02-03 23:10     ` Dmitry Torokhov
2023-02-03 23:10       ` Dmitry Torokhov
2023-02-01  3:29 ` Dmitry Torokhov
2023-02-01  3:29   ` Dmitry Torokhov
2023-02-01 18:35   ` Andy Shevchenko [this message]
2023-02-01 18:35     ` Andy Shevchenko
2023-05-17 18:21 ` Sakari Ailus
2023-05-17 18:21   ` Sakari Ailus
2023-05-17 19:12   ` Dmitry Torokhov
2023-05-17 19:12     ` Dmitry Torokhov
2023-05-17 19:26     ` Sakari Ailus
2023-05-17 19:26       ` Sakari Ailus
2023-05-19  1:05       ` Dmitry Torokhov
2023-05-19  1:05         ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9qxCyB9Tw7ehFJs@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hugues.fruchet@st.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=patrice.chotard@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.