* [PATCH] For 5.4 stable exfat: Month timestamp metadata accidentally incremented
@ 2021-01-15 7:38 Valdis Klētnieks
2021-01-15 9:43 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Valdis Klētnieks @ 2021-01-15 7:38 UTC (permalink / raw)
To: Greg KH, arpad.mueller; +Cc: stable
The staging/exfat driver has departed, but a lot of distros are still tracking
5.4-stable, so we should fix this.
There was an 0/1 offset error in month handling for file metadata, causing
the month to get incremented on each reference to the file.
Thanks to Sebastian Gurtler for troubleshooting this, and Arpad Mueller
for bringing it to my attention.
Relevant discussions:
https://bugzilla.kernel.org/show_bug.cgi?id=210997
https://bugs.launchpad.net/ubuntu/+source/ubuntu-meta/+bug/1872504
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index 3b2b0ceb7297..848258daf620 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -59,7 +59,7 @@ static void exfat_write_super(struct super_block *sb);
/* Convert a FAT time/date pair to a UNIX date (seconds since 1 1 70). */
static void exfat_time_fat2unix(struct timespec64 *ts, struct date_time_t *tp)
{
- ts->tv_sec = mktime64(tp->Year + 1980, tp->Month + 1, tp->Day,
+ ts->tv_sec = mktime64(tp->Year + 1980, tp->Month, tp->Day,
tp->Hour, tp->Minute, tp->Second);
ts->tv_nsec = tp->MilliSecond * NSEC_PER_MSEC;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] For 5.4 stable exfat: Month timestamp metadata accidentally incremented
2021-01-15 7:38 [PATCH] For 5.4 stable exfat: Month timestamp metadata accidentally incremented Valdis Klētnieks
@ 2021-01-15 9:43 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2021-01-15 9:43 UTC (permalink / raw)
To: Valdis Klētnieks; +Cc: arpad.mueller, stable
On Fri, Jan 15, 2021 at 02:38:19AM -0500, Valdis Klētnieks wrote:
> The staging/exfat driver has departed, but a lot of distros are still tracking
> 5.4-stable, so we should fix this.
>
> There was an 0/1 offset error in month handling for file metadata, causing
> the month to get incremented on each reference to the file.
>
> Thanks to Sebastian Gurtler for troubleshooting this, and Arpad Mueller
> for bringing it to my attention.
>
> Relevant discussions:
> https://bugzilla.kernel.org/show_bug.cgi?id=210997
> https://bugs.launchpad.net/ubuntu/+source/ubuntu-meta/+bug/1872504
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-15 9:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-15 7:38 [PATCH] For 5.4 stable exfat: Month timestamp metadata accidentally incremented Valdis Klētnieks
2021-01-15 9:43 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.