From: Daniel Vetter <daniel@ffwll.ch> To: "ZhiJie.Zhang" <zhangzhijie@loongson.cn> Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm: Improve the output_poll_changed description Date: Fri, 15 Jan 2021 15:05:59 +0100 [thread overview] Message-ID: <YAGhRz0ac6GDBFDI@phenom.ffwll.local> (raw) In-Reply-To: <20210115033328.1799514-1-zhangzhijie@loongson.cn> On Fri, Jan 15, 2021 at 11:33:28AM +0800, ZhiJie.Zhang wrote: > From: zhangzhijie <zhangzhijie@loongson.cn> > > this callback was used by drm_kms_helper_hotplug_event() > > V2: (Thanks for Daniel's suggestions) > - remove the FIXME below.since with the drm_client > - infrastructure and the generic fbdev emulation we've > - resolved this all very neatly now. > > Signed-off-by: zhangzhijie <zhangzhijie@loongson.cn> > Signed-off-by: ZhiJie.Zhang <zhangzhijie@loongson.cn> > --- > include/drm/drm_mode_config.h | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > index ab424ddd7665..50541980f7f2 100644 > --- a/include/drm/drm_mode_config.h > +++ b/include/drm/drm_mode_config.h > @@ -104,13 +104,8 @@ struct drm_mode_config_funcs { > * changes. > * > * Drivers implementing fbdev emulation with the helpers can call > - * drm_fb_helper_hotplug_changed from this hook to inform the fbdev > + * drm_kms_helper_hotplug_event() from this hook to inform the fbdev Hm I looked at this again, and this change is actually wrong. Both functions exists, but calling drm_kms_helper_hotplug_event() from this hook would result in an endless loop until we crash somewhere. > * helper of output changes. Ah I meant not just removing this, but explaining what to do now instead. Suggestion: * This hook is deprecated, drivers should instead use * drm_fbdev_generic_setup() which takes care of any necessary * hotplug event forwarding already without further involvement by * the driver. Can you pls respin, with the function change dropped and the fixme replaced with the above? Thanks, Daniel > - * > - * FIXME: > - * > - * Except that there's no vtable for device-level helper callbacks > - * there's no reason this is a core function. > */ > void (*output_poll_changed)(struct drm_device *dev); > > -- > 2.29.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: "ZhiJie.Zhang" <zhangzhijie@loongson.cn> Cc: tzimmermann@suse.de, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2] drm: Improve the output_poll_changed description Date: Fri, 15 Jan 2021 15:05:59 +0100 [thread overview] Message-ID: <YAGhRz0ac6GDBFDI@phenom.ffwll.local> (raw) In-Reply-To: <20210115033328.1799514-1-zhangzhijie@loongson.cn> On Fri, Jan 15, 2021 at 11:33:28AM +0800, ZhiJie.Zhang wrote: > From: zhangzhijie <zhangzhijie@loongson.cn> > > this callback was used by drm_kms_helper_hotplug_event() > > V2: (Thanks for Daniel's suggestions) > - remove the FIXME below.since with the drm_client > - infrastructure and the generic fbdev emulation we've > - resolved this all very neatly now. > > Signed-off-by: zhangzhijie <zhangzhijie@loongson.cn> > Signed-off-by: ZhiJie.Zhang <zhangzhijie@loongson.cn> > --- > include/drm/drm_mode_config.h | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h > index ab424ddd7665..50541980f7f2 100644 > --- a/include/drm/drm_mode_config.h > +++ b/include/drm/drm_mode_config.h > @@ -104,13 +104,8 @@ struct drm_mode_config_funcs { > * changes. > * > * Drivers implementing fbdev emulation with the helpers can call > - * drm_fb_helper_hotplug_changed from this hook to inform the fbdev > + * drm_kms_helper_hotplug_event() from this hook to inform the fbdev Hm I looked at this again, and this change is actually wrong. Both functions exists, but calling drm_kms_helper_hotplug_event() from this hook would result in an endless loop until we crash somewhere. > * helper of output changes. Ah I meant not just removing this, but explaining what to do now instead. Suggestion: * This hook is deprecated, drivers should instead use * drm_fbdev_generic_setup() which takes care of any necessary * hotplug event forwarding already without further involvement by * the driver. Can you pls respin, with the function change dropped and the fixme replaced with the above? Thanks, Daniel > - * > - * FIXME: > - * > - * Except that there's no vtable for device-level helper callbacks > - * there's no reason this is a core function. > */ > void (*output_poll_changed)(struct drm_device *dev); > > -- > 2.29.2 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-15 14:06 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-15 3:33 [PATCH v2] drm: Improve the output_poll_changed description ZhiJie.Zhang 2021-01-15 3:33 ` ZhiJie.Zhang 2021-01-15 14:05 ` Daniel Vetter [this message] 2021-01-15 14:05 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YAGhRz0ac6GDBFDI@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=tzimmermann@suse.de \ --cc=zhangzhijie@loongson.cn \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.