All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Scott Branden <scott.branden@broadcom.com>
Cc: Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
	Desmond Yan <desmond.yan@broadcom.com>,
	Kees Cook <keescook@chromium.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Broadcom Kernel Feedback List 
	<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH v8 00/13] Add Broadcom VK driver
Date: Wed, 20 Jan 2021 08:59:20 +0100	[thread overview]
Message-ID: <YAfi2JRNoKLVrvtv@kroah.com> (raw)
In-Reply-To: <09b6e829-75b8-4f16-3e01-c7193640d9c6@broadcom.com>

On Tue, Jan 19, 2021 at 12:21:32PM -0800, Scott Branden wrote:
> Hi Greg,
> 
> On 2021-01-18 3:06 p.m., Olof Johansson wrote:
> > On Sun, Jan 17, 2021 at 11:17 PM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> >> On Sun, Jan 17, 2021 at 10:47:59AM -0800, Olof Johansson wrote:
> >>> Hi,
> >>>
> >>> On Mon, Nov 30, 2020 at 10:42 AM Scott Branden
> >>> <scott.branden@broadcom.com> wrote:
> >>>> This patch series drops previous patches in [1]
> >>>> that were incorporated by Kees Cook into patch series
> >>>> "Introduce partial kernel_read_file() support" [2].
> >>>>
> >>>> Remaining patches are contained in this series to add Broadcom VK driver.
> >>>> (which depends on request_firmware_into_buf API addition which has
> >>>> now been accepted into the upstream kernel as of v5.10-rc1).
> >>>>
> >>>> [1] https://lore.kernel.org/lkml/20200706232309.12010-1-scott.branden@broadcom.com/
> >>>> [2] https://lore.kernel.org/lkml/20201002173828.2099543-1-keescook@chromium.org/
> >>>
> >>> I've been following this series for some time, and I think the code is
> >>> ready to go in.
> >>>
> >>> Greg, mind queuing this up in the misc tree?
> >> I will need a new version, this is long gone from my queue.
> > I'll let Scott repost then (with acks applied etc)
> I can send another patch version with Olof's acks applied to each patch.
> Please let me know if that is what you are looking for?

Yes please.

> >> And hopefully the tty layer abuse is gone... :)
> > There's a simple tty driver as the final patch in the series, but it's
> > pretty straightforward.
> >
> > If you've still got concerns with it, the rest of the series should
> > stand on its own and should be mergeable without that piece.
> Yes, I placed the patch at the end of the series so it can be dropped
> if that is what is required to accept the rest of the patches.
> 
> There has been no viable solution suggested for replacing this functionality.
> We need a tty-like interface that works via access to the circular buffers
> in PCIe BAR space and interrupts.
> 
> The vk tty devices are a direct replacement to attaching serial cables.
> In real production environment it is not possible to attach such cables.
> 
> I can work on an alternative tty solution and send such patch later
> but I don't know what is going to prevent the tty "abuse".

I can't remember the specifics (I review hundreds of patches a week),
but please just resend and I'll deal with it then :)

thanks,

greg k-h

      reply	other threads:[~2021-01-20  8:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 18:41 [PATCH v8 00/13] Add Broadcom VK driver Scott Branden
2020-11-30 18:41 ` [PATCH v8 01/13] bcm-vk: add bcm_vk UAPI Scott Branden
2020-11-30 18:41 ` [PATCH v8 02/13] misc: bcm-vk: add Broadcom VK driver Scott Branden
2020-11-30 18:41 ` [PATCH v8 03/13] misc: bcm-vk: add autoload support Scott Branden
2020-11-30 18:41 ` [PATCH v8 04/13] misc: bcm-vk: add misc device to Broadcom VK driver Scott Branden
2020-11-30 18:41 ` [PATCH v8 05/13] misc: bcm-vk: add triggers when host panic or reboots to notify card Scott Branden
2020-11-30 18:41 ` [PATCH v8 06/13] misc: bcm-vk: add open/release Scott Branden
2020-11-30 18:41 ` [PATCH v8 07/13] misc: bcm-vk: add ioctl load_image Scott Branden
2020-11-30 18:41 ` [PATCH v8 08/13] misc: bcm-vk: add get_card_info, peerlog_info, and proc_mon_info Scott Branden
2020-11-30 18:41 ` [PATCH v8 09/13] misc: bcm-vk: add VK messaging support Scott Branden
2020-11-30 18:41 ` [PATCH v8 10/13] misc: bcm-vk: reset_pid support Scott Branden
2020-11-30 18:41 ` [PATCH v8 11/13] misc: bcm-vk: add mmap function for exposing BAR2 Scott Branden
2020-11-30 18:41 ` [PATCH v8 12/13] MAINTAINERS: bcm-vk: add maintainer for Broadcom VK Driver Scott Branden
2020-11-30 18:42 ` [PATCH v8 13/13] misc: bcm-vk: add ttyVK support Scott Branden
2021-01-17 18:47 ` [PATCH v8 00/13] Add Broadcom VK driver Olof Johansson
2021-01-18  7:17   ` Greg Kroah-Hartman
2021-01-18 23:06     ` Olof Johansson
2021-01-19 20:21       ` Scott Branden
2021-01-20  7:59         ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAfi2JRNoKLVrvtv@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=desmond.yan@broadcom.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=scott.branden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.