* [LTP] [PATCH v2 1/1] configure.ac: More descriptive NUMA error message
@ 2021-01-21 10:37 Petr Vorel
2021-01-21 10:41 ` Cyril Hrubis
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2021-01-21 10:37 UTC (permalink / raw)
To: ltp
Some people were confused and searched for libnuma.so.2,
which does not exist.
Required is libnuma.so.1, but with LIBNUMA_API_VERSION >= 2.
The API version is tighten to libnuma version in git, but that has
nothing to do with library soname version, which is still 1.0.0.
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
* Changes v1->v2:
Used Cyril's version, which is more readable.
Kind regards,
Petr
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index e44e25cc6..aa8532119 100644
--- a/configure.ac
+++ b/configure.ac
@@ -347,7 +347,7 @@ LTP_CHECK_SYSCALL_FCNTL
if test "x$with_numa" = xyes; then
LTP_CHECK_SYSCALL_NUMA
- numa_error_msg="test requires libnuma >= 2 and it's development packages"
+ numa_error_msg="test requires libnuma development packages with LIBNUMA_API_VERSION >= 2"
else
numa_error_msg="NUMA support was disabled during build"
fi
--
2.30.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH v2 1/1] configure.ac: More descriptive NUMA error message
2021-01-21 10:37 [LTP] [PATCH v2 1/1] configure.ac: More descriptive NUMA error message Petr Vorel
@ 2021-01-21 10:41 ` Cyril Hrubis
2021-01-21 11:00 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Cyril Hrubis @ 2021-01-21 10:41 UTC (permalink / raw)
To: ltp
Hi!
> Some people were confused and searched for libnuma.so.2,
> which does not exist.
>
> Required is libnuma.so.1, but with LIBNUMA_API_VERSION >= 2.
> The API version is tighten to libnuma version in git, but that has
> nothing to do with library soname version, which is still 1.0.0.
>
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
I consider this safe for the release, please push.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 3+ messages in thread
* [LTP] [PATCH v2 1/1] configure.ac: More descriptive NUMA error message
2021-01-21 10:41 ` Cyril Hrubis
@ 2021-01-21 11:00 ` Petr Vorel
0 siblings, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2021-01-21 11:00 UTC (permalink / raw)
To: ltp
> Hi!
> > Some people were confused and searched for libnuma.so.2,
> > which does not exist.
> > Required is libnuma.so.1, but with LIBNUMA_API_VERSION >= 2.
> > The API version is tighten to libnuma version in git, but that has
> > nothing to do with library soname version, which is still 1.0.0.
> > Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> I consider this safe for the release, please push.
Thanks, merged!
Kind regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-21 11:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 10:37 [LTP] [PATCH v2 1/1] configure.ac: More descriptive NUMA error message Petr Vorel
2021-01-21 10:41 ` Cyril Hrubis
2021-01-21 11:00 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.