* [PATCH v2] ASoC: qcom: lpass: Fix i2s ctl register bit map
@ 2021-01-20 2:49 Jun Nie
2021-01-25 10:30 ` Stephan Gerhold
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jun Nie @ 2021-01-20 2:49 UTC (permalink / raw)
To: srinivas.kandagatla; +Cc: Jun Nie, plai, bgoswami, alsa-devel
Fix bitwidth mapping in i2s ctl register per APQ8016 document.
Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and
dmactl registers")
Signed-off-by: Jun Nie <jun.nie@linaro.org>
---
sound/soc/qcom/lpass-apq8016.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c
index 8507ef8f6679..3efa133d1c64 100644
--- a/sound/soc/qcom/lpass-apq8016.c
+++ b/sound/soc/qcom/lpass-apq8016.c
@@ -250,7 +250,7 @@ static struct lpass_variant apq8016_data = {
.micmode = REG_FIELD_ID(0x1000, 4, 7, 4, 0x1000),
.micmono = REG_FIELD_ID(0x1000, 3, 3, 4, 0x1000),
.wssrc = REG_FIELD_ID(0x1000, 2, 2, 4, 0x1000),
- .bitwidth = REG_FIELD_ID(0x1000, 0, 0, 4, 0x1000),
+ .bitwidth = REG_FIELD_ID(0x1000, 0, 1, 4, 0x1000),
.rdma_dyncclk = REG_FIELD_ID(0x8400, 12, 12, 2, 0x1000),
.rdma_bursten = REG_FIELD_ID(0x8400, 11, 11, 2, 0x1000),
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ASoC: qcom: lpass: Fix i2s ctl register bit map
2021-01-20 2:49 [PATCH v2] ASoC: qcom: lpass: Fix i2s ctl register bit map Jun Nie
@ 2021-01-25 10:30 ` Stephan Gerhold
2021-01-25 11:01 ` Srinivas Kandagatla
2021-02-01 10:44 ` Stephan Gerhold
2 siblings, 0 replies; 6+ messages in thread
From: Stephan Gerhold @ 2021-01-25 10:30 UTC (permalink / raw)
To: Jun Nie; +Cc: plai, bgoswami, srinivas.kandagatla, alsa-devel
On Wed, Jan 20, 2021 at 10:49:55AM +0800, Jun Nie wrote:
> Fix bitwidth mapping in i2s ctl register per APQ8016 document.
> Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and
> dmactl registers")
>
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
Thanks for spotting this, I guess this did not cause me problems yet
because I use SNDRV_PCM_FMTBIT_S16 everywhere.
Anyway, this looks correct according to the datasheet:
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> sound/soc/qcom/lpass-apq8016.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c
> index 8507ef8f6679..3efa133d1c64 100644
> --- a/sound/soc/qcom/lpass-apq8016.c
> +++ b/sound/soc/qcom/lpass-apq8016.c
> @@ -250,7 +250,7 @@ static struct lpass_variant apq8016_data = {
> .micmode = REG_FIELD_ID(0x1000, 4, 7, 4, 0x1000),
> .micmono = REG_FIELD_ID(0x1000, 3, 3, 4, 0x1000),
> .wssrc = REG_FIELD_ID(0x1000, 2, 2, 4, 0x1000),
> - .bitwidth = REG_FIELD_ID(0x1000, 0, 0, 4, 0x1000),
> + .bitwidth = REG_FIELD_ID(0x1000, 0, 1, 4, 0x1000),
>
> .rdma_dyncclk = REG_FIELD_ID(0x8400, 12, 12, 2, 0x1000),
> .rdma_bursten = REG_FIELD_ID(0x8400, 11, 11, 2, 0x1000),
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ASoC: qcom: lpass: Fix i2s ctl register bit map
2021-01-20 2:49 [PATCH v2] ASoC: qcom: lpass: Fix i2s ctl register bit map Jun Nie
2021-01-25 10:30 ` Stephan Gerhold
@ 2021-01-25 11:01 ` Srinivas Kandagatla
2021-02-01 10:44 ` Stephan Gerhold
2 siblings, 0 replies; 6+ messages in thread
From: Srinivas Kandagatla @ 2021-01-25 11:01 UTC (permalink / raw)
To: Jun Nie; +Cc: plai, bgoswami, alsa-devel
On 20/01/2021 02:49, Jun Nie wrote:
> Fix bitwidth mapping in i2s ctl register per APQ8016 document.
> Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and
> dmactl registers")
>
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> sound/soc/qcom/lpass-apq8016.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c
> index 8507ef8f6679..3efa133d1c64 100644
> --- a/sound/soc/qcom/lpass-apq8016.c
> +++ b/sound/soc/qcom/lpass-apq8016.c
> @@ -250,7 +250,7 @@ static struct lpass_variant apq8016_data = {
> .micmode = REG_FIELD_ID(0x1000, 4, 7, 4, 0x1000),
> .micmono = REG_FIELD_ID(0x1000, 3, 3, 4, 0x1000),
> .wssrc = REG_FIELD_ID(0x1000, 2, 2, 4, 0x1000),
> - .bitwidth = REG_FIELD_ID(0x1000, 0, 0, 4, 0x1000),
> + .bitwidth = REG_FIELD_ID(0x1000, 0, 1, 4, 0x1000),
>
> .rdma_dyncclk = REG_FIELD_ID(0x8400, 12, 12, 2, 0x1000),
> .rdma_bursten = REG_FIELD_ID(0x8400, 11, 11, 2, 0x1000),
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ASoC: qcom: lpass: Fix i2s ctl register bit map
2021-01-20 2:49 [PATCH v2] ASoC: qcom: lpass: Fix i2s ctl register bit map Jun Nie
2021-01-25 10:30 ` Stephan Gerhold
2021-01-25 11:01 ` Srinivas Kandagatla
@ 2021-02-01 10:44 ` Stephan Gerhold
2 siblings, 0 replies; 6+ messages in thread
From: Stephan Gerhold @ 2021-02-01 10:44 UTC (permalink / raw)
To: Jun Nie; +Cc: plai, bgoswami, srinivas.kandagatla, alsa-devel
Hi Jun,
On Wed, Jan 20, 2021 at 10:49:55AM +0800, Jun Nie wrote:
> Fix bitwidth mapping in i2s ctl register per APQ8016 document.
> Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and
> dmactl registers")
>
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
It looks like you forgot to Cc the ASoC maintainer(s) here, especially
Mark Brown, which might be why this patch has not been applied yet.
Can you re-send this patch with all the maintainers in the Cc?
You can add the Reviewed-by: from me and Srinivas to your patch so
we don't need to send them again.
Thanks!
Stephan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ASoC: qcom: lpass: Fix i2s ctl register bit map
2021-02-01 13:29 Jun Nie
@ 2021-02-05 20:14 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2021-02-05 20:14 UTC (permalink / raw)
To: srinivas.kandagatla, Jun Nie; +Cc: plai, bgoswami, alsa-devel, Stephan Gerhold
On Mon, 1 Feb 2021 21:29:41 +0800, Jun Nie wrote:
> Fix bitwidth mapping in i2s ctl register per APQ8016 document.
> Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and
> dmactl registers")
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: qcom: lpass: Fix i2s ctl register bit map
commit: 5e3277ab3baff6db96ae44adf6f85d6f0f6502cc
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ASoC: qcom: lpass: Fix i2s ctl register bit map
@ 2021-02-01 13:29 Jun Nie
2021-02-05 20:14 ` Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Jun Nie @ 2021-02-01 13:29 UTC (permalink / raw)
To: broonie, srinivas.kandagatla
Cc: Jun Nie, plai, bgoswami, alsa-devel, Stephan Gerhold
Fix bitwidth mapping in i2s ctl register per APQ8016 document.
Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and
dmactl registers")
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: Jun Nie <jun.nie@linaro.org>
---
sound/soc/qcom/lpass-apq8016.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c
index 8507ef8f6679..3efa133d1c64 100644
--- a/sound/soc/qcom/lpass-apq8016.c
+++ b/sound/soc/qcom/lpass-apq8016.c
@@ -250,7 +250,7 @@ static struct lpass_variant apq8016_data = {
.micmode = REG_FIELD_ID(0x1000, 4, 7, 4, 0x1000),
.micmono = REG_FIELD_ID(0x1000, 3, 3, 4, 0x1000),
.wssrc = REG_FIELD_ID(0x1000, 2, 2, 4, 0x1000),
- .bitwidth = REG_FIELD_ID(0x1000, 0, 0, 4, 0x1000),
+ .bitwidth = REG_FIELD_ID(0x1000, 0, 1, 4, 0x1000),
.rdma_dyncclk = REG_FIELD_ID(0x8400, 12, 12, 2, 0x1000),
.rdma_bursten = REG_FIELD_ID(0x8400, 11, 11, 2, 0x1000),
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-05 20:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-20 2:49 [PATCH v2] ASoC: qcom: lpass: Fix i2s ctl register bit map Jun Nie
2021-01-25 10:30 ` Stephan Gerhold
2021-01-25 11:01 ` Srinivas Kandagatla
2021-02-01 10:44 ` Stephan Gerhold
2021-02-01 13:29 Jun Nie
2021-02-05 20:14 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.