From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Auger Eric <eric.auger@redhat.com>
Cc: vivek.gautam@arm.com, guohanjun@huawei.com, will@kernel.org,
lorenzo.pieralisi@arm.com, joro@8bytes.org,
linux-acpi@vger.kernel.org, zhangfei.gao@linaro.org,
lenb@kernel.org, devicetree@vger.kernel.org,
kevin.tian@intel.com, jacob.jun.pan@linux.intel.com,
robh+dt@kernel.org, Jonathan.Cameron@huawei.com,
linux-arm-kernel@lists.infradead.org, rjw@rjwysocki.net,
shameerali.kolothum.thodi@huawei.com,
iommu@lists.linux-foundation.org, sudeep.holla@arm.com,
robin.murphy@arm.com, linux-accelerators@lists.ozlabs.org,
baolu.lu@linux.intel.com
Subject: Re: [PATCH v12 10/10] iommu/arm-smmu-v3: Add stall support for platform devices
Date: Mon, 1 Feb 2021 16:19:50 +0100 [thread overview]
Message-ID: <YBgcFgXQCTEQNowo@myrica> (raw)
In-Reply-To: <47a65f65-26cb-de27-049a-48f2d083964a@redhat.com>
On Mon, Feb 01, 2021 at 02:16:16PM +0100, Auger Eric wrote:
> >>> + flt->type = IOMMU_FAULT_DMA_UNRECOV;
> >>> + flt->event = (struct iommu_fault_unrecoverable) {
> >>> + .reason = reason,
> >>> + .flags = IOMMU_FAULT_UNRECOV_ADDR_VALID |
> >>> + IOMMU_FAULT_UNRECOV_FETCH_ADDR_VALID,
> >> nit: shall IOMMU_FAULT_UNRECOV_FETCH_ADDR_VALID be set here? Supported
> >> unrecoverable faults feature the IPA field which is UNKNOWN for S1
> >> translations. fetch_addr rather was
> >> corresponding to WALK_EABT.Fetch_addr to me.
> >
> > Right I should drop the IPA part entirely, since we don't report S2 faults
> > in this patch.
> OK
>
> But as I mentioned this can be fixed separately if you don't have other
> comments on this version.
Thanks, I need to resend anyway to fix patch 7.
Thanks,
Jean
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Auger Eric <eric.auger@redhat.com>
Cc: devicetree@vger.kernel.org, kevin.tian@intel.com,
linux-acpi@vger.kernel.org, robin.murphy@arm.com,
rjw@rjwysocki.net, robh+dt@kernel.org, sudeep.holla@arm.com,
vivek.gautam@arm.com, iommu@lists.linux-foundation.org,
linux-accelerators@lists.ozlabs.org, guohanjun@huawei.com,
zhangfei.gao@linaro.org, will@kernel.org,
linux-arm-kernel@lists.infradead.org, lenb@kernel.org
Subject: Re: [PATCH v12 10/10] iommu/arm-smmu-v3: Add stall support for platform devices
Date: Mon, 1 Feb 2021 16:19:50 +0100 [thread overview]
Message-ID: <YBgcFgXQCTEQNowo@myrica> (raw)
In-Reply-To: <47a65f65-26cb-de27-049a-48f2d083964a@redhat.com>
On Mon, Feb 01, 2021 at 02:16:16PM +0100, Auger Eric wrote:
> >>> + flt->type = IOMMU_FAULT_DMA_UNRECOV;
> >>> + flt->event = (struct iommu_fault_unrecoverable) {
> >>> + .reason = reason,
> >>> + .flags = IOMMU_FAULT_UNRECOV_ADDR_VALID |
> >>> + IOMMU_FAULT_UNRECOV_FETCH_ADDR_VALID,
> >> nit: shall IOMMU_FAULT_UNRECOV_FETCH_ADDR_VALID be set here? Supported
> >> unrecoverable faults feature the IPA field which is UNKNOWN for S1
> >> translations. fetch_addr rather was
> >> corresponding to WALK_EABT.Fetch_addr to me.
> >
> > Right I should drop the IPA part entirely, since we don't report S2 faults
> > in this patch.
> OK
>
> But as I mentioned this can be fixed separately if you don't have other
> comments on this version.
Thanks, I need to resend anyway to fix patch 7.
Thanks,
Jean
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: Auger Eric <eric.auger@redhat.com>
Cc: devicetree@vger.kernel.org, kevin.tian@intel.com,
lorenzo.pieralisi@arm.com, linux-acpi@vger.kernel.org,
robin.murphy@arm.com, joro@8bytes.org,
Jonathan.Cameron@huawei.com, rjw@rjwysocki.net,
robh+dt@kernel.org, sudeep.holla@arm.com, vivek.gautam@arm.com,
iommu@lists.linux-foundation.org, jacob.jun.pan@linux.intel.com,
shameerali.kolothum.thodi@huawei.com,
linux-accelerators@lists.ozlabs.org, guohanjun@huawei.com,
zhangfei.gao@linaro.org, baolu.lu@linux.intel.com,
will@kernel.org, linux-arm-kernel@lists.infradead.org,
lenb@kernel.org
Subject: Re: [PATCH v12 10/10] iommu/arm-smmu-v3: Add stall support for platform devices
Date: Mon, 1 Feb 2021 16:19:50 +0100 [thread overview]
Message-ID: <YBgcFgXQCTEQNowo@myrica> (raw)
In-Reply-To: <47a65f65-26cb-de27-049a-48f2d083964a@redhat.com>
On Mon, Feb 01, 2021 at 02:16:16PM +0100, Auger Eric wrote:
> >>> + flt->type = IOMMU_FAULT_DMA_UNRECOV;
> >>> + flt->event = (struct iommu_fault_unrecoverable) {
> >>> + .reason = reason,
> >>> + .flags = IOMMU_FAULT_UNRECOV_ADDR_VALID |
> >>> + IOMMU_FAULT_UNRECOV_FETCH_ADDR_VALID,
> >> nit: shall IOMMU_FAULT_UNRECOV_FETCH_ADDR_VALID be set here? Supported
> >> unrecoverable faults feature the IPA field which is UNKNOWN for S1
> >> translations. fetch_addr rather was
> >> corresponding to WALK_EABT.Fetch_addr to me.
> >
> > Right I should drop the IPA part entirely, since we don't report S2 faults
> > in this patch.
> OK
>
> But as I mentioned this can be fixed separately if you don't have other
> comments on this version.
Thanks, I need to resend anyway to fix patch 7.
Thanks,
Jean
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-01 15:21 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 15:43 [PATCH v12 00/10] iommu: I/O page faults for SMMUv3 Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` [PATCH v12 01/10] iommu: Fix comment for struct iommu_fwspec Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` [PATCH v12 02/10] iommu/arm-smmu-v3: Use device properties for pasid-num-bits Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-02-01 7:30 ` Auger Eric
2021-02-01 7:30 ` Auger Eric
2021-02-01 7:30 ` Auger Eric
2021-01-27 15:43 ` [PATCH v12 03/10] iommu: Separate IOMMU_DEV_FEAT_IOPF from IOMMU_DEV_FEAT_SVA Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-02-01 7:35 ` Auger Eric
2021-02-01 7:35 ` Auger Eric
2021-02-01 7:35 ` Auger Eric
2021-01-27 15:43 ` [PATCH v12 04/10] iommu/vt-d: Support IOMMU_DEV_FEAT_IOPF Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` [PATCH v12 05/10] uacce: Enable IOMMU_DEV_FEAT_IOPF Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` [PATCH v12 06/10] iommu: Add a page fault handler Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-31 18:29 ` Auger Eric
2021-01-31 18:29 ` Auger Eric
2021-01-31 18:29 ` Auger Eric
2021-02-02 5:51 ` Shenming Lu
2021-02-02 5:51 ` Shenming Lu
2021-02-02 5:51 ` Shenming Lu
2021-01-27 15:43 ` [PATCH v12 07/10] iommu/arm-smmu-v3: Maintain a SID->device structure Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` [PATCH v12 08/10] dt-bindings: document stall property for IOMMU masters Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-02-01 7:28 ` Auger Eric
2021-02-01 7:28 ` Auger Eric
2021-02-01 7:28 ` Auger Eric
2021-01-27 15:43 ` [PATCH v12 09/10] ACPI/IORT: Enable stall support for platform devices Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` [PATCH v12 10/10] iommu/arm-smmu-v3: Add " Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-27 15:43 ` Jean-Philippe Brucker
2021-01-31 18:29 ` Auger Eric
2021-01-31 18:29 ` Auger Eric
2021-01-31 18:29 ` Auger Eric
2021-02-01 11:12 ` Jean-Philippe Brucker
2021-02-01 11:12 ` Jean-Philippe Brucker
2021-02-01 11:12 ` Jean-Philippe Brucker
2021-02-01 13:16 ` Auger Eric
2021-02-01 13:16 ` Auger Eric
2021-02-01 13:16 ` Auger Eric
2021-02-01 15:19 ` Jean-Philippe Brucker [this message]
2021-02-01 15:19 ` Jean-Philippe Brucker
2021-02-01 15:19 ` Jean-Philippe Brucker
2021-02-01 1:18 ` Zhou Wang
2021-02-01 1:18 ` Zhou Wang
2021-02-01 1:18 ` Zhou Wang
2021-02-01 11:14 ` Jean-Philippe Brucker
2021-02-01 11:14 ` Jean-Philippe Brucker
2021-02-01 11:14 ` Jean-Philippe Brucker
2021-02-01 12:53 ` Zhou Wang
2021-02-01 12:53 ` Zhou Wang
2021-02-01 12:53 ` Zhou Wang
2021-02-26 9:43 ` Zhou Wang
2021-02-26 9:43 ` Zhou Wang
2021-02-26 9:43 ` Zhou Wang
2021-02-26 16:29 ` Jean-Philippe Brucker
2021-02-26 16:29 ` Jean-Philippe Brucker
2021-02-26 16:29 ` Jean-Philippe Brucker
2021-02-27 3:40 ` Zhou Wang
2021-02-27 3:40 ` Zhou Wang
2021-02-27 3:40 ` Zhou Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBgcFgXQCTEQNowo@myrica \
--to=jean-philippe@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=baolu.lu@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=eric.auger@redhat.com \
--cc=guohanjun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=lenb@kernel.org \
--cc=linux-accelerators@lists.ozlabs.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=sudeep.holla@arm.com \
--cc=vivek.gautam@arm.com \
--cc=will@kernel.org \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.