From: Dan Carpenter <dan.carpenter@oracle.com> To: Jeff Layton <jlayton@kernel.org> Cc: Ilya Dryomov <idryomov@gmail.com>, ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] ceph: Fix an Oops in error handling Date: Tue, 2 Feb 2021 08:47:39 +0300 [thread overview] Message-ID: <YBjne8A1gn0mvQtT@mwanda> (raw) The "req" pointer is an error pointer and not NULL so this check needs to be fixed. Fixes: 1cf7fdf52d5a ("ceph: convert readpage to fscache read helper") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- fs/ceph/addr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 5eec6f66fe52..fb0238a4d34f 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -273,7 +273,7 @@ static void ceph_netfs_issue_op(struct netfs_read_subrequest *subreq) if (err) iput(inode); out: - if (req) + if (!IS_ERR_OR_NULL(req)) ceph_osdc_put_request(req); if (err) netfs_subreq_terminated(subreq, err); -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Jeff Layton <jlayton@kernel.org> Cc: Ilya Dryomov <idryomov@gmail.com>, ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] ceph: Fix an Oops in error handling Date: Tue, 02 Feb 2021 05:47:39 +0000 [thread overview] Message-ID: <YBjne8A1gn0mvQtT@mwanda> (raw) The "req" pointer is an error pointer and not NULL so this check needs to be fixed. Fixes: 1cf7fdf52d5a ("ceph: convert readpage to fscache read helper") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- fs/ceph/addr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 5eec6f66fe52..fb0238a4d34f 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -273,7 +273,7 @@ static void ceph_netfs_issue_op(struct netfs_read_subrequest *subreq) if (err) iput(inode); out: - if (req) + if (!IS_ERR_OR_NULL(req)) ceph_osdc_put_request(req); if (err) netfs_subreq_terminated(subreq, err); -- 2.29.2
next reply other threads:[~2021-02-02 5:48 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-02 5:47 Dan Carpenter [this message] 2021-02-02 5:47 ` [PATCH] ceph: Fix an Oops in error handling Dan Carpenter 2021-02-02 12:35 ` Ilya Dryomov 2021-02-02 12:35 ` Ilya Dryomov 2021-02-02 12:37 ` Jeff Layton 2021-02-02 12:37 ` Jeff Layton 2021-02-02 14:19 ` Dan Carpenter 2021-02-02 14:19 ` Dan Carpenter 2021-02-02 13:10 [PATCH] ceph: fix an oops in error handling in ceph_netfs_issue_op Jeff Layton 2021-02-02 13:10 ` Jeff Layton 2021-02-02 14:20 ` Dan Carpenter 2021-02-02 14:20 ` Dan Carpenter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YBjne8A1gn0mvQtT@mwanda \ --to=dan.carpenter@oracle.com \ --cc=ceph-devel@vger.kernel.org \ --cc=idryomov@gmail.com \ --cc=jlayton@kernel.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.