* [PATCH 1/1] docs: luks2: Mention key derival function support
@ 2021-02-03 11:02 Petr Vorel
2021-02-03 19:07 ` Patrick Steinhardt
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Petr Vorel @ 2021-02-03 11:02 UTC (permalink / raw)
To: grub-devel; +Cc: Petr Vorel, Patrick Steinhardt, Daniel Kiper
To give users hint why Argon2 (the default in cryptsetup for LUKS2)
does not work.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi,
it'd be nice to have it for Grub 2.06.
Kind regards,
Petr
docs/grub.texi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/grub.texi b/docs/grub.texi
index eeac9b2ce..7360da128 100644
--- a/docs/grub.texi
+++ b/docs/grub.texi
@@ -4291,7 +4291,8 @@ devices; option @option{-b} configures all geli containers that have boot flag s
GRUB suports devices encrypted using LUKS, LUKS2 and geli. Note that necessary
modules (@var{luks}, @var{luks2} and @var{geli}) have to be loaded manually
-before this command can be used.
+before this command can be used. For LUKS2 only the PBKDF2 key derival
+function is supported (Argon2 is not yet supported).
@end deffn
--
2.30.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] docs: luks2: Mention key derival function support
2021-02-03 11:02 [PATCH 1/1] docs: luks2: Mention key derival function support Petr Vorel
@ 2021-02-03 19:07 ` Patrick Steinhardt
2021-02-03 20:50 ` Paul Menzel
2021-02-11 12:37 ` Milan Broz
2 siblings, 0 replies; 6+ messages in thread
From: Patrick Steinhardt @ 2021-02-03 19:07 UTC (permalink / raw)
To: Petr Vorel; +Cc: grub-devel, Daniel Kiper
[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]
On Wed, Feb 03, 2021 at 12:02:19PM +0100, Petr Vorel wrote:
> To give users hint why Argon2 (the default in cryptsetup for LUKS2)
> does not work.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
Reviewed-by: Patrick Steinhardt <ps@pks.im>
> ---
> Hi,
>
> it'd be nice to have it for Grub 2.06.
>
> Kind regards,
> Petr
Make sense to me, thanks! I don't see a reason to not include it in
v2.06 to set expectations straight.
Patrick
> docs/grub.texi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/docs/grub.texi b/docs/grub.texi
> index eeac9b2ce..7360da128 100644
> --- a/docs/grub.texi
> +++ b/docs/grub.texi
> @@ -4291,7 +4291,8 @@ devices; option @option{-b} configures all geli containers that have boot flag s
>
> GRUB suports devices encrypted using LUKS, LUKS2 and geli. Note that necessary
> modules (@var{luks}, @var{luks2} and @var{geli}) have to be loaded manually
> -before this command can be used.
> +before this command can be used. For LUKS2 only the PBKDF2 key derival
> +function is supported (Argon2 is not yet supported).
> @end deffn
>
>
> --
> 2.30.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] docs: luks2: Mention key derival function support
2021-02-03 11:02 [PATCH 1/1] docs: luks2: Mention key derival function support Petr Vorel
2021-02-03 19:07 ` Patrick Steinhardt
@ 2021-02-03 20:50 ` Paul Menzel
2021-02-04 7:08 ` Petr Vorel
2021-02-11 12:37 ` Milan Broz
2 siblings, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2021-02-03 20:50 UTC (permalink / raw)
To: Petr Vorel; +Cc: Patrick Steinhardt, Daniel Kiper, grub-devel
Dear Petr,
Thank you for your patch.
Am 03.02.21 um 12:02 schrieb Petr Vorel:
> To give users hint why Argon2 (the default in cryptsetup for LUKS2)
> does not work.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
[…]
> docs/grub.texi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/docs/grub.texi b/docs/grub.texi
> index eeac9b2ce..7360da128 100644
> --- a/docs/grub.texi
> +++ b/docs/grub.texi
> @@ -4291,7 +4291,8 @@ devices; option @option{-b} configures all geli containers that have boot flag s
>
> GRUB suports devices encrypted using LUKS, LUKS2 and geli. Note that necessary
> modules (@var{luks}, @var{luks2} and @var{geli}) have to be loaded manually
> -before this command can be used.
> +before this command can be used. For LUKS2 only the PBKDF2 key derival
> +function is supported (Argon2 is not yet supported).
Nit: I’d get rid of the parentheses.
> For LUKS2 only the PBKDF2 key derival function is supported, as
> Argon2 is not yet supported.
Either way:
Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] docs: luks2: Mention key derival function support
2021-02-03 20:50 ` Paul Menzel
@ 2021-02-04 7:08 ` Petr Vorel
0 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2021-02-04 7:08 UTC (permalink / raw)
To: The development of GNU GRUB; +Cc: Petr Vorel, Patrick Steinhardt, Daniel Kiper
Hi Paul, Patrick,
> Dear Petr,
> Thank you for your patch.
thanks for your review!
...
> > -before this command can be used.
> > +before this command can be used. For LUKS2 only the PBKDF2 key derival
> > +function is supported (Argon2 is not yet supported).
> Nit: I’d get rid of the parentheses.
That's indeed better, thanks!
Sending v2 so that maintainers does not have to amend the patch.
Kind regards,
Petr
> > For LUKS2 only the PBKDF2 key derival function is supported, as
> > Argon2 is not yet supported.
> Either way:
> Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>
> Kind regards,
> Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] docs: luks2: Mention key derival function support
2021-02-03 11:02 [PATCH 1/1] docs: luks2: Mention key derival function support Petr Vorel
2021-02-03 19:07 ` Patrick Steinhardt
2021-02-03 20:50 ` Paul Menzel
@ 2021-02-11 12:37 ` Milan Broz
2021-02-12 6:58 ` Petr Vorel
2 siblings, 1 reply; 6+ messages in thread
From: Milan Broz @ 2021-02-11 12:37 UTC (permalink / raw)
To: The development of GNU GRUB, Petr Vorel; +Cc: Patrick Steinhardt, Daniel Kiper
On 03/02/2021 12:02, Petr Vorel wrote:
> To give users hint why Argon2 (the default in cryptsetup for LUKS2)
> does not work.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi,
>
> it'd be nice to have it for Grub 2.06.
>
> Kind regards,
> Petr
>
> docs/grub.texi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/docs/grub.texi b/docs/grub.texi
> index eeac9b2ce..7360da128 100644
> --- a/docs/grub.texi
> +++ b/docs/grub.texi
> @@ -4291,7 +4291,8 @@ devices; option @option{-b} configures all geli containers that have boot flag s
>
> GRUB suports devices encrypted using LUKS, LUKS2 and geli. Note that necessary
> modules (@var{luks}, @var{luks2} and @var{geli}) have to be loaded manually
> -before this command can be used.
> +before this command can be used. For LUKS2 only the PBKDF2 key derival
> +function is supported (Argon2 is not yet supported).
Just a small correction - the proper term is "key derivation function" (not derival).
Milan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] docs: luks2: Mention key derival function support
2021-02-11 12:37 ` Milan Broz
@ 2021-02-12 6:58 ` Petr Vorel
0 siblings, 0 replies; 6+ messages in thread
From: Petr Vorel @ 2021-02-12 6:58 UTC (permalink / raw)
To: Milan Broz; +Cc: The development of GNU GRUB, Patrick Steinhardt, Daniel Kiper
Hi Milan,
...
> > GRUB suports devices encrypted using LUKS, LUKS2 and geli. Note that necessary
> > modules (@var{luks}, @var{luks2} and @var{geli}) have to be loaded manually
> > -before this command can be used.
> > +before this command can be used. For LUKS2 only the PBKDF2 key derival
> > +function is supported (Argon2 is not yet supported).
> Just a small correction - the proper term is "key derivation function" (not derival).
Thanks a lot! I'll send v3.
Kind regards,
Petr
> Milan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-12 6:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 11:02 [PATCH 1/1] docs: luks2: Mention key derival function support Petr Vorel
2021-02-03 19:07 ` Patrick Steinhardt
2021-02-03 20:50 ` Paul Menzel
2021-02-04 7:08 ` Petr Vorel
2021-02-11 12:37 ` Milan Broz
2021-02-12 6:58 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.