* Re: FAILED: patch "[PATCH] arm64: Fix kernel address detection of __is_lm_address()" failed to apply to 5.4-stable tree
[not found] <1612104058247187@kroah.com>
@ 2021-02-03 13:15 ` Catalin Marinas
2021-02-04 15:08 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Catalin Marinas @ 2021-02-03 13:15 UTC (permalink / raw)
To: gregkh; +Cc: vincenzo.frascino, mark.rutland, stable, will
Hi Greg,
On Sun, Jan 31, 2021 at 03:40:58PM +0100, Greg Kroah-Hartman wrote:
> The patch below does not apply to the 5.4-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git commit
> id to <stable@vger.kernel.org>.
>
> thanks,
>
> greg k-h
>
> ------------------ original commit in Linus's tree ------------------
>
> From 519ea6f1c82fcdc9842908155ae379de47818778 Mon Sep 17 00:00:00 2001
> From: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Date: Tue, 26 Jan 2021 13:40:56 +0000
> Subject: [PATCH] arm64: Fix kernel address detection of __is_lm_address()
>
> Currently, the __is_lm_address() check just masks out the top 12 bits
> of the address, but if they are 0, it still yields a true result.
> This has as a side effect that virt_addr_valid() returns true even for
> invalid virtual addresses (e.g. 0x0).
>
> Fix the detection checking that it's actually a kernel address starting
> at PAGE_OFFSET.
>
> Fixes: 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()")
> Cc: <stable@vger.kernel.org> # 5.4.x
> Cc: Will Deacon <will@kernel.org>
> Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Link: https://lore.kernel.org/r/20210126134056.45747-1-vincenzo.frascino@arm.com
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
I sent you the 5.4 and 5.10 backports of this patch. There is another
fix in this area which I'll send to Linus tonight. It should apply
cleanly on 5.4 and 5.10.
Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: FAILED: patch "[PATCH] arm64: Fix kernel address detection of __is_lm_address()" failed to apply to 5.4-stable tree
2021-02-03 13:15 ` FAILED: patch "[PATCH] arm64: Fix kernel address detection of __is_lm_address()" failed to apply to 5.4-stable tree Catalin Marinas
@ 2021-02-04 15:08 ` Greg KH
2021-02-04 15:12 ` Catalin Marinas
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2021-02-04 15:08 UTC (permalink / raw)
To: Catalin Marinas; +Cc: vincenzo.frascino, mark.rutland, stable, will
On Wed, Feb 03, 2021 at 01:15:03PM +0000, Catalin Marinas wrote:
> Hi Greg,
>
> On Sun, Jan 31, 2021 at 03:40:58PM +0100, Greg Kroah-Hartman wrote:
> > The patch below does not apply to the 5.4-stable tree.
> > If someone wants it applied there, or to any other stable or longterm
> > tree, then please email the backport, including the original git commit
> > id to <stable@vger.kernel.org>.
> >
> > thanks,
> >
> > greg k-h
> >
> > ------------------ original commit in Linus's tree ------------------
> >
> > From 519ea6f1c82fcdc9842908155ae379de47818778 Mon Sep 17 00:00:00 2001
> > From: Vincenzo Frascino <vincenzo.frascino@arm.com>
> > Date: Tue, 26 Jan 2021 13:40:56 +0000
> > Subject: [PATCH] arm64: Fix kernel address detection of __is_lm_address()
> >
> > Currently, the __is_lm_address() check just masks out the top 12 bits
> > of the address, but if they are 0, it still yields a true result.
> > This has as a side effect that virt_addr_valid() returns true even for
> > invalid virtual addresses (e.g. 0x0).
> >
> > Fix the detection checking that it's actually a kernel address starting
> > at PAGE_OFFSET.
> >
> > Fixes: 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()")
> > Cc: <stable@vger.kernel.org> # 5.4.x
> > Cc: Will Deacon <will@kernel.org>
> > Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
> > Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> > Acked-by: Mark Rutland <mark.rutland@arm.com>
> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> > Link: https://lore.kernel.org/r/20210126134056.45747-1-vincenzo.frascino@arm.com
> > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
>
> I sent you the 5.4 and 5.10 backports of this patch. There is another
> fix in this area which I'll send to Linus tonight. It should apply
> cleanly on 5.4 and 5.10.
Both now applied. What is the git id of the other fix in Linus's tree?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: FAILED: patch "[PATCH] arm64: Fix kernel address detection of __is_lm_address()" failed to apply to 5.4-stable tree
2021-02-04 15:08 ` Greg KH
@ 2021-02-04 15:12 ` Catalin Marinas
2021-02-04 15:27 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Catalin Marinas @ 2021-02-04 15:12 UTC (permalink / raw)
To: Greg KH; +Cc: vincenzo.frascino, mark.rutland, stable, will
On Thu, Feb 04, 2021 at 04:08:02PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Feb 03, 2021 at 01:15:03PM +0000, Catalin Marinas wrote:
> > On Sun, Jan 31, 2021 at 03:40:58PM +0100, Greg Kroah-Hartman wrote:
> > > From 519ea6f1c82fcdc9842908155ae379de47818778 Mon Sep 17 00:00:00 2001
> > > From: Vincenzo Frascino <vincenzo.frascino@arm.com>
> > > Date: Tue, 26 Jan 2021 13:40:56 +0000
> > > Subject: [PATCH] arm64: Fix kernel address detection of __is_lm_address()
> > >
> > > Currently, the __is_lm_address() check just masks out the top 12 bits
> > > of the address, but if they are 0, it still yields a true result.
> > > This has as a side effect that virt_addr_valid() returns true even for
> > > invalid virtual addresses (e.g. 0x0).
> > >
> > > Fix the detection checking that it's actually a kernel address starting
> > > at PAGE_OFFSET.
> > >
> > > Fixes: 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()")
> > > Cc: <stable@vger.kernel.org> # 5.4.x
> > > Cc: Will Deacon <will@kernel.org>
> > > Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
> > > Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> > > Acked-by: Mark Rutland <mark.rutland@arm.com>
> > > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> > > Link: https://lore.kernel.org/r/20210126134056.45747-1-vincenzo.frascino@arm.com
> > > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> >
> > I sent you the 5.4 and 5.10 backports of this patch. There is another
> > fix in this area which I'll send to Linus tonight. It should apply
> > cleanly on 5.4 and 5.10.
>
> Both now applied. What is the git id of the other fix in Linus's tree?
Thanks. The other commit is 91cb2c8b072e ("arm64: Do not pass tagged
addresses to __is_lm_address()").
--
Catalin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: FAILED: patch "[PATCH] arm64: Fix kernel address detection of __is_lm_address()" failed to apply to 5.4-stable tree
2021-02-04 15:12 ` Catalin Marinas
@ 2021-02-04 15:27 ` Greg KH
2021-02-04 15:28 ` Catalin Marinas
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2021-02-04 15:27 UTC (permalink / raw)
To: Catalin Marinas; +Cc: vincenzo.frascino, mark.rutland, stable, will
On Thu, Feb 04, 2021 at 03:12:52PM +0000, Catalin Marinas wrote:
> On Thu, Feb 04, 2021 at 04:08:02PM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Feb 03, 2021 at 01:15:03PM +0000, Catalin Marinas wrote:
> > > On Sun, Jan 31, 2021 at 03:40:58PM +0100, Greg Kroah-Hartman wrote:
> > > > From 519ea6f1c82fcdc9842908155ae379de47818778 Mon Sep 17 00:00:00 2001
> > > > From: Vincenzo Frascino <vincenzo.frascino@arm.com>
> > > > Date: Tue, 26 Jan 2021 13:40:56 +0000
> > > > Subject: [PATCH] arm64: Fix kernel address detection of __is_lm_address()
> > > >
> > > > Currently, the __is_lm_address() check just masks out the top 12 bits
> > > > of the address, but if they are 0, it still yields a true result.
> > > > This has as a side effect that virt_addr_valid() returns true even for
> > > > invalid virtual addresses (e.g. 0x0).
> > > >
> > > > Fix the detection checking that it's actually a kernel address starting
> > > > at PAGE_OFFSET.
> > > >
> > > > Fixes: 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()")
> > > > Cc: <stable@vger.kernel.org> # 5.4.x
> > > > Cc: Will Deacon <will@kernel.org>
> > > > Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
> > > > Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> > > > Acked-by: Mark Rutland <mark.rutland@arm.com>
> > > > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> > > > Link: https://lore.kernel.org/r/20210126134056.45747-1-vincenzo.frascino@arm.com
> > > > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> > >
> > > I sent you the 5.4 and 5.10 backports of this patch. There is another
> > > fix in this area which I'll send to Linus tonight. It should apply
> > > cleanly on 5.4 and 5.10.
> >
> > Both now applied. What is the git id of the other fix in Linus's tree?
>
> Thanks. The other commit is 91cb2c8b072e ("arm64: Do not pass tagged
> addresses to __is_lm_address()").
Great, grabbed that now too, thanks.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: FAILED: patch "[PATCH] arm64: Fix kernel address detection of __is_lm_address()" failed to apply to 5.4-stable tree
2021-02-04 15:27 ` Greg KH
@ 2021-02-04 15:28 ` Catalin Marinas
0 siblings, 0 replies; 5+ messages in thread
From: Catalin Marinas @ 2021-02-04 15:28 UTC (permalink / raw)
To: Greg KH; +Cc: vincenzo.frascino, mark.rutland, stable, will
On Thu, Feb 04, 2021 at 04:27:28PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Feb 04, 2021 at 03:12:52PM +0000, Catalin Marinas wrote:
> > On Thu, Feb 04, 2021 at 04:08:02PM +0100, Greg Kroah-Hartman wrote:
> > > On Wed, Feb 03, 2021 at 01:15:03PM +0000, Catalin Marinas wrote:
> > > > On Sun, Jan 31, 2021 at 03:40:58PM +0100, Greg Kroah-Hartman wrote:
> > > > > From 519ea6f1c82fcdc9842908155ae379de47818778 Mon Sep 17 00:00:00 2001
> > > > > From: Vincenzo Frascino <vincenzo.frascino@arm.com>
> > > > > Date: Tue, 26 Jan 2021 13:40:56 +0000
> > > > > Subject: [PATCH] arm64: Fix kernel address detection of __is_lm_address()
> > > > >
> > > > > Currently, the __is_lm_address() check just masks out the top 12 bits
> > > > > of the address, but if they are 0, it still yields a true result.
> > > > > This has as a side effect that virt_addr_valid() returns true even for
> > > > > invalid virtual addresses (e.g. 0x0).
> > > > >
> > > > > Fix the detection checking that it's actually a kernel address starting
> > > > > at PAGE_OFFSET.
> > > > >
> > > > > Fixes: 68dd8ef32162 ("arm64: memory: Fix virt_addr_valid() using __is_lm_address()")
> > > > > Cc: <stable@vger.kernel.org> # 5.4.x
> > > > > Cc: Will Deacon <will@kernel.org>
> > > > > Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
> > > > > Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> > > > > Acked-by: Mark Rutland <mark.rutland@arm.com>
> > > > > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> > > > > Link: https://lore.kernel.org/r/20210126134056.45747-1-vincenzo.frascino@arm.com
> > > > > Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> > > >
> > > > I sent you the 5.4 and 5.10 backports of this patch. There is another
> > > > fix in this area which I'll send to Linus tonight. It should apply
> > > > cleanly on 5.4 and 5.10.
> > >
> > > Both now applied. What is the git id of the other fix in Linus's tree?
> >
> > Thanks. The other commit is 91cb2c8b072e ("arm64: Do not pass tagged
> > addresses to __is_lm_address()").
>
> Great, grabbed that now too, thanks.
Thanks Greg.
--
Catalin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-04 16:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1612104058247187@kroah.com>
2021-02-03 13:15 ` FAILED: patch "[PATCH] arm64: Fix kernel address detection of __is_lm_address()" failed to apply to 5.4-stable tree Catalin Marinas
2021-02-04 15:08 ` Greg KH
2021-02-04 15:12 ` Catalin Marinas
2021-02-04 15:27 ` Greg KH
2021-02-04 15:28 ` Catalin Marinas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.