From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: lyude@redhat.com, Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>,
nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
open list <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org, greg.depoire@gmail.com,
Sean Paul <seanpaul@chromium.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [Intel-gfx] [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers
Date: Thu, 18 Feb 2021 17:31:51 +0200 [thread overview]
Message-ID: <YC6IZ+BUcA5uDCej@intel.com> (raw)
In-Reply-To: <87mtw1ai4m.fsf@intel.com>
On Thu, Feb 18, 2021 at 10:35:05AM +0200, Jani Nikula wrote:
> On Fri, 12 Feb 2021, Lyude Paul <lyude@redhat.com> wrote:
> > I think it wouldn't be a bad idea to just address this with a followup series
> > instead and use the old DRM_DEBUG_* macros in the mean time.
>
> aux->dev is there, could also use dev_dbg et al. in the mean time. They
> handle NULL dev gracefully too if the driver didn't set that.
Last I looked aux->dev was random. Some drivers point it at the
connector vs. some at the the pci/platform device.
--
Ville Syrjälä
Intel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: David Airlie <airlied@linux.ie>,
nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
open list <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org, greg.depoire@gmail.com,
Sean Paul <seanpaul@chromium.org>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [Nouveau] [Intel-gfx] [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers
Date: Thu, 18 Feb 2021 17:31:51 +0200 [thread overview]
Message-ID: <YC6IZ+BUcA5uDCej@intel.com> (raw)
In-Reply-To: <87mtw1ai4m.fsf@intel.com>
On Thu, Feb 18, 2021 at 10:35:05AM +0200, Jani Nikula wrote:
> On Fri, 12 Feb 2021, Lyude Paul <lyude@redhat.com> wrote:
> > I think it wouldn't be a bad idea to just address this with a followup series
> > instead and use the old DRM_DEBUG_* macros in the mean time.
>
> aux->dev is there, could also use dev_dbg et al. in the mean time. They
> handle NULL dev gracefully too if the driver didn't set that.
Last I looked aux->dev was random. Some drivers point it at the
connector vs. some at the the pci/platform device.
--
Ville Syrjälä
Intel
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: David Airlie <airlied@linux.ie>,
nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
open list <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org, greg.depoire@gmail.com,
Sean Paul <seanpaul@chromium.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [Intel-gfx] [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers
Date: Thu, 18 Feb 2021 17:31:51 +0200 [thread overview]
Message-ID: <YC6IZ+BUcA5uDCej@intel.com> (raw)
In-Reply-To: <87mtw1ai4m.fsf@intel.com>
On Thu, Feb 18, 2021 at 10:35:05AM +0200, Jani Nikula wrote:
> On Fri, 12 Feb 2021, Lyude Paul <lyude@redhat.com> wrote:
> > I think it wouldn't be a bad idea to just address this with a followup series
> > instead and use the old DRM_DEBUG_* macros in the mean time.
>
> aux->dev is there, could also use dev_dbg et al. in the mean time. They
> handle NULL dev gracefully too if the driver didn't set that.
Last I looked aux->dev was random. Some drivers point it at the
connector vs. some at the the pci/platform device.
--
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: David Airlie <airlied@linux.ie>,
nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
open list <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org, greg.depoire@gmail.com,
Sean Paul <seanpaul@chromium.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Dave Airlie <airlied@redhat.com>
Subject: Re: [Intel-gfx] [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers
Date: Thu, 18 Feb 2021 17:31:51 +0200 [thread overview]
Message-ID: <YC6IZ+BUcA5uDCej@intel.com> (raw)
In-Reply-To: <87mtw1ai4m.fsf@intel.com>
On Thu, Feb 18, 2021 at 10:35:05AM +0200, Jani Nikula wrote:
> On Fri, 12 Feb 2021, Lyude Paul <lyude@redhat.com> wrote:
> > I think it wouldn't be a bad idea to just address this with a followup series
> > instead and use the old DRM_DEBUG_* macros in the mean time.
>
> aux->dev is there, could also use dev_dbg et al. in the mean time. They
> handle NULL dev gracefully too if the driver didn't set that.
Last I looked aux->dev was random. Some drivers point it at the
connector vs. some at the the pci/platform device.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-02-18 18:07 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 23:38 [Nouveau] [RFC v4 00/11] drm: Extract DPCD backlight helpers from i915, add support in nouveau Lyude Paul
2021-02-08 23:38 ` [Intel-gfx] " Lyude Paul
2021-02-08 23:38 ` Lyude Paul
2021-02-08 23:38 ` [RFC v4 01/11] drm/nouveau/kms/nv40-/backlight: Assign prop type once Lyude Paul
2021-02-08 23:38 ` [Intel-gfx] " Lyude Paul
2021-02-08 23:38 ` Lyude Paul
2021-02-08 23:38 ` [Nouveau] " Lyude Paul
2021-02-08 23:38 ` [RFC v4 02/11] drm/nouveau/kms: Don't probe eDP connectors more then once Lyude Paul
2021-02-08 23:38 ` [Intel-gfx] " Lyude Paul
2021-02-08 23:38 ` Lyude Paul
2021-02-08 23:38 ` [Nouveau] " Lyude Paul
2021-02-08 23:38 ` [RFC v4 03/11] drm/i915/dpcd_bl: Remove redundant AUX backlight frequency calculations Lyude Paul
2021-02-08 23:38 ` [Intel-gfx] " Lyude Paul
2021-02-08 23:38 ` Lyude Paul
2021-02-08 23:38 ` [Nouveau] " Lyude Paul
2021-02-08 23:38 ` [RFC v4 04/11] drm/i915/dpcd_bl: Handle drm_dpcd_read/write() return values correctly Lyude Paul
2021-02-08 23:38 ` [Intel-gfx] " Lyude Paul
2021-02-08 23:38 ` Lyude Paul
2021-02-08 23:38 ` [Nouveau] " Lyude Paul
2021-02-08 23:38 ` [RFC v4 05/11] drm/i915/dpcd_bl: Cleanup intel_dp_aux_vesa_enable_backlight() a bit Lyude Paul
2021-02-08 23:38 ` [Intel-gfx] " Lyude Paul
2021-02-08 23:38 ` Lyude Paul
2021-02-08 23:38 ` [Nouveau] " Lyude Paul
2021-02-11 3:56 ` Rodrigo Vivi
2021-02-11 3:56 ` [Intel-gfx] " Rodrigo Vivi
2021-02-11 3:56 ` Rodrigo Vivi
2021-02-11 3:56 ` [Nouveau] " Rodrigo Vivi
2021-02-12 11:28 ` Jani Nikula
2021-02-12 11:28 ` [Intel-gfx] " Jani Nikula
2021-02-12 11:28 ` Jani Nikula
2021-02-12 11:28 ` [Nouveau] " Jani Nikula
2021-02-08 23:38 ` [RFC v4 06/11] drm/i915/dpcd_bl: Cache some backlight capabilities in intel_panel.backlight Lyude Paul
2021-02-08 23:38 ` [Intel-gfx] " Lyude Paul
2021-02-08 23:38 ` Lyude Paul
2021-02-08 23:38 ` [Nouveau] " Lyude Paul
2021-02-08 23:38 ` [RFC v4 07/11] drm/i915/dpcd_bl: Move VESA backlight enabling code closer together Lyude Paul
2021-02-08 23:38 ` [Intel-gfx] " Lyude Paul
2021-02-08 23:38 ` Lyude Paul
2021-02-08 23:38 ` [Nouveau] " Lyude Paul
2021-02-08 23:38 ` [RFC v4 08/11] drm/i915/dpcd_bl: Return early in vesa_calc_max_backlight if we can't read PWMGEN_BIT_COUNT Lyude Paul
2021-02-08 23:38 ` [Intel-gfx] " Lyude Paul
2021-02-08 23:38 ` Lyude Paul
2021-02-08 23:38 ` [Nouveau] " Lyude Paul
2021-02-11 3:52 ` [Intel-gfx] " Rodrigo Vivi
2021-02-11 3:52 ` Rodrigo Vivi
2021-02-11 3:52 ` Rodrigo Vivi
2021-02-11 3:52 ` [Nouveau] " Rodrigo Vivi
2021-02-08 23:38 ` [RFC v4 09/11] drm/i915/dpcd_bl: Print return codes for VESA backlight failures Lyude Paul
2021-02-08 23:38 ` [Intel-gfx] " Lyude Paul
2021-02-08 23:38 ` Lyude Paul
2021-02-08 23:38 ` [Nouveau] " Lyude Paul
2021-02-11 3:47 ` [Intel-gfx] " Rodrigo Vivi
2021-02-11 3:47 ` Rodrigo Vivi
2021-02-11 3:47 ` Rodrigo Vivi
2021-02-11 3:47 ` [Nouveau] " Rodrigo Vivi
2021-02-08 23:39 ` [RFC v4 10/11] drm/dp: Extract i915's eDP backlight code into DRM helpers Lyude Paul
2021-02-08 23:39 ` [Intel-gfx] " Lyude Paul
2021-02-08 23:39 ` Lyude Paul
2021-02-08 23:39 ` [Nouveau] " Lyude Paul
2021-02-11 4:15 ` [Intel-gfx] " Rodrigo Vivi
2021-02-11 4:15 ` Rodrigo Vivi
2021-02-11 4:15 ` Rodrigo Vivi
2021-02-11 4:15 ` [Nouveau] " Rodrigo Vivi
2021-02-11 18:35 ` Lyude Paul
2021-02-11 18:35 ` Lyude Paul
2021-02-11 18:35 ` Lyude Paul
2021-02-11 18:35 ` [Nouveau] " Lyude Paul
2021-02-12 22:15 ` Lyude Paul
2021-02-12 22:15 ` Lyude Paul
2021-02-12 22:15 ` Lyude Paul
2021-02-12 22:15 ` [Nouveau] " Lyude Paul
2021-02-18 8:35 ` Jani Nikula
2021-02-18 8:35 ` Jani Nikula
2021-02-18 8:35 ` Jani Nikula
2021-02-18 8:35 ` [Nouveau] " Jani Nikula
2021-02-18 15:31 ` Ville Syrjälä [this message]
2021-02-18 15:31 ` Ville Syrjälä
2021-02-18 15:31 ` Ville Syrjälä
2021-02-18 15:31 ` [Nouveau] " Ville Syrjälä
2021-02-19 21:14 ` Lyude Paul
2021-02-19 21:14 ` Lyude Paul
2021-02-19 21:14 ` Lyude Paul
2021-02-19 21:14 ` [Nouveau] " Lyude Paul
2021-02-08 23:39 ` [RFC v4 11/11] drm/nouveau/kms/nv50-: Add basic DPCD backlight support for nouveau Lyude Paul
2021-02-08 23:39 ` [Intel-gfx] " Lyude Paul
2021-02-08 23:39 ` Lyude Paul
2021-02-08 23:39 ` [Nouveau] " Lyude Paul
2021-02-08 23:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Extract DPCD backlight helpers from i915, add support in nouveau (rev6) Patchwork
2021-02-08 23:53 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-02-09 0:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-02-09 4:24 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC6IZ+BUcA5uDCej@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=greg.depoire@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=seanpaul@chromium.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.