All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH 1/1] configure: Fix pkg.m4 detection
@ 2021-02-18 15:07 Petr Vorel
  2021-02-18 15:09 ` Petr Vorel
  0 siblings, 1 reply; 4+ messages in thread
From: Petr Vorel @ 2021-02-18 15:07 UTC (permalink / raw)
  To: ltp

6e17e2ba1 attempt to detect missing pkg.m4, which usually gets installed
with pkg-config/pkgconfig. Unfortunately this macro is since 0.29, which
is too new for CentOS 7. Let's use PKG_CHECK_EXISTS, which is since 0.16
(old enough, we expect 0.24).

Fixes: 6e17e2ba1 ("configure: Improve error message on missing pkg-config")

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index beeb9e669..d41688f04 100644
--- a/configure.ac
+++ b/configure.ac
@@ -30,7 +30,7 @@ AC_DEFUN([AC_PROG_STRIP], [AC_CHECK_TOOL(STRIP, strip, :)])
 AC_PROG_STRIP
 AC_PROG_YACC
 
-m4_ifndef([PKG_PREREQ],
+m4_ifndef([PKG_CHECK_EXISTS],
 	[m4_fatal([must install pkg-config or pkgconfig and pkg.m4 macro (usual dependency), see INSTALL])])
 
 AC_PREFIX_DEFAULT(/opt/ltp)
-- 
2.30.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [LTP] [PATCH 1/1] configure: Fix pkg.m4 detection
  2021-02-18 15:07 [LTP] [PATCH 1/1] configure: Fix pkg.m4 detection Petr Vorel
@ 2021-02-18 15:09 ` Petr Vorel
  2021-02-18 15:11   ` Cyril Hrubis
  0 siblings, 1 reply; 4+ messages in thread
From: Petr Vorel @ 2021-02-18 15:09 UTC (permalink / raw)
  To: ltp

Hi,

> Fixes: 6e17e2ba1 ("configure: Improve error message on missing pkg-config")
I tested that locally, but this time I'll wait for CI to finish :).
https://travis-ci.org/github/pevik/ltp/builds/759488526

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [LTP] [PATCH 1/1] configure: Fix pkg.m4 detection
  2021-02-18 15:09 ` Petr Vorel
@ 2021-02-18 15:11   ` Cyril Hrubis
  2021-02-18 15:38     ` Petr Vorel
  0 siblings, 1 reply; 4+ messages in thread
From: Cyril Hrubis @ 2021-02-18 15:11 UTC (permalink / raw)
  To: ltp

Hi!
> > Fixes: 6e17e2ba1 ("configure: Improve error message on missing pkg-config")
> I tested that locally, but this time I'll wait for CI to finish :).
> https://travis-ci.org/github/pevik/ltp/builds/759488526

Feel free to push with my ack once the CI finishes.

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [LTP] [PATCH 1/1] configure: Fix pkg.m4 detection
  2021-02-18 15:11   ` Cyril Hrubis
@ 2021-02-18 15:38     ` Petr Vorel
  0 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2021-02-18 15:38 UTC (permalink / raw)
  To: ltp

Hi Cyril,

> > > Fixes: 6e17e2ba1 ("configure: Improve error message on missing pkg-config")
> > I tested that locally, but this time I'll wait for CI to finish :).
> > https://travis-ci.org/github/pevik/ltp/builds/759488526

> Feel free to push with my ack once the CI finishes.
Thanks! CI finished, patch merged.

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-18 15:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-18 15:07 [LTP] [PATCH 1/1] configure: Fix pkg.m4 detection Petr Vorel
2021-02-18 15:09 ` Petr Vorel
2021-02-18 15:11   ` Cyril Hrubis
2021-02-18 15:38     ` Petr Vorel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.