* [PATCH] staging: greybus: Fixed misspelling and alignment issue in hid.c
@ 2021-02-11 15:30 ` Pritthijit Nath
0 siblings, 0 replies; 4+ messages in thread
From: Pritthijit Nath @ 2021-02-11 15:30 UTC (permalink / raw)
To: vireshk, gregkh, johan, elder
Cc: greybus-dev, devel, linux-kernel, Pritthijit Nath
This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis".
In addition the misspelling of "transferred" also has been fixed.
Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
---
drivers/staging/greybus/hid.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
index ed706f39e87a..adb91286803a 100644
--- a/drivers/staging/greybus/hid.c
+++ b/drivers/staging/greybus/hid.c
@@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid)
}
static int __gb_hid_get_raw_report(struct hid_device *hid,
- unsigned char report_number, __u8 *buf, size_t count,
- unsigned char report_type)
+ unsigned char report_number, __u8 *buf, size_t count,
+ unsigned char report_type)
{
struct gb_hid *ghid = hid->driver_data;
int ret;
@@ -254,7 +254,7 @@ static int __gb_hid_output_raw_report(struct hid_device *hid, __u8 *buf,
ret = gb_hid_set_report(ghid, report_type, report_id, buf, len);
if (report_id && ret >= 0)
- ret++; /* add report_id to the number of transfered bytes */
+ ret++; /* add report_id to the number of transferred bytes */
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] staging: greybus: Fixed misspelling and alignment issue in hid.c
@ 2021-02-11 15:30 ` Pritthijit Nath
0 siblings, 0 replies; 4+ messages in thread
From: Pritthijit Nath @ 2021-02-11 15:30 UTC (permalink / raw)
To: vireshk, gregkh, johan, elder
Cc: devel, greybus-dev, Pritthijit Nath, linux-kernel
This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis".
In addition the misspelling of "transferred" also has been fixed.
Signed-off-by: Pritthijit Nath <pritthijit.nath@icloud.com>
---
drivers/staging/greybus/hid.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
index ed706f39e87a..adb91286803a 100644
--- a/drivers/staging/greybus/hid.c
+++ b/drivers/staging/greybus/hid.c
@@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid)
}
static int __gb_hid_get_raw_report(struct hid_device *hid,
- unsigned char report_number, __u8 *buf, size_t count,
- unsigned char report_type)
+ unsigned char report_number, __u8 *buf, size_t count,
+ unsigned char report_type)
{
struct gb_hid *ghid = hid->driver_data;
int ret;
@@ -254,7 +254,7 @@ static int __gb_hid_output_raw_report(struct hid_device *hid, __u8 *buf,
ret = gb_hid_set_report(ghid, report_type, report_id, buf, len);
if (report_id && ret >= 0)
- ret++; /* add report_id to the number of transfered bytes */
+ ret++; /* add report_id to the number of transferred bytes */
return 0;
}
--
2.25.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: greybus: Fixed misspelling and alignment issue in hid.c
2021-02-11 15:30 ` Pritthijit Nath
@ 2021-02-11 20:30 ` Greg KH
-1 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-02-11 20:30 UTC (permalink / raw)
To: Pritthijit Nath; +Cc: vireshk, johan, elder, devel, greybus-dev, linux-kernel
On Thu, Feb 11, 2021 at 09:00:01PM +0530, Pritthijit Nath wrote:
> This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis".
> In addition the misspelling of "transferred" also has been fixed.
When you say "also" or "in addition" in a changelog, that is a huge hint
that this needs to be broken up into multiple patches.
Please do so, and fix your changelog ling length and send this as a
patch series.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: greybus: Fixed misspelling and alignment issue in hid.c
@ 2021-02-11 20:30 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-02-11 20:30 UTC (permalink / raw)
To: Pritthijit Nath; +Cc: devel, elder, vireshk, johan, linux-kernel, greybus-dev
On Thu, Feb 11, 2021 at 09:00:01PM +0530, Pritthijit Nath wrote:
> This change fixes a checkpatch CHECK style issue for "Alignment should match open parenthesis".
> In addition the misspelling of "transferred" also has been fixed.
When you say "also" or "in addition" in a changelog, that is a huge hint
that this needs to be broken up into multiple patches.
Please do so, and fix your changelog ling length and send this as a
patch series.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-11 20:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-11 15:30 [PATCH] staging: greybus: Fixed misspelling and alignment issue in hid.c Pritthijit Nath
2021-02-11 15:30 ` Pritthijit Nath
2021-02-11 20:30 ` Greg KH
2021-02-11 20:30 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.