TPM returned invalid status

TPM returned invalid status

[Laurent Bigonville]

Hello,

I already posted that beginning of January in reply to "tpm_tis: Clean 
up locality release", but I didn't really got a reply

With debian unstable (Linux fornost 5.10.0-3-amd64 #1 SMP Debian 
5.10.12-1 (2021-01-30) x86_64 GNU/Linux), I get the following error:

[   13.733866] ------------[ cut here ]------------
[   13.733868] TPM returned invalid status
[   13.733889] WARNING: CPU: 3 PID: 444 at 
drivers/char/tpm/tpm_tis_core.c:249 tpm_tis_status+0x86/0xa0 [tpm_tis_core]
[   13.733890] Modules linked in: libiscsi joydev libaes 
scsi_transport_iscsi snd_timer snd soundcore i7core_edac pcc_cpufreq(-) 
i5500_temp tpm_tis(+) tpm_tis_core asus_atk0110 tpm evdev rng_core loop 
firewire_sbp2 msr parport_pc ppdev sunrpc lp parport fuse configfs 
ip_tables x_tables autofs4 ext4 crc16 mbcache jbd2 btrfs blake2b_generic 
raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor 
async_tx xor raid6_pq libcrc32c crc32c_generic raid1 raid0 multipath 
linear md_mod dm_mod sd_mod t10_pi crc_t10dif crct10dif_generic sr_mod 
cdrom crct10dif_common hid_generic usbhid hid amdgpu ahci libahci 
gpu_sched i2c_algo_bit libata ttm drm_kms_helper psmouse scsi_mod 
mxm_wmi crc32c_intel uhci_hcd i2c_i801 cec firewire_ohci i2c_smbus 
ehci_pci ehci_hcd firewire_core drm lpc_ich crc_itu_t usbcore sky2 
usb_common wmi button
[   13.733954] CPU: 3 PID: 444 Comm: systemd-udevd Tainted: G          
I       5.10.0-3-amd64 #1 Debian 5.10.12-1
[   13.733956] Hardware name: System manufacturer System Product 
Name/P6T DELUXE V2, BIOS 0406    04/24/2009
[   13.733959] RIP: 0010:tpm_tis_status+0x86/0xa0 [tpm_tis_core]
[   13.733962] Code: 00 75 30 48 83 c4 18 c3 31 c0 80 3d e3 48 00 00 00 
75 e0 48 c7 c7 4c f3 20 c1 88 44 24 07 c6 05 cf 48 00 00 01 e8 9a 47 c6 
f1 <0f> 0b 0f b6 44 24 07 eb c0 e8 3c be c9 f1 66 66 2e 0f 1f 84 00 00
[   13.733963] RSP: 0018:ffffbf23808fbaa0 EFLAGS: 00010286
[   13.733965] RAX: 0000000000000000 RBX: ffff979283e35000 RCX: 
ffff97962dad8a08
[   13.733967] RDX: 00000000ffffffd8 RSI: 0000000000000027 RDI: 
ffff97962dad8a00
[   13.733968] RBP: 00000000ffff5d8c R08: 0000000000000000 R09: 
ffffbf23808fb8c0
[   13.733970] R10: ffffbf23808fb8b8 R11: ffffffffb3ccb368 R12: 
0000000000000016
[   13.733971] R13: ffff9792c0128000 R14: 0000000000001000 R15: 
ffffbf23808fbada
[   13.733973] FS:  00007f06c63828c0(0000) GS:ffff97962dac0000(0000) 
knlGS:0000000000000000
[   13.733975] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   13.733976] CR2: 00007ffa0229121c CR3: 0000000110e60000 CR4: 
00000000000006e0
[   13.733978] Call Trace:
[   13.733987]  tpm_transmit+0x15f/0x3d0 [tpm]
[   13.733992]  tpm_transmit_cmd+0x25/0x90 [tpm]
[   13.733997]  tpm2_probe+0xe2/0x140 [tpm]
[   13.734000]  tpm_tis_core_init+0x1d5/0x2b0 [tpm_tis_core]
[   13.734006]  ? tpm_tis_init.part.0+0x130/0x130 [tpm_tis]
[   13.734008]  tpm_tis_pnp_init+0xe1/0x110 [tpm_tis]
[   13.734016]  pnp_device_probe+0xaf/0x140
[   13.734019]  really_probe+0xf2/0x440
[   13.734021]  driver_probe_device+0xe1/0x150
[   13.734024]  device_driver_attach+0xa1/0xb0
[   13.734026]  __driver_attach+0x8a/0x150
[   13.734027]  ? device_driver_attach+0xb0/0xb0
[   13.734028]  ? device_driver_attach+0xb0/0xb0
[   13.734030]  bus_for_each_dev+0x78/0xc0
[   13.734032]  bus_add_driver+0x12b/0x1e0
[   13.734034]  driver_register+0x8b/0xe0
[   13.734036]  ? 0xffffffffc121a000
[   13.734038]  init_tis+0xa0/0x1000 [tpm_tis]
[   13.734042]  do_one_initcall+0x44/0x1d0
[   13.734046]  ? do_init_module+0x23/0x260
[   13.734048]  ? kmem_cache_alloc_trace+0xf5/0x200
[   13.734050]  do_init_module+0x5c/0x260
[   13.734052]  __do_sys_finit_module+0xb1/0x110
[   13.734056]  do_syscall_64+0x33/0x80
[   13.734059]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[   13.734061] RIP: 0033:0x7f06c683b9b9
[   13.734063] Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 
48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 
05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d a7 54 0c 00 f7 d8 64 89 01 48
[   13.734064] RSP: 002b:00007ffe3ac07978 EFLAGS: 00000246 ORIG_RAX: 
0000000000000139
[   13.734065] RAX: ffffffffffffffda RBX: 000055c0f90a7a10 RCX: 
00007f06c683b9b9
[   13.734066] RDX: 0000000000000000 RSI: 00007f06c69c6e2d RDI: 
0000000000000012
[   13.734067] RBP: 0000000000020000 R08: 0000000000000000 R09: 
000055c0f8edcdc0
[   13.734068] R10: 0000000000000012 R11: 0000000000000246 R12: 
00007f06c69c6e2d
[   13.734069] R13: 0000000000000000 R14: 000055c0f90a55f0 R15: 
000055c0f90a7a10
[   13.734071] ---[ end trace a34082fc50077847 ]---
[   13.740689] tpm_tis 00:06: 1.2 TPM (device-id 0x6871, rev-id 1)

This is still a TPM 1.2 device and it seems to work as I can seal and 
unseal data (tpm_sealdata and tpm_unsealdata)

An idea what's happening?

Kind regards,

Laurent Bigonville

Re: TPM returned invalid status

[James Bottomley]

On Sat, 2021-02-06 at 00:31 +0100, Laurent Bigonville wrote:
> Hello,
> 
> I already posted that beginning of January in reply to "tpm_tis:
> Clean 
> up locality release", but I didn't really got a reply
> 
> With debian unstable (Linux fornost 5.10.0-3-amd64 #1 SMP Debian 
> 5.10.12-1 (2021-01-30) x86_64 GNU/Linux), I get the following error:

Sorry, forgot to cc you.  We're iterating to this as the fix:

https://lore.kernel.org/linux-integrity/20201001180925.13808-5-James.Bottomley@HansenPartnership.com/

If you want to test it out.

Thanks,

James

Re: TPM returned invalid status

[Laurent Bigonville]

Le 8/02/21 à 04:33, James Bottomley a écrit :
> On Sat, 2021-02-06 at 00:31 +0100, Laurent Bigonville wrote:
>> Hello,
>>
>> I already posted that beginning of January in reply to "tpm_tis:
>> Clean
>> up locality release", but I didn't really got a reply
>>
>> With debian unstable (Linux fornost 5.10.0-3-amd64 #1 SMP Debian
>> 5.10.12-1 (2021-01-30) x86_64 GNU/Linux), I get the following error:
> Sorry, forgot to cc you.  We're iterating to this as the fix:
>
> https://lore.kernel.org/linux-integrity/20201001180925.13808-5-James.Bottomley@HansenPartnership.com/
>
> If you want to test it out.

I recompiled 5.11.0-rc7+ with the patch and I still get the same trace

[   13.453169] ------------[ cut here ]------------
[   13.453174] TPM returned invalid status
[   13.453193] WARNING: CPU: 0 PID: 447 at 
drivers/char/tpm/tpm_tis_core.c:249 tpm_tis_status+0x86/0xa0 [tpm_tis_core]
[   13.453202] Modules linked in: tpm_tis(E+) tpm_tis_core(E) tpm(E) 
asus_atk0110(E) rng_core(E) evdev(E) fjes(E-) acpi_cpufreq(E-) loop(E+) 
firewire_sbp2(E) msr(E) parport_pc(E) ppdev(E) lp(E) parport(E) fuse(E) 
configfs(E) sunrpc(E) ip_tables(E) x_tables(E) autofs4(E) ext4(E) 
crc16(E) mbcache(E) jbd2(E) btrfs(E) blake2b_generic(E) zstd_compress(E) 
raid10(E) raid456(E) async_raid6_recov(E) async_memcpy(E) async_pq(E) 
async_xor(E) async_tx(E) xor(E) raid6_pq(E) libcrc32c(E) 
crc32c_generic(E) raid1(E) raid0(E) multipath(E) linear(E) md_mod(E) 
dm_mod(E) sr_mod(E) sd_mod(E) cdrom(E) t10_pi(E) hid_generic(E) 
usbhid(E) hid(E) amdgpu(E) ahci(E) gpu_sched(E) i2c_algo_bit(E) 
libahci(E) drm_ttm_helper(E) ttm(E) firewire_ohci(E) libata(E) 
drm_kms_helper(E) crc32c_intel(E) cec(E) i2c_i801(E) uhci_hcd(E) 
ehci_pci(E) mxm_wmi(E) psmouse(E) ehci_hcd(E) firewire_core(E) 
scsi_mod(E) i2c_smbus(E) lpc_ich(E) crc_itu_t(E) sky2(E) drm(E) 
usbcore(E) mfd_core(E) wmi(E) button(E)
[   13.453285] CPU: 0 PID: 447 Comm: systemd-udevd Tainted: G          I 
E     5.11.0-rc7+ #2
[   13.453288] Hardware name: System manufacturer System Product 
Name/P6T DELUXE V2, BIOS 0406    04/24/2009
[   13.453291] RIP: 0010:tpm_tis_status+0x86/0xa0 [tpm_tis_core]
[   13.453297] Code: 00 75 30 48 83 c4 18 c3 31 c0 80 3d e3 48 00 00 00 
75 e0 48 c7 c7 74 53 28 c1 88 44 24 07 c6 05 cf 48 00 00 01 e8 12 25 db 
e4 <0f> 0b 0f b6 44 24 07 eb c0 e8 5c 9a de e4 66 66 2e 0f 1f 84 00 00
[   13.453300] RSP: 0000:ffffc07880d57aa0 EFLAGS: 00010286
[   13.453303] RAX: 0000000000000000 RBX: ffff9f43cbf2a000 RCX: 
ffff9f476da18bc8
[   13.453305] RDX: 00000000ffffffd8 RSI: 0000000000000027 RDI: 
ffff9f476da18bc0
[   13.453307] RBP: 00000000ffff5d35 R08: 0000000000000000 R09: 
ffffc07880d578c0
[   13.453310] R10: ffffc07880d578b8 R11: ffffffffa6ac2588 R12: 
0000000000000016
[   13.453312] R13: ffff9f43ced90000 R14: 0000000000001000 R15: 
ffffc07880d57ada
[   13.453314] FS:  00007f47edbc28c0(0000) GS:ffff9f476da00000(0000) 
knlGS:0000000000000000
[   13.453317] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   13.453319] CR2: 00007f47ed30aa86 CR3: 000000010ed02000 CR4: 
00000000000006f0
[   13.453322] Call Trace:
[   13.453326]  tpm_transmit+0x15f/0x3d0 [tpm]
[   13.453337]  tpm_transmit_cmd+0x25/0x90 [tpm]
[   13.453345]  tpm2_probe+0xe2/0x140 [tpm]
[   13.453353]  tpm_tis_core_init+0x1d5/0x2b0 [tpm_tis_core]
[   13.453359]  ? tpm_tis_init.part.0+0x130/0x130 [tpm_tis]
[   13.453365]  tpm_tis_pnp_init+0xe1/0x110 [tpm_tis]
[   13.453371]  pnp_device_probe+0xaf/0x140
[   13.453378]  really_probe+0xf2/0x440
[   13.453384]  driver_probe_device+0xe1/0x150
[   13.453388]  device_driver_attach+0xa1/0xb0
[   13.453393]  __driver_attach+0x8a/0x150
[   13.453396]  ? device_driver_attach+0xb0/0xb0
[   13.453399]  ? device_driver_attach+0xb0/0xb0
[   13.453403]  bus_for_each_dev+0x78/0xc0
[   13.453407]  bus_add_driver+0x12b/0x1e0
[   13.453410]  driver_register+0x8b/0xe0
[   13.453414]  ? 0xffffffffc12b3000
[   13.453417]  init_tis+0xa0/0x1000 [tpm_tis]
[   13.453423]  do_one_initcall+0x44/0x1d0
[   13.453429]  ? do_init_module+0x23/0x260
[   13.453433]  ? kmem_cache_alloc_trace+0xf5/0x200
[   13.453439]  do_init_module+0x5c/0x260
[   13.453442]  __do_sys_finit_module+0xb1/0x110
[   13.453447]  do_syscall_64+0x33/0x80
[   13.453456]  entry_SYSCALL_64_after_hwframe+0x44/0xa9
[   13.453461] RIP: 0033:0x7f47ee07b9b9
[   13.453464] Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 
48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 
05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d a7 54 0c 00 f7 d8 64 89 01 48
[   13.453467] RSP: 002b:00007ffecedfb208 EFLAGS: 00000246 ORIG_RAX: 
0000000000000139
[   13.453471] RAX: ffffffffffffffda RBX: 0000562823d17b60 RCX: 
00007f47ee07b9b9
[   13.453473] RDX: 0000000000000000 RSI: 00007f47ee206e2d RDI: 
0000000000000012
[   13.453475] RBP: 0000000000020000 R08: 0000000000000000 R09: 
0000562823b53fc0
[   13.453477] R10: 0000000000000012 R11: 0000000000000246 R12: 
00007f47ee206e2d
[   13.453479] R13: 0000000000000000 R14: 0000562823d0c9b0 R15: 
0000562823d17b60
[   13.453483] ---[ end trace af2bc5f390f96ecd ]---
[   13.459546] tpm_tis 00:06: 1.2 TPM (device-id 0x6871, rev-id 1)

But the chip seems to be working event if it's in lockdown again do to 
the dual boot with windows(?)

Re: TPM returned invalid status

[Jarkko Sakkinen]

On Sun, Feb 07, 2021 at 07:33:54PM -0800, James Bottomley wrote:
> On Sat, 2021-02-06 at 00:31 +0100, Laurent Bigonville wrote:
> > Hello,
> > 
> > I already posted that beginning of January in reply to "tpm_tis:
> > Clean 
> > up locality release", but I didn't really got a reply
> > 
> > With debian unstable (Linux fornost 5.10.0-3-amd64 #1 SMP Debian 
> > 5.10.12-1 (2021-01-30) x86_64 GNU/Linux), I get the following error:
> 
> Sorry, forgot to cc you.  We're iterating to this as the fix:
> 
> https://lore.kernel.org/linux-integrity/20201001180925.13808-5-James.Bottomley@HansenPartnership.com/
> 
> If you want to test it out.
> 
> Thanks,
> 
> James


Not true.

1/5 and 2/5 have been already applied.

I'm still waiting one remaining fix from Lukasz. That's why I have not sent
any PR's to Linus.

/Jarkko

Re: TPM returned invalid status

[Jarkko Sakkinen]

On Mon, Feb 08, 2021 at 03:47:57PM +0100, Laurent Bigonville wrote:
> Le 8/02/21 à 04:33, James Bottomley a écrit :
> > On Sat, 2021-02-06 at 00:31 +0100, Laurent Bigonville wrote:
> > > Hello,
> > > 
> > > I already posted that beginning of January in reply to "tpm_tis:
> > > Clean
> > > up locality release", but I didn't really got a reply
> > > 
> > > With debian unstable (Linux fornost 5.10.0-3-amd64 #1 SMP Debian
> > > 5.10.12-1 (2021-01-30) x86_64 GNU/Linux), I get the following error:
> > Sorry, forgot to cc you.  We're iterating to this as the fix:
> > 
> > https://lore.kernel.org/linux-integrity/20201001180925.13808-5-James.Bottomley@HansenPartnership.com/
> > 
> > If you want to test it out.
> 
> I recompiled 5.11.0-rc7+ with the patch and I still get the same trace

Yeah, still pending the fix for probe.

The whole thread is here:

https://lore.kernel.org/linux-integrity/20210123014247.989368-1-lma@semihalf.com/

/Jarkko

Re: TPM returned invalid status

[James Bottomley]

On Fri, 2021-02-12 at 12:44 +0200, Jarkko Sakkinen wrote:
> On Sun, Feb 07, 2021 at 07:33:54PM -0800, James Bottomley wrote:
> > On Sat, 2021-02-06 at 00:31 +0100, Laurent Bigonville wrote:
> > > Hello,
> > > 
> > > I already posted that beginning of January in reply to "tpm_tis:
> > > Clean up locality release", but I didn't really got a reply
> > > 
> > > With debian unstable (Linux fornost 5.10.0-3-amd64 #1 SMP Debian 
> > > 5.10.12-1 (2021-01-30) x86_64 GNU/Linux), I get the following
> > > error:
> > 
> > Sorry, forgot to cc you.  We're iterating to this as the fix:
> > 
> > https://lore.kernel.org/linux-integrity/20201001180925.13808-5-James.Bottomley@HansenPartnership.com/
> > 
> > If you want to test it out.
> > 
> > Thanks,
> > 
> > James
> 
> Not true.
> 
> 1/5 and 2/5 have been already applied.
> 
> I'm still waiting one remaining fix from Lukasz. That's why I have
> not sent any PR's to Linus.

Perhaps you could point Laurent at the patch you think he could try
then because I think the backtrace indicates a potentially new problem.

James

Re: TPM returned invalid status

[Jarkko Sakkinen]

On Sat, Feb 13, 2021 at 10:32:01AM -0800, James Bottomley wrote:
> On Fri, 2021-02-12 at 12:44 +0200, Jarkko Sakkinen wrote:
> > On Sun, Feb 07, 2021 at 07:33:54PM -0800, James Bottomley wrote:
> > > On Sat, 2021-02-06 at 00:31 +0100, Laurent Bigonville wrote:
> > > > Hello,
> > > > 
> > > > I already posted that beginning of January in reply to "tpm_tis:
> > > > Clean up locality release", but I didn't really got a reply
> > > > 
> > > > With debian unstable (Linux fornost 5.10.0-3-amd64 #1 SMP Debian 
> > > > 5.10.12-1 (2021-01-30) x86_64 GNU/Linux), I get the following
> > > > error:
> > > 
> > > Sorry, forgot to cc you.  We're iterating to this as the fix:
> > > 
> > > https://lore.kernel.org/linux-integrity/20201001180925.13808-5-James.Bottomley@HansenPartnership.com/
> > > 
> > > If you want to test it out.
> > > 
> > > Thanks,
> > > 
> > > James
> > 
> > Not true.
> > 
> > 1/5 and 2/5 have been already applied.
> > 
> > I'm still waiting one remaining fix from Lukasz. That's why I have
> > not sent any PR's to Linus.
> 
> Perhaps you could point Laurent at the patch you think he could try
> then because I think the backtrace indicates a potentially new problem.

Sure, that'd be good idea:

https://patchwork.kernel.org/project/linux-integrity/patch/20210212110600.19216-1-lma@semihalf.com/

Can you try this out?

/Jarkko

Re: TPM returned invalid status

[Jarkko Sakkinen]

On Tue, Feb 16, 2021 at 09:33:20AM +0200, Jarkko Sakkinen wrote:
> On Sat, Feb 13, 2021 at 10:32:01AM -0800, James Bottomley wrote:
> > On Fri, 2021-02-12 at 12:44 +0200, Jarkko Sakkinen wrote:
> > > On Sun, Feb 07, 2021 at 07:33:54PM -0800, James Bottomley wrote:
> > > > On Sat, 2021-02-06 at 00:31 +0100, Laurent Bigonville wrote:
> > > > > Hello,
> > > > > 
> > > > > I already posted that beginning of January in reply to "tpm_tis:
> > > > > Clean up locality release", but I didn't really got a reply
> > > > > 
> > > > > With debian unstable (Linux fornost 5.10.0-3-amd64 #1 SMP Debian 
> > > > > 5.10.12-1 (2021-01-30) x86_64 GNU/Linux), I get the following
> > > > > error:
> > > > 
> > > > Sorry, forgot to cc you.  We're iterating to this as the fix:
> > > > 
> > > > https://lore.kernel.org/linux-integrity/20201001180925.13808-5-James.Bottomley@HansenPartnership.com/
> > > > 
> > > > If you want to test it out.
> > > > 
> > > > Thanks,
> > > > 
> > > > James
> > > 
> > > Not true.
> > > 
> > > 1/5 and 2/5 have been already applied.
> > > 
> > > I'm still waiting one remaining fix from Lukasz. That's why I have
> > > not sent any PR's to Linus.
> > 
> > Perhaps you could point Laurent at the patch you think he could try
> > then because I think the backtrace indicates a potentially new problem.
> 
> Sure, that'd be good idea:
> 
> https://patchwork.kernel.org/project/linux-integrity/patch/20210212110600.19216-1-lma@semihalf.com/
> 
> Can you try this out?

I wrote a patch based on v5 (just sent). Does not show up yet in patchwork,
so can not link it here.

/Jarkko