All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>, Jeff Dike <jdike@addtoit.com>,
	Richard Weinberger <richard@nod.at>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Jason Wessel <jason.wessel@windriver.com>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Douglas Anderson <dianders@chromium.org>,
	Pavel Tatashin <pasha.tatashin@soleen.com>,
	Christophe Leroy <christophe.leroy@c-s.fr>,
	Jordan Niethe <jniethe5@gmail.com>,
	Alistair Popple <alistair@popple.id.au>,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Mike Rapoport <rppt@kernel.org>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Thomas Meyer <thomas@m3y3r.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Oleg Nesterov <oleg@redhat.com>, Wei Li <liwei391@huawei.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Michael Kelley <mikelley@microsoft.com>,
	linuxppc-dev@lists.ozlabs.org, linux-um@lists.infradead.org,
	linux-hyperv@vger.kernel.org, linux-mtd@lists.infradead.org,
	kgdb-bugreport@lists.sourceforge.net
Subject: Re: [PATCH next v4 12/15] printk: introduce a kmsg_dump iterator
Date: Wed, 3 Mar 2021 14:48:33 +0100	[thread overview]
Message-ID: <YD+TsR+yiM2RB9Hh@alley> (raw)
In-Reply-To: <20210303101528.29901-13-john.ogness@linutronix.de>

On Wed 2021-03-03 11:15:25, John Ogness wrote:
> Rather than storing the iterator information in the registered
> kmsg_dumper structure, create a separate iterator structure. The
> kmsg_dump_iter structure can reside on the stack of the caller, thus
> allowing lockless use of the kmsg_dump functions.
> 
> Update code that accesses the kernel logs using the kmsg_dumper
> structure to use the new kmsg_dump_iter structure. For kmsg_dumpers,
> this also means adding a call to kmsg_dump_rewind() to initialize
> the iterator.
> 
> All this is in preparation for removal of @logbuf_lock.
> 
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
> Reviewed-by: Kees Cook <keescook@chromium.org> # pstore

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

WARNING: multiple messages have this Message-ID (diff)
From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: linux-hyperv@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Douglas Anderson <dianders@chromium.org>,
	Paul Mackerras <paulus@samba.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Thomas Meyer <thomas@m3y3r.de>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Wei Liu <wei.liu@kernel.org>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Anton Vorontsov <anton@enomsg.org>,
	Jason Wessel <jason.wessel@windriver.com>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Wei Li <liwei391@huawei.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	Kees Cook <keescook@chromium.org>,
	Alistair Popple <alistair@popple.id.au>,
	Jeff Dike <jdike@addtoit.com>, Colin Cross <ccross@android.com>,
	linux-um@lists.infradead.org,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Nicholas Piggin <npiggin@gmail.com>,
	Oleg Nesterov <oleg@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Jordan Niethe <jniethe5@gmail.com>,
	Michael Kelley <mikelley@microsoft.com>,
	Christophe Leroy <christophe.leroy@c-s.fr>,
	Tony Luck <tony.luck@intel.com>,
	Pavel Tatashin <pasha.tatashin@soleen.com>,
	linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	kgdb-bugreport@lists.sourceforge.net,
	linux-mtd@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
	Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH next v4 12/15] printk: introduce a kmsg_dump iterator
Date: Wed, 3 Mar 2021 14:48:33 +0100	[thread overview]
Message-ID: <YD+TsR+yiM2RB9Hh@alley> (raw)
In-Reply-To: <20210303101528.29901-13-john.ogness@linutronix.de>

On Wed 2021-03-03 11:15:25, John Ogness wrote:
> Rather than storing the iterator information in the registered
> kmsg_dumper structure, create a separate iterator structure. The
> kmsg_dump_iter structure can reside on the stack of the caller, thus
> allowing lockless use of the kmsg_dump functions.
> 
> Update code that accesses the kernel logs using the kmsg_dumper
> structure to use the new kmsg_dump_iter structure. For kmsg_dumpers,
> this also means adding a call to kmsg_dump_rewind() to initialize
> the iterator.
> 
> All this is in preparation for removal of @logbuf_lock.
> 
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
> Reviewed-by: Kees Cook <keescook@chromium.org> # pstore

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

WARNING: multiple messages have this Message-ID (diff)
From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>, Jeff Dike <jdike@addtoit.com>,
	Richard Weinberger <richard@nod.at>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Kees Cook <keescook@chromium.org>,
	Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Jason Wessel <jason.wessel@windriver.com>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Douglas Anderson <dianders@chromium.org>,
	Pavel Tatashin <pasha.tatashin@soleen.com>,
	Christophe Leroy <christophe.leroy@c-s.fr>,
	Jordan Niethe <jniethe5@gmail.com>,
	Alistair Popple <alistair@popple.id.au>,
	Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Mike Rapoport <rppt@kernel.org>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Thomas Meyer <thomas@m3y3r.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Oleg Nesterov <oleg@redhat.com>, Wei Li <liwei391@huawei.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Michael Kelley <mikelley@microsoft.com>,
	linuxppc-dev@lists.ozlabs.org, linux-um@lists.infradead.org,
	linux-hyperv@vger.kernel.org, linux-mtd@lists.infradead.org,
	kgdb-bugreport@lists.sourceforge.net
Subject: Re: [PATCH next v4 12/15] printk: introduce a kmsg_dump iterator
Date: Wed, 3 Mar 2021 14:48:33 +0100	[thread overview]
Message-ID: <YD+TsR+yiM2RB9Hh@alley> (raw)
In-Reply-To: <20210303101528.29901-13-john.ogness@linutronix.de>

On Wed 2021-03-03 11:15:25, John Ogness wrote:
> Rather than storing the iterator information in the registered
> kmsg_dumper structure, create a separate iterator structure. The
> kmsg_dump_iter structure can reside on the stack of the caller, thus
> allowing lockless use of the kmsg_dump functions.
> 
> Update code that accesses the kernel logs using the kmsg_dumper
> structure to use the new kmsg_dump_iter structure. For kmsg_dumpers,
> this also means adding a call to kmsg_dump_rewind() to initialize
> the iterator.
> 
> All this is in preparation for removal of @logbuf_lock.
> 
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
> Reviewed-by: Kees Cook <keescook@chromium.org> # pstore

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2021-03-03 18:11 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 10:15 [PATCH next v4 00/15] printk: remove logbuf_lock John Ogness
2021-03-03 10:15 ` John Ogness
2021-03-03 10:15 ` John Ogness
2021-03-03 10:15 ` [PATCH next v4 01/15] um: synchronize kmsg_dumper John Ogness
2021-03-03 10:15   ` John Ogness
2021-03-03 10:15 ` [PATCH next v4 02/15] mtd: mtdoops: " John Ogness
2021-03-03 10:15   ` John Ogness
2021-03-11  9:50   ` Miquel Raynal
2021-03-11  9:50     ` Miquel Raynal
2021-03-03 10:15 ` [PATCH next v4 03/15] printk: limit second loop of syslog_print_all John Ogness
2021-03-03 10:15 ` [PATCH next v4 04/15] printk: kmsg_dump: remove unused fields John Ogness
2021-03-03 10:15 ` [PATCH next v4 05/15] printk: refactor kmsg_dump_get_buffer() John Ogness
2021-03-03 10:15 ` [PATCH next v4 06/15] printk: consolidate kmsg_dump_get_buffer/syslog_print_all code John Ogness
2021-03-03 10:15 ` [PATCH next v4 07/15] printk: introduce CONSOLE_LOG_MAX John Ogness
2021-03-03 13:35   ` Petr Mladek
2021-03-03 10:15 ` [PATCH next v4 08/15] printk: use seqcount_latch for clear_seq John Ogness
2021-03-03 10:15 ` [PATCH next v4 09/15] printk: use atomic64_t for devkmsg_user.seq John Ogness
2021-03-03 10:15 ` [PATCH next v4 10/15] printk: add syslog_lock John Ogness
2021-03-03 10:15 ` [PATCH next v4 11/15] printk: kmsg_dumper: remove @active field John Ogness
2021-03-03 10:15   ` John Ogness
2021-03-03 10:15 ` [PATCH next v4 12/15] printk: introduce a kmsg_dump iterator John Ogness
2021-03-03 10:15   ` John Ogness
2021-03-03 10:15   ` John Ogness
2021-03-03 13:48   ` Petr Mladek [this message]
2021-03-03 13:48     ` Petr Mladek
2021-03-03 13:48     ` Petr Mladek
2021-03-03 10:15 ` [PATCH next v4 13/15] printk: remove logbuf_lock John Ogness
2021-03-03 10:15 ` [PATCH next v4 14/15] printk: kmsg_dump: remove _nolock() variants John Ogness
2021-03-03 10:15   ` John Ogness
2021-03-03 10:15 ` [PATCH next v4 15/15] printk: console: remove unnecessary safe buffer usage John Ogness
2021-03-03 13:18 ` lkml delivery: was: Re: [PATCH next v4 00/15] printk: remove logbuf_lock Petr Mladek
2021-03-03 13:18   ` Petr Mladek
2021-03-03 13:18   ` Petr Mladek
2021-03-03 14:34   ` Steven Rostedt
2021-03-03 14:34     ` Steven Rostedt
2021-03-03 14:34     ` Steven Rostedt
2021-03-03 15:34 ` Petr Mladek
2021-03-03 15:34   ` Petr Mladek
2021-03-03 15:34   ` Petr Mladek
2021-03-08 15:09   ` Petr Mladek
2021-03-08 15:09     ` Petr Mladek
2021-03-08 15:09     ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YD+TsR+yiM2RB9Hh@alley \
    --to=pmladek@suse.com \
    --cc=alistair@popple.id.au \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=anton@enomsg.org \
    --cc=benh@kernel.crashing.org \
    --cc=ccross@android.com \
    --cc=christophe.leroy@c-s.fr \
    --cc=daniel.thompson@linaro.org \
    --cc=dave@stgolabs.net \
    --cc=dianders@chromium.org \
    --cc=haiyangz@microsoft.com \
    --cc=jason.wessel@windriver.com \
    --cc=jdike@addtoit.com \
    --cc=jniethe5@gmail.com \
    --cc=john.ogness@linutronix.de \
    --cc=keescook@chromium.org \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-um@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=liwei391@huawei.com \
    --cc=maddy@linux.ibm.com \
    --cc=mikelley@microsoft.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=oleg@redhat.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=paulus@samba.org \
    --cc=ravi.bangoria@linux.ibm.com \
    --cc=richard@nod.at \
    --cc=rostedt@goodmis.org \
    --cc=rppt@kernel.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=sthemmin@microsoft.com \
    --cc=tglx@linutronix.de \
    --cc=thomas@m3y3r.de \
    --cc=tony.luck@intel.com \
    --cc=vigneshr@ti.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.