All of lore.kernel.org
 help / color / mirror / Atom feed
* rcar_du_kms.c:781:24: error: passing argument 1 of '__drmm_add_action' from incompatible pointer type
@ 2021-03-01 17:41 ` Naresh Kamboju
  0 siblings, 0 replies; 8+ messages in thread
From: Naresh Kamboju @ 2021-03-01 17:41 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Sasha Levin
  Cc: linux-stable, lkft-triage, Laurent Pinchart, Jacopo Mondi,
	Linux-Renesas, dri-devel, Daniel Vetter, David Airlie,
	kieran.bingham+renesas

On stable rc 5.11 the x86_64 build failed due to below errors/warnings.

drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_cleanup':
drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: error: implicit
declaration of function 'to_rcar_du_device'; did you mean
'to_rtc_device'? [-Werror=implicit-function-declaration]
  struct rcar_du_device *rcdu = to_rcar_du_device(dev);
                                ^~~~~~~~~~~~~~~~~
                                to_rtc_device
drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: warning: initialization
makes pointer from integer without a cast [-Wint-conversion]
In file included from drivers/gpu/drm/rcar-du/rcar_du_kms.c:17:0:
drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_init':
drivers/gpu/drm/rcar-du/rcar_du_kms.c:781:24: error: passing argument
1 of '__drmm_add_action' from incompatible pointer type
[-Werror=incompatible-pointer-types]
  ret = drmm_add_action(&rcdu->ddev, rcar_du_modeset_cleanup, NULL);
                        ^
include/drm/drm_managed.h:25:20: note: in definition of macro 'drmm_add_action'
  __drmm_add_action(dev, action, data, #action)
                    ^~~
include/drm/drm_managed.h:27:18: note: expected 'struct drm_device *'
but argument is of type 'struct drm_device **'
 int __must_check __drmm_add_action(struct drm_device *dev,
                  ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>

Build link,
https://ci.linaro.org/job/openembedded-lkft-linux-stable-rc-5.11/DISTRO=lkft,MACHINE=ls2088ardb,label=docker-buster-lkft/8/consoleText

-- 
Linaro LKFT
https://lkft.linaro.org

^ permalink raw reply	[flat|nested] 8+ messages in thread

* rcar_du_kms.c:781:24: error: passing argument 1 of '__drmm_add_action' from incompatible pointer type
@ 2021-03-01 17:41 ` Naresh Kamboju
  0 siblings, 0 replies; 8+ messages in thread
From: Naresh Kamboju @ 2021-03-01 17:41 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Sasha Levin
  Cc: Laurent Pinchart, David Airlie, dri-devel, Linux-Renesas,
	kieran.bingham+renesas, Jacopo Mondi, lkft-triage, linux-stable

On stable rc 5.11 the x86_64 build failed due to below errors/warnings.

drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_cleanup':
drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: error: implicit
declaration of function 'to_rcar_du_device'; did you mean
'to_rtc_device'? [-Werror=implicit-function-declaration]
  struct rcar_du_device *rcdu = to_rcar_du_device(dev);
                                ^~~~~~~~~~~~~~~~~
                                to_rtc_device
drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: warning: initialization
makes pointer from integer without a cast [-Wint-conversion]
In file included from drivers/gpu/drm/rcar-du/rcar_du_kms.c:17:0:
drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_init':
drivers/gpu/drm/rcar-du/rcar_du_kms.c:781:24: error: passing argument
1 of '__drmm_add_action' from incompatible pointer type
[-Werror=incompatible-pointer-types]
  ret = drmm_add_action(&rcdu->ddev, rcar_du_modeset_cleanup, NULL);
                        ^
include/drm/drm_managed.h:25:20: note: in definition of macro 'drmm_add_action'
  __drmm_add_action(dev, action, data, #action)
                    ^~~
include/drm/drm_managed.h:27:18: note: expected 'struct drm_device *'
but argument is of type 'struct drm_device **'
 int __must_check __drmm_add_action(struct drm_device *dev,
                  ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>

Build link,
https://ci.linaro.org/job/openembedded-lkft-linux-stable-rc-5.11/DISTRO=lkft,MACHINE=ls2088ardb,label=docker-buster-lkft/8/consoleText

-- 
Linaro LKFT
https://lkft.linaro.org
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: rcar_du_kms.c:781:24: error: passing argument 1 of '__drmm_add_action' from incompatible pointer type
  2021-03-01 17:41 ` Naresh Kamboju
@ 2021-03-01 17:47   ` Naresh Kamboju
  -1 siblings, 0 replies; 8+ messages in thread
From: Naresh Kamboju @ 2021-03-01 17:47 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Sasha Levin
  Cc: linux-stable, lkft-triage, Laurent Pinchart, Jacopo Mondi,
	Linux-Renesas, dri-devel, Daniel Vetter, David Airlie,
	kieran.bingham+renesas

On Mon, 1 Mar 2021 at 23:11, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> On stable rc 5.11 the x86_64 build failed due to below errors/warnings.

These build failures were also noticed on stable rc 5.10 for arm64,
arm, x86_64, and i386 architectures.

>
> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_cleanup':
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: error: implicit
> declaration of function 'to_rcar_du_device'; did you mean
> 'to_rtc_device'? [-Werror=implicit-function-declaration]
>   struct rcar_du_device *rcdu = to_rcar_du_device(dev);
>                                 ^~~~~~~~~~~~~~~~~
>                                 to_rtc_device
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: warning: initialization
> makes pointer from integer without a cast [-Wint-conversion]
> In file included from drivers/gpu/drm/rcar-du/rcar_du_kms.c:17:0:
> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_init':
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:781:24: error: passing argument
> 1 of '__drmm_add_action' from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>   ret = drmm_add_action(&rcdu->ddev, rcar_du_modeset_cleanup, NULL);
>                         ^
> include/drm/drm_managed.h:25:20: note: in definition of macro 'drmm_add_action'
>   __drmm_add_action(dev, action, data, #action)
>                     ^~~
> include/drm/drm_managed.h:27:18: note: expected 'struct drm_device *'
> but argument is of type 'struct drm_device **'
>  int __must_check __drmm_add_action(struct drm_device *dev,
>                   ^~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>
> Build link,
> https://ci.linaro.org/job/openembedded-lkft-linux-stable-rc-5.11/DISTRO=lkft,MACHINE=ls2088ardb,label=docker-buster-lkft/8/consoleText
>
> --
> Linaro LKFT
> https://lkft.linaro.org

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: rcar_du_kms.c:781:24: error: passing argument 1 of '__drmm_add_action' from incompatible pointer type
@ 2021-03-01 17:47   ` Naresh Kamboju
  0 siblings, 0 replies; 8+ messages in thread
From: Naresh Kamboju @ 2021-03-01 17:47 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Sasha Levin
  Cc: Laurent Pinchart, David Airlie, dri-devel, Linux-Renesas,
	kieran.bingham+renesas, Jacopo Mondi, lkft-triage, linux-stable

On Mon, 1 Mar 2021 at 23:11, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> On stable rc 5.11 the x86_64 build failed due to below errors/warnings.

These build failures were also noticed on stable rc 5.10 for arm64,
arm, x86_64, and i386 architectures.

>
> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_cleanup':
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: error: implicit
> declaration of function 'to_rcar_du_device'; did you mean
> 'to_rtc_device'? [-Werror=implicit-function-declaration]
>   struct rcar_du_device *rcdu = to_rcar_du_device(dev);
>                                 ^~~~~~~~~~~~~~~~~
>                                 to_rtc_device
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: warning: initialization
> makes pointer from integer without a cast [-Wint-conversion]
> In file included from drivers/gpu/drm/rcar-du/rcar_du_kms.c:17:0:
> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_init':
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:781:24: error: passing argument
> 1 of '__drmm_add_action' from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>   ret = drmm_add_action(&rcdu->ddev, rcar_du_modeset_cleanup, NULL);
>                         ^
> include/drm/drm_managed.h:25:20: note: in definition of macro 'drmm_add_action'
>   __drmm_add_action(dev, action, data, #action)
>                     ^~~
> include/drm/drm_managed.h:27:18: note: expected 'struct drm_device *'
> but argument is of type 'struct drm_device **'
>  int __must_check __drmm_add_action(struct drm_device *dev,
>                   ^~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>
> Build link,
> https://ci.linaro.org/job/openembedded-lkft-linux-stable-rc-5.11/DISTRO=lkft,MACHINE=ls2088ardb,label=docker-buster-lkft/8/consoleText
>
> --
> Linaro LKFT
> https://lkft.linaro.org
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: rcar_du_kms.c:781:24: error: passing argument 1 of '__drmm_add_action' from incompatible pointer type
  2021-03-01 17:41 ` Naresh Kamboju
@ 2021-03-01 18:52   ` Greg Kroah-Hartman
  -1 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2021-03-01 18:52 UTC (permalink / raw)
  To: Naresh Kamboju
  Cc: Sasha Levin, linux-stable, lkft-triage, Laurent Pinchart,
	Jacopo Mondi, Linux-Renesas, dri-devel, Daniel Vetter,
	David Airlie, kieran.bingham+renesas

On Mon, Mar 01, 2021 at 11:11:26PM +0530, Naresh Kamboju wrote:
> On stable rc 5.11 the x86_64 build failed due to below errors/warnings.
> 
> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_cleanup':
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: error: implicit
> declaration of function 'to_rcar_du_device'; did you mean
> 'to_rtc_device'? [-Werror=implicit-function-declaration]
>   struct rcar_du_device *rcdu = to_rcar_du_device(dev);
>                                 ^~~~~~~~~~~~~~~~~
>                                 to_rtc_device
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: warning: initialization
> makes pointer from integer without a cast [-Wint-conversion]
> In file included from drivers/gpu/drm/rcar-du/rcar_du_kms.c:17:0:
> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_init':
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:781:24: error: passing argument
> 1 of '__drmm_add_action' from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>   ret = drmm_add_action(&rcdu->ddev, rcar_du_modeset_cleanup, NULL);
>                         ^
> include/drm/drm_managed.h:25:20: note: in definition of macro 'drmm_add_action'
>   __drmm_add_action(dev, action, data, #action)
>                     ^~~
> include/drm/drm_managed.h:27:18: note: expected 'struct drm_device *'
> but argument is of type 'struct drm_device **'
>  int __must_check __drmm_add_action(struct drm_device *dev,
>                   ^~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>

Very odd, my builds here didn't trigger that, sorry.  I'll go drop the
offending patch...

greg k-h

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: rcar_du_kms.c:781:24: error: passing argument 1 of '__drmm_add_action' from incompatible pointer type
@ 2021-03-01 18:52   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 8+ messages in thread
From: Greg Kroah-Hartman @ 2021-03-01 18:52 UTC (permalink / raw)
  To: Naresh Kamboju
  Cc: Sasha Levin, Laurent Pinchart, David Airlie, dri-devel,
	lkft-triage, Linux-Renesas, kieran.bingham+renesas, Jacopo Mondi,
	linux-stable

On Mon, Mar 01, 2021 at 11:11:26PM +0530, Naresh Kamboju wrote:
> On stable rc 5.11 the x86_64 build failed due to below errors/warnings.
> 
> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_cleanup':
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: error: implicit
> declaration of function 'to_rcar_du_device'; did you mean
> 'to_rtc_device'? [-Werror=implicit-function-declaration]
>   struct rcar_du_device *rcdu = to_rcar_du_device(dev);
>                                 ^~~~~~~~~~~~~~~~~
>                                 to_rtc_device
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: warning: initialization
> makes pointer from integer without a cast [-Wint-conversion]
> In file included from drivers/gpu/drm/rcar-du/rcar_du_kms.c:17:0:
> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_init':
> drivers/gpu/drm/rcar-du/rcar_du_kms.c:781:24: error: passing argument
> 1 of '__drmm_add_action' from incompatible pointer type
> [-Werror=incompatible-pointer-types]
>   ret = drmm_add_action(&rcdu->ddev, rcar_du_modeset_cleanup, NULL);
>                         ^
> include/drm/drm_managed.h:25:20: note: in definition of macro 'drmm_add_action'
>   __drmm_add_action(dev, action, data, #action)
>                     ^~~
> include/drm/drm_managed.h:27:18: note: expected 'struct drm_device *'
> but argument is of type 'struct drm_device **'
>  int __must_check __drmm_add_action(struct drm_device *dev,
>                   ^~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>

Very odd, my builds here didn't trigger that, sorry.  I'll go drop the
offending patch...

greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: rcar_du_kms.c:781:24: error: passing argument 1 of '__drmm_add_action' from incompatible pointer type
  2021-03-01 18:52   ` Greg Kroah-Hartman
@ 2021-03-01 19:59     ` Kieran Bingham
  -1 siblings, 0 replies; 8+ messages in thread
From: Kieran Bingham @ 2021-03-01 19:59 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Naresh Kamboju, Laurent Pinchart
  Cc: Sasha Levin, linux-stable, lkft-triage, Jacopo Mondi,
	Linux-Renesas, dri-devel, Daniel Vetter, David Airlie

On 01/03/2021 18:52, Greg Kroah-Hartman wrote:
> On Mon, Mar 01, 2021 at 11:11:26PM +0530, Naresh Kamboju wrote:
>> On stable rc 5.11 the x86_64 build failed due to below errors/warnings.
>>
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_cleanup':
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: error: implicit
>> declaration of function 'to_rcar_du_device'; did you mean
>> 'to_rtc_device'? [-Werror=implicit-function-declaration]
>>   struct rcar_du_device *rcdu = to_rcar_du_device(dev);
>>                                 ^~~~~~~~~~~~~~~~~
>>                                 to_rtc_device
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: warning: initialization
>> makes pointer from integer without a cast [-Wint-conversion]
>> In file included from drivers/gpu/drm/rcar-du/rcar_du_kms.c:17:0:
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_init':
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c:781:24: error: passing argument
>> 1 of '__drmm_add_action' from incompatible pointer type
>> [-Werror=incompatible-pointer-types]
>>   ret = drmm_add_action(&rcdu->ddev, rcar_du_modeset_cleanup, NULL);
>>                         ^
>> include/drm/drm_managed.h:25:20: note: in definition of macro 'drmm_add_action'
>>   __drmm_add_action(dev, action, data, #action)
>>                     ^~~
>> include/drm/drm_managed.h:27:18: note: expected 'struct drm_device *'
>> but argument is of type 'struct drm_device **'
>>  int __must_check __drmm_add_action(struct drm_device *dev,
>>                   ^~~~~~~~~~~~~~~~~
>> cc1: some warnings being treated as errors
>>
>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> 
> Very odd, my builds here didn't trigger that, sorry.  I'll go drop the
> offending patch...

Hrm, I believe this should have been fixed by:

https://lore.kernel.org/dri-devel/20210113170253.443820-1-kieran.bingham+renesas@ideasonboard.com/

But it doesn't seem to have made it upstream yet.

I've pinged the patch today, but that won't help stable trees until it
lands.
--
Kieran

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: rcar_du_kms.c:781:24: error: passing argument 1 of '__drmm_add_action' from incompatible pointer type
@ 2021-03-01 19:59     ` Kieran Bingham
  0 siblings, 0 replies; 8+ messages in thread
From: Kieran Bingham @ 2021-03-01 19:59 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Naresh Kamboju, Laurent Pinchart
  Cc: Sasha Levin, David Airlie, dri-devel, Linux-Renesas,
	Jacopo Mondi, lkft-triage, linux-stable

On 01/03/2021 18:52, Greg Kroah-Hartman wrote:
> On Mon, Mar 01, 2021 at 11:11:26PM +0530, Naresh Kamboju wrote:
>> On stable rc 5.11 the x86_64 build failed due to below errors/warnings.
>>
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_cleanup':
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: error: implicit
>> declaration of function 'to_rcar_du_device'; did you mean
>> 'to_rtc_device'? [-Werror=implicit-function-declaration]
>>   struct rcar_du_device *rcdu = to_rcar_du_device(dev);
>>                                 ^~~~~~~~~~~~~~~~~
>>                                 to_rtc_device
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c:754:32: warning: initialization
>> makes pointer from integer without a cast [-Wint-conversion]
>> In file included from drivers/gpu/drm/rcar-du/rcar_du_kms.c:17:0:
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c: In function 'rcar_du_modeset_init':
>> drivers/gpu/drm/rcar-du/rcar_du_kms.c:781:24: error: passing argument
>> 1 of '__drmm_add_action' from incompatible pointer type
>> [-Werror=incompatible-pointer-types]
>>   ret = drmm_add_action(&rcdu->ddev, rcar_du_modeset_cleanup, NULL);
>>                         ^
>> include/drm/drm_managed.h:25:20: note: in definition of macro 'drmm_add_action'
>>   __drmm_add_action(dev, action, data, #action)
>>                     ^~~
>> include/drm/drm_managed.h:27:18: note: expected 'struct drm_device *'
>> but argument is of type 'struct drm_device **'
>>  int __must_check __drmm_add_action(struct drm_device *dev,
>>                   ^~~~~~~~~~~~~~~~~
>> cc1: some warnings being treated as errors
>>
>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> 
> Very odd, my builds here didn't trigger that, sorry.  I'll go drop the
> offending patch...

Hrm, I believe this should have been fixed by:

https://lore.kernel.org/dri-devel/20210113170253.443820-1-kieran.bingham+renesas@ideasonboard.com/

But it doesn't seem to have made it upstream yet.

I've pinged the patch today, but that won't help stable trees until it
lands.
--
Kieran
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-03-01 20:41 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 17:41 rcar_du_kms.c:781:24: error: passing argument 1 of '__drmm_add_action' from incompatible pointer type Naresh Kamboju
2021-03-01 17:41 ` Naresh Kamboju
2021-03-01 17:47 ` Naresh Kamboju
2021-03-01 17:47   ` Naresh Kamboju
2021-03-01 18:52 ` Greg Kroah-Hartman
2021-03-01 18:52   ` Greg Kroah-Hartman
2021-03-01 19:59   ` Kieran Bingham
2021-03-01 19:59     ` Kieran Bingham

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.