All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: mpm@selenic.com, herbert@gondor.apana.org.au,
	nsaenzjulienne@suse.de, f.fainelli@gmail.com, rjui@broadcom.com,
	sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
	rikard.falkeborn@gmail.com, linux-crypto@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, stijn@linux-ipv6.be, ynezz@true.cz
Subject: Re: [PATCH] hwrng: bcm2835: set quality to 1000
Date: Sat, 20 Feb 2021 20:09:30 +0100	[thread overview]
Message-ID: <YDFeao/bOxvoXI9D@lunn.ch> (raw)
In-Reply-To: <20210220174741.23665-1-noltari@gmail.com>

On Sat, Feb 20, 2021 at 06:47:40PM +0100, Álvaro Fernández Rojas wrote:
> This allows devices without a high precission timer to reduce boot from >100s
> to <30s.
> diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c
> index 1a7c43b43c6b..4b48cb7176b0 100644
> --- a/drivers/char/hw_random/bcm2835-rng.c
> +++ b/drivers/char/hw_random/bcm2835-rng.c
> @@ -163,6 +163,7 @@ static int bcm2835_rng_probe(struct platform_device *pdev)
>  	priv->rng.init = bcm2835_rng_init;
>  	priv->rng.read = bcm2835_rng_read;
>  	priv->rng.cleanup = bcm2835_rng_cleanup;
> +	priv->rng.quality = 1000;

Hi Alvero

 * @quality:		Estimation of true entropy in RNG's bitstream
 *			(in bits of entropy per 1024 bits of input;
 *			valid values: 1 to 1024, or 0 for unknown).

How did you determine this device produces 1000 bits of true entropy
per 1024?

    Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, stijn@linux-ipv6.be,
	f.fainelli@gmail.com, herbert@gondor.apana.org.au,
	sbranden@broadcom.com, rjui@broadcom.com,
	linux-kernel@vger.kernel.org, rikard.falkeborn@gmail.com,
	bcm-kernel-feedback-list@broadcom.com,
	linux-crypto@vger.kernel.org, mpm@selenic.com, ynezz@true.cz,
	nsaenzjulienne@suse.de, linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] hwrng: bcm2835: set quality to 1000
Date: Sat, 20 Feb 2021 20:09:30 +0100	[thread overview]
Message-ID: <YDFeao/bOxvoXI9D@lunn.ch> (raw)
In-Reply-To: <20210220174741.23665-1-noltari@gmail.com>

On Sat, Feb 20, 2021 at 06:47:40PM +0100, Álvaro Fernández Rojas wrote:
> This allows devices without a high precission timer to reduce boot from >100s
> to <30s.
> diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c
> index 1a7c43b43c6b..4b48cb7176b0 100644
> --- a/drivers/char/hw_random/bcm2835-rng.c
> +++ b/drivers/char/hw_random/bcm2835-rng.c
> @@ -163,6 +163,7 @@ static int bcm2835_rng_probe(struct platform_device *pdev)
>  	priv->rng.init = bcm2835_rng_init;
>  	priv->rng.read = bcm2835_rng_read;
>  	priv->rng.cleanup = bcm2835_rng_cleanup;
> +	priv->rng.quality = 1000;

Hi Alvero

 * @quality:		Estimation of true entropy in RNG's bitstream
 *			(in bits of entropy per 1024 bits of input;
 *			valid values: 1 to 1024, or 0 for unknown).

How did you determine this device produces 1000 bits of true entropy
per 1024?

    Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-20 19:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-20 17:47 [PATCH] hwrng: bcm2835: set quality to 1000 Álvaro Fernández Rojas
2021-02-20 17:47 ` Álvaro Fernández Rojas
2021-02-20 19:09 ` Andrew Lunn [this message]
2021-02-20 19:09   ` Andrew Lunn
2021-02-20 19:12   ` Álvaro Fernández Rojas
2021-02-20 19:12     ` Álvaro Fernández Rojas
2021-02-20 19:40     ` Andrew Lunn
2021-02-20 19:40       ` Andrew Lunn
2021-03-03  9:20     ` Herbert Xu
2021-03-03  9:20       ` Herbert Xu
2021-03-03  9:29       ` Álvaro Fernández Rojas
2021-03-03  9:29         ` Álvaro Fernández Rojas
2021-03-04 15:11         ` Nicolas Saenz Julienne
2021-03-04 15:11           ` Nicolas Saenz Julienne
2021-03-04 22:28           ` Florian Fainelli
2021-03-04 22:28             ` Florian Fainelli
2021-03-05  6:26             ` Álvaro Fernández Rojas
2021-03-05  6:26               ` Álvaro Fernández Rojas
2021-03-12  4:52               ` Florian Fainelli
2021-03-12  4:52                 ` Florian Fainelli
2021-02-20 19:57 ` [PATCH v2] " Álvaro Fernández Rojas
2021-02-20 19:57   ` Álvaro Fernández Rojas
2021-02-22 19:50   ` [PATCH v3] hwrng: bcm2835: set quality Álvaro Fernández Rojas
2021-02-22 19:50     ` Álvaro Fernández Rojas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDFeao/bOxvoXI9D@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=mpm@selenic.com \
    --cc=noltari@gmail.com \
    --cc=nsaenzjulienne@suse.de \
    --cc=rikard.falkeborn@gmail.com \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=stijn@linux-ipv6.be \
    --cc=ynezz@true.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.