All of lore.kernel.org
 help / color / mirror / Atom feed
From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	David Jander <david@protonic.nl>,
	Robin van der Gracht <robin@protonic.nl>,
	linux-iio@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v6 0/2] add support for GPIO or IRQ based evemt counter
Date: Mon, 22 Feb 2021 10:48:56 +0900	[thread overview]
Message-ID: <YDMNiBjnJKanhTUH@shinobu> (raw)
In-Reply-To: <20210216081356.3577-1-o.rempel@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1974 bytes --]

On Tue, Feb 16, 2021 at 09:13:54AM +0100, Oleksij Rempel wrote:
> changes v6:
> - rename it to interrupt-counter

Hi Oleksij,

Sorry to nitpick again, I think "irq-counter" as Jonathan suggested in
an earlier review would be a better name afterall. Would you be able to
rename this driver to use that name instead?

Sincerely,

William Breathitt Gray

> - driver fixes
> - device tree fixes
> 
> changes v5:
> - rename it to event counter, since it support different event sources
> - make it work with gpio-only or irq-only configuration
> - update yaml binding
> 
> changes v4:
> - use IRQ_NOAUTOEN to not enable IRQ by default
> - rename gpio_ from name pattern and make this driver work any IRQ
>   source.
> 
> changes v3:
> - convert counter to atomic_t
> 
> changes v2:
> - add commas
> - avoid possible unhandled interrupts in the enable path
> - do not use of_ specific gpio functions
> 
> Add support for GPIO based pulse counter. For now it can only count
> pulses. With counter char device support, we will be able to attach
> timestamps and measure actual pulse frequency.
> 
> Never the less, it is better to mainline this driver now (before chardev
> patches go mainline), to provide developers additional use case for the counter
> framework with chardev support.
> 
> Oleksij Rempel (2):
>   dt-bindings: counter: add event-counter binding
>   counter: add IRQ or GPIO based event counter
> 
>  .../bindings/counter/interrupt-counter.yaml   |  62 +++++
>  MAINTAINERS                                   |   7 +
>  drivers/counter/Kconfig                       |  10 +
>  drivers/counter/Makefile                      |   1 +
>  drivers/counter/interrupt-cnt.c               | 249 ++++++++++++++++++
>  5 files changed, 329 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/counter/interrupt-counter.yaml
>  create mode 100644 drivers/counter/interrupt-cnt.c
> 
> -- 
> 2.29.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2021-02-22  1:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16  8:13 [PATCH v6 0/2] add support for GPIO or IRQ based evemt counter Oleksij Rempel
2021-02-16  8:13 ` [PATCH v6 1/2] dt-bindings: counter: add event-counter binding Oleksij Rempel
2021-03-05 21:53   ` Rob Herring
2021-02-16  8:13 ` [PATCH v6 2/2] counter: add IRQ or GPIO based event counter Oleksij Rempel
2021-02-21 15:41   ` Jonathan Cameron
2021-02-22  1:48 ` William Breathitt Gray [this message]
2021-02-23  7:16   ` [PATCH v6 0/2] add support for GPIO or IRQ based evemt counter Oleksij Rempel
2021-02-23  8:14     ` William Breathitt Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDMNiBjnJKanhTUH@shinobu \
    --to=vilhelm.gray@gmail.com \
    --cc=david@protonic.nl \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=robin@protonic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.