* [PATCH 2/5] zbd: simplify zoneskip= validness check
@ 2021-02-22 13:21 Alexey Dobriyan
0 siblings, 0 replies; only message in thread
From: Alexey Dobriyan @ 2021-02-22 13:21 UTC (permalink / raw)
To: axboe; +Cc: fio, dmitry.fomichev
Simply check the remainder:
(zoneskip % zone_size) > 0
It will do the right thing for all zoneskip= values, and
zone size being positive is checked earlier.
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>
---
zbd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/zbd.c
+++ b/zbd.c
@@ -285,9 +285,7 @@ static bool zbd_verify_sizes(void)
return false;
}
- if (td->o.zone_skip &&
- (td->o.zone_skip < td->o.zone_size ||
- td->o.zone_skip % td->o.zone_size)) {
+ if (td->o.zone_skip % td->o.zone_size) {
log_err("%s: zoneskip %llu is not a multiple of the device zone size %llu.\n",
f->file_name, (unsigned long long) td->o.zone_skip,
(unsigned long long) td->o.zone_size);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-02-22 13:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-22 13:21 [PATCH 2/5] zbd: simplify zoneskip= validness check Alexey Dobriyan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.