From: Petr Vorel <pvorel@suse.cz> To: Amir Goldstein <amir73il@gmail.com> Cc: Luis Henriques <lhenriques@suse.de>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, LTP List <ltp@lists.linux.it> Subject: Re: [PATCH v4] vfs: fix copy_file_range regression in cross-fs copies Date: Wed, 24 Feb 2021 09:30:03 +0100 [thread overview] Message-ID: <YDYOi5QTuas+ScAZ@pevik> (raw) In-Reply-To: <CAOQ4uxjtap0jQat19h7g+6xvpMnqrwEihgN7pw11d57kkRVsaw@mail.gmail.com> Hi Amir, > On Thu, Feb 18, 2021 at 4:35 PM Luis Henriques <lhenriques@suse.de> wrote: > > A regression has been reported by Nicolas Boichat, found while using the > > copy_file_range syscall to copy a tracefs file. Before commit > > 5dae222a5ff0 ("vfs: allow copy_file_range to copy across devices") the > > kernel would return -EXDEV to userspace when trying to copy a file across > > different filesystems. After this commit, the syscall doesn't fail anymore > > and instead returns zero (zero bytes copied), as this file's content is > > generated on-the-fly and thus reports a size of zero. > > This patch restores some cross-filesystem copy restrictions that existed > > prior to commit 5dae222a5ff0 ("vfs: allow copy_file_range to copy across > > devices"). Filesystems are still allowed to fall-back to the VFS > > generic_copy_file_range() implementation, but that has now to be done > > explicitly. > Petr, > Please note that the check for verify_cross_fs_copy_support() in LTP > tests can no longer be used to determine if copy_file_range() is post v5.3. > You will need to fix the tests to expect cross-fs failures (this change of > behavior is supposed to be backported to stable kernels as well). > I guess the copy_file_range() tests will need to use min_kver. Thanks for info! I see, after "vfs: fix copy_file_range regression in cross-fs copies" and backported to 5.4.x, 5.10.x and 5.11.x we'll probably have to replace verify_cross_fs_copy_support() with .min_kver = "5.3". We have also tst_kvercmp2() in case original 5dae222a5ff0 ("vfs: allow copy_file_range to copy across devices") was backported to any enterprise distro (and then this fix would follow). Kind regards, Petr > Thanks, > Amir.
WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz> To: ltp@lists.linux.it Subject: [LTP] [PATCH v4] vfs: fix copy_file_range regression in cross-fs copies Date: Wed, 24 Feb 2021 09:30:03 +0100 [thread overview] Message-ID: <YDYOi5QTuas+ScAZ@pevik> (raw) In-Reply-To: <CAOQ4uxjtap0jQat19h7g+6xvpMnqrwEihgN7pw11d57kkRVsaw@mail.gmail.com> Hi Amir, > On Thu, Feb 18, 2021 at 4:35 PM Luis Henriques <lhenriques@suse.de> wrote: > > A regression has been reported by Nicolas Boichat, found while using the > > copy_file_range syscall to copy a tracefs file. Before commit > > 5dae222a5ff0 ("vfs: allow copy_file_range to copy across devices") the > > kernel would return -EXDEV to userspace when trying to copy a file across > > different filesystems. After this commit, the syscall doesn't fail anymore > > and instead returns zero (zero bytes copied), as this file's content is > > generated on-the-fly and thus reports a size of zero. > > This patch restores some cross-filesystem copy restrictions that existed > > prior to commit 5dae222a5ff0 ("vfs: allow copy_file_range to copy across > > devices"). Filesystems are still allowed to fall-back to the VFS > > generic_copy_file_range() implementation, but that has now to be done > > explicitly. > Petr, > Please note that the check for verify_cross_fs_copy_support() in LTP > tests can no longer be used to determine if copy_file_range() is post v5.3. > You will need to fix the tests to expect cross-fs failures (this change of > behavior is supposed to be backported to stable kernels as well). > I guess the copy_file_range() tests will need to use min_kver. Thanks for info! I see, after "vfs: fix copy_file_range regression in cross-fs copies" and backported to 5.4.x, 5.10.x and 5.11.x we'll probably have to replace verify_cross_fs_copy_support() with .min_kver = "5.3". We have also tst_kvercmp2() in case original 5dae222a5ff0 ("vfs: allow copy_file_range to copy across devices") was backported to any enterprise distro (and then this fix would follow). Kind regards, Petr > Thanks, > Amir.
next prev parent reply other threads:[~2021-02-24 8:31 UTC|newest] Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-12 4:43 [PATCH 0/6] Add generated flag to filesystem struct to block copy_file_range Nicolas Boichat 2021-02-12 4:44 ` [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated Nicolas Boichat 2021-02-12 7:46 ` Greg KH 2021-02-12 8:20 ` Nicolas Boichat 2021-02-12 8:37 ` Greg KH 2021-02-12 15:33 ` Ian Lance Taylor 2021-02-12 15:45 ` Greg KH 2021-02-12 15:59 ` Ian Lance Taylor 2021-02-12 16:28 ` Greg KH 2021-02-12 20:22 ` Ian Lance Taylor 2021-02-12 23:03 ` Dave Chinner 2021-02-12 23:07 ` Ian Lance Taylor 2021-02-12 23:27 ` Dave Chinner 2021-02-12 23:54 ` Darrick J. Wong 2021-02-15 0:38 ` Dave Chinner 2021-02-15 1:12 ` Ian Lance Taylor 2021-02-15 1:25 ` Nicolas Boichat 2021-02-15 5:56 ` Amir Goldstein 2021-02-15 8:30 ` Greg KH 2021-02-12 8:22 ` Amir Goldstein 2021-02-12 8:39 ` Greg KH 2021-02-12 12:05 ` Luis Henriques 2021-02-12 12:18 ` Greg KH 2021-02-12 12:41 ` Luis Henriques 2021-02-12 14:11 ` Greg KH 2021-02-12 15:01 ` Luis Henriques 2021-02-15 6:12 ` Amir Goldstein 2021-02-15 10:39 ` Luis Henriques 2021-02-15 12:22 ` Luis Henriques 2021-02-15 14:23 ` Amir Goldstein 2021-02-15 14:51 ` Luis Henriques 2021-02-15 15:43 ` [PATCH v2] vfs: prevent copy_file_range to copy across devices Luis Henriques 2021-02-15 16:02 ` Trond Myklebust 2021-02-16 0:25 ` Steve French 2021-02-15 16:34 ` Amir Goldstein 2021-02-15 16:53 ` Trond Myklebust 2021-02-15 17:24 ` Amir Goldstein 2021-02-15 18:57 ` Trond Myklebust 2021-02-15 19:43 ` Amir Goldstein 2021-02-16 11:17 ` Luis Henriques 2021-02-16 11:28 ` gregkh 2021-02-16 12:01 ` Luis Henriques 2021-02-16 12:08 ` Greg KH 2021-02-16 13:51 ` Amir Goldstein 2021-02-16 16:42 ` Luis Henriques 2021-02-16 17:44 ` Amir Goldstein 2021-02-16 18:55 ` Luis Henriques 2021-02-16 19:20 ` Amir Goldstein 2021-02-16 19:27 ` Anna Schumaker 2021-02-16 19:31 ` Steve French 2021-02-16 19:40 ` Amir Goldstein 2021-02-16 21:15 ` Steve French 2021-02-17 8:08 ` Amir Goldstein 2021-02-17 17:26 ` [PATCH v3] vfs: fix copy_file_range regression in cross-fs copies Luis Henriques 2021-02-17 20:47 ` Amir Goldstein 2021-02-18 0:56 ` Nicolas Boichat 2021-02-18 5:32 ` Olga Kornievskaia 2021-02-18 6:47 ` Amir Goldstein 2021-02-18 16:28 ` Olga Kornievskaia 2021-02-18 7:43 ` Christoph Hellwig 2021-02-18 0:50 ` [PATCH v2] vfs: prevent copy_file_range to copy across devices Andreas Dilger 2021-02-18 7:34 ` gregkh 2021-02-16 18:54 ` Andreas Dilger 2021-02-17 4:45 ` Nicolas Boichat 2021-02-18 7:42 ` Christoph Hellwig 2021-02-18 9:10 ` Amir Goldstein 2021-02-18 10:29 ` Luis Henriques 2021-02-18 12:15 ` Luis Henriques 2021-02-18 12:49 ` Amir Goldstein 2021-02-18 14:36 ` [PATCH v4] vfs: fix copy_file_range regression in cross-fs copies Luis Henriques 2021-02-18 14:58 ` Amir Goldstein 2021-02-18 15:17 ` [PATCH v5] " Luis Henriques 2021-02-18 15:53 ` Amir Goldstein 2021-02-18 16:35 ` Luis Henriques 2021-02-18 17:18 ` [PATCH v6] " Luis Henriques 2021-02-19 21:18 ` Olga Kornievskaia 2021-02-19 21:52 ` Amir Goldstein 2021-02-21 19:58 ` [PATCH v7] " Luis Henriques 2021-02-22 3:00 ` Nicolas Boichat 2021-02-22 10:24 ` [PATCH v8] " Luis Henriques 2021-02-22 10:46 ` Amir Goldstein 2021-02-22 16:25 ` dai.ngo 2021-02-23 10:32 ` Luis Henriques 2021-02-23 15:28 ` Amir Goldstein 2021-02-23 15:29 ` dai.ngo 2021-02-23 16:02 ` dai.ngo 2021-02-23 16:47 ` Amir Goldstein 2021-02-23 16:57 ` dai.ngo [not found] ` <e3eed18b-fc7e-e687-608b-7f662017329c@oracle.com> 2021-02-23 17:33 ` Amir Goldstein 2021-02-24 0:13 ` dai.ngo 2021-02-23 17:56 ` Luis Henriques 2021-02-23 17:13 ` Olga Kornievskaia 2021-02-24 1:00 ` Olga Kornievskaia 2021-02-24 10:23 ` Luis Henriques 2021-02-24 10:44 ` Nicolas Boichat 2021-04-09 5:23 ` Nicolas Boichat 2021-04-09 13:39 ` Luis Henriques 2021-04-09 13:50 ` Amir Goldstein 2021-04-23 4:40 ` Nicolas Boichat 2021-05-03 8:54 ` Luis Henriques 2021-05-10 4:59 ` Amir Goldstein 2021-05-10 9:10 ` Luis Henriques 2021-02-24 5:25 ` [vfs] cb07c976be: ltp.copy_file_range01.fail kernel test robot 2021-02-24 5:25 ` kernel test robot 2021-02-24 5:25 ` [LTP] " kernel test robot 2021-02-24 14:23 ` [PATCH] copy_file_range.2: Kernel v5.12 updates Luis Henriques 2021-02-24 16:10 ` Amir Goldstein 2021-02-25 10:21 ` Luis Henriques 2021-02-25 15:29 ` AW: " Walter Harms 2021-02-26 10:13 ` Alejandro Colomar (man-pages) 2021-02-26 10:34 ` Amir Goldstein 2021-02-26 11:15 ` Alejandro Colomar (man-pages) 2021-02-26 13:59 ` Jeff Layton 2021-02-26 21:26 ` Alejandro Colomar (man-pages) 2021-02-26 22:18 ` Alejandro Colomar (man-pages) 2021-02-27 5:41 ` Amir Goldstein 2021-02-27 12:20 ` Alejandro Colomar (man-pages) 2021-02-27 13:49 ` [RFC v2] copy_file_range.2: Update cross-filesystem support for 5.12 Alejandro Colomar 2021-02-27 16:00 ` Amir Goldstein 2021-02-27 23:08 ` [PATCH] copy_file_range.2: Kernel v5.12 updates Steve French 2021-02-28 7:35 ` Amir Goldstein 2021-02-28 22:25 ` Steve French 2021-03-01 6:18 ` Amir Goldstein 2021-03-01 14:41 ` [RFC v3] copy_file_range.2: Update cross-filesystem support for 5.12 Alejandro Colomar 2021-03-01 14:58 ` Amir Goldstein 2021-03-04 9:38 ` [RFC v4] " Alejandro Colomar 2021-03-04 17:13 ` Darrick J. Wong 2021-03-04 18:24 ` Alejandro Colomar (man-pages) 2021-03-04 23:50 ` Darrick J. Wong 2021-02-24 7:15 ` [PATCH v4] vfs: fix copy_file_range regression in cross-fs copies Amir Goldstein 2021-02-24 7:15 ` [LTP] " Amir Goldstein 2021-02-24 8:30 ` Petr Vorel [this message] 2021-02-24 8:30 ` Petr Vorel 2021-02-18 20:41 ` [PATCH v2] vfs: prevent copy_file_range to copy across devices Steve French 2021-02-12 23:15 ` [PATCH 1/6] fs: Add flag to file_system_type to indicate content is generated Dave Chinner 2021-02-12 7:54 ` Amir Goldstein 2021-02-12 4:44 ` [PATCH 2/6] proc: Add FS_GENERATED_CONTENT to filesystem flags Nicolas Boichat 2021-02-12 4:44 ` [PATCH 3/6] sysfs: " Nicolas Boichat 2021-02-12 4:44 ` [PATCH 4/6] debugfs: " Nicolas Boichat 2021-02-12 4:44 ` [PATCH 5/6] tracefs: " Nicolas Boichat 2021-02-12 14:47 ` Steven Rostedt 2021-02-12 4:44 ` [PATCH 6/6] vfs: Disallow copy_file_range on generated file systems Nicolas Boichat 2021-02-12 4:53 ` Darrick J. Wong 2021-02-12 4:59 ` Darrick J. Wong 2021-02-12 5:24 ` Nicolas Boichat 2021-02-14 23:09 ` [PATCH 0/6] Add generated flag to filesystem struct to block copy_file_range Al Viro
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YDYOi5QTuas+ScAZ@pevik \ --to=pvorel@suse.cz \ --cc=amir73il@gmail.com \ --cc=lhenriques@suse.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=ltp@lists.linux.it \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.