All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Yogesh Lal <ylal@codeaurora.org>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, pkondeti@codeaurora.org,
	neeraju@codeaurora.org
Subject: Re: [PATCH] driver core: Use unbound workqueue for deferred probes
Date: Thu, 25 Feb 2021 12:44:43 +0100	[thread overview]
Message-ID: <YDeNq+mBXDlHUlG4@kroah.com> (raw)
In-Reply-To: <a40db2a2-f58a-aaec-6976-977d4b9f9e0e@codeaurora.org>

On Thu, Feb 25, 2021 at 04:03:50PM +0530, Yogesh Lal wrote:
> Hi Greg,
> 
> 
> On 2/24/2021 6:13 PM, Greg KH wrote:
> > On Wed, Feb 24, 2021 at 05:25:49PM +0530, Yogesh Lal wrote:
> > > Queue deferred driver probes on unbounded workqueue, to allow
> > > scheduler better manage scheduling of long running probes.
> > 
> > Really?  What does this change and help?  What is the visable affect of
> > this patch?  What problem does it solve?
> > 
> 
> We observed boot up improvement (~400 msec) when the deferred probe work is
> made unbound. This is due to scheduler moving the worker running deferred
> probe work to big CPUs. without this change, we see the worker is running on
> LITTLE CPU due to affinity.

Why is none of this information in the changelog text?  How are we
supposed to know this?  And is this 400msec out of 10 seconds or
something else?  Also, this sounds like your "little" cpus are really
bad, you might want to look into fixing them first :)

But if you really want to make this go faster, do not deferr your probe!
Why not fix that problem in your drivers instead?

> Please let us now if there are any concerns/restrictions that deferred probe
> work should run only on pinned kworkers. Since this work runs deferred probe
> of several devices , the locality may not be that important

Can you prove that it is not important?  I know lots of gyrations are
done in some busses to keep probe happening on the same CPU for very
good reasons.  Changing that should not be done lightly as you will
break this.

thanks,

greg k-h

  reply	other threads:[~2021-02-25 11:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24 11:55 [PATCH] driver core: Use unbound workqueue for deferred probes Yogesh Lal
2021-02-24 12:43 ` Greg KH
2021-02-25 10:33   ` Yogesh Lal
2021-02-25 11:44     ` Greg KH [this message]
2021-03-15 10:45       ` Yogesh Lal
2021-03-23  9:50         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDeNq+mBXDlHUlG4@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neeraju@codeaurora.org \
    --cc=pkondeti@codeaurora.org \
    --cc=rafael@kernel.org \
    --cc=ylal@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.