From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Doug Anderson <dianders@chromium.org> Cc: Andrzej Hajda <a.hajda@samsung.com>, Neil Armstrong <narmstrong@baylibre.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@siol.net>, Sam Ravnborg <sam@ravnborg.org>, Stephen Boyd <swboyd@chromium.org>, linux-arm-msm@vger.kernel.org, robdclark@chromium.org, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] drm/bridge: ti-sn65dsi86: Move code in prep for EDID read fix Date: Mon, 15 Mar 2021 18:41:31 +0200 [thread overview] Message-ID: <YE+OO0m8iW8oS3cq@pendragon.ideasonboard.com> (raw) In-Reply-To: <CAD=FV=X_HAdNkvZ7NGKDH9KapRRLgOfN23OZyy3VyaX+ywjRkQ@mail.gmail.com> Hi Doug, On Mon, Mar 15, 2021 at 09:31:41AM -0700, Doug Anderson wrote: > On Sat, Mar 13, 2021 at 1:13 PM Laurent Pinchart wrote: > > On Thu, Mar 04, 2021 at 03:52:00PM -0800, Douglas Anderson wrote: > > > This patch is _only_ code motion to prepare for the patch > > > ("drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if > > > refclk") and make it easier to understand. > > > > s/make/makes/ > > I was never an expert at grammar, but I think either "make" or "makes" > are fine. Simple version with parenthesis: > > Mine: > > This patch is <blah> to (prepare for the patch <blah>) and (make it > easier to understand). > > Yours: > > This patch is <blah> (to prepare for the patch <blah>) and (makes it > easier to understand). > > I suppose also valid would be: > > This patch is <blah> (to prepare for the patch <blah>) and (to make it > easier to understand). Your absolutely right. Both versions are fine, and your preferred version is best :-) > In any case if/when I spin this patch I'm fine changing it to your > version just because (as I understand) it's equally valid and maybe > looks slightly better? > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Thanks for the reviews! -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Doug Anderson <dianders@chromium.org> Cc: robdclark@chromium.org, Jernej Skrabec <jernej.skrabec@siol.net>, Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>, linux-arm-msm@vger.kernel.org, Neil Armstrong <narmstrong@baylibre.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd <swboyd@chromium.org>, Andrzej Hajda <a.hajda@samsung.com>, Sam Ravnborg <sam@ravnborg.org> Subject: Re: [PATCH 2/3] drm/bridge: ti-sn65dsi86: Move code in prep for EDID read fix Date: Mon, 15 Mar 2021 18:41:31 +0200 [thread overview] Message-ID: <YE+OO0m8iW8oS3cq@pendragon.ideasonboard.com> (raw) In-Reply-To: <CAD=FV=X_HAdNkvZ7NGKDH9KapRRLgOfN23OZyy3VyaX+ywjRkQ@mail.gmail.com> Hi Doug, On Mon, Mar 15, 2021 at 09:31:41AM -0700, Doug Anderson wrote: > On Sat, Mar 13, 2021 at 1:13 PM Laurent Pinchart wrote: > > On Thu, Mar 04, 2021 at 03:52:00PM -0800, Douglas Anderson wrote: > > > This patch is _only_ code motion to prepare for the patch > > > ("drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if > > > refclk") and make it easier to understand. > > > > s/make/makes/ > > I was never an expert at grammar, but I think either "make" or "makes" > are fine. Simple version with parenthesis: > > Mine: > > This patch is <blah> to (prepare for the patch <blah>) and (make it > easier to understand). > > Yours: > > This patch is <blah> (to prepare for the patch <blah>) and (makes it > easier to understand). > > I suppose also valid would be: > > This patch is <blah> (to prepare for the patch <blah>) and (to make it > easier to understand). Your absolutely right. Both versions are fine, and your preferred version is best :-) > In any case if/when I spin this patch I'm fine changing it to your > version just because (as I understand) it's equally valid and maybe > looks slightly better? > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Thanks for the reviews! -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-03-15 16:42 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-04 23:51 [PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify refclk handling Douglas Anderson 2021-03-04 23:51 ` Douglas Anderson 2021-03-04 23:52 ` [PATCH 2/3] drm/bridge: ti-sn65dsi86: Move code in prep for EDID read fix Douglas Anderson 2021-03-04 23:52 ` Douglas Anderson 2021-03-05 10:07 ` Robert Foss 2021-03-05 10:07 ` Robert Foss 2021-03-12 2:50 ` Bjorn Andersson 2021-03-12 2:50 ` Bjorn Andersson 2021-03-13 20:25 ` Stephen Boyd 2021-03-13 20:25 ` Stephen Boyd 2021-03-13 21:12 ` Laurent Pinchart 2021-03-13 21:12 ` Laurent Pinchart 2021-03-15 16:31 ` Doug Anderson 2021-03-15 16:31 ` Doug Anderson 2021-03-15 16:41 ` Laurent Pinchart [this message] 2021-03-15 16:41 ` Laurent Pinchart 2021-03-04 23:52 ` [PATCH 3/3] drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if refclk Douglas Anderson 2021-03-04 23:52 ` Douglas Anderson 2021-03-12 2:59 ` Bjorn Andersson 2021-03-12 2:59 ` Bjorn Andersson 2021-03-13 21:16 ` Laurent Pinchart 2021-03-13 21:16 ` Laurent Pinchart 2021-03-15 16:25 ` Doug Anderson 2021-03-15 16:25 ` Doug Anderson 2021-03-16 21:46 ` Laurent Pinchart 2021-03-16 21:46 ` Laurent Pinchart 2021-03-17 0:44 ` Doug Anderson 2021-03-17 0:44 ` Doug Anderson 2021-03-30 2:57 ` Doug Anderson 2021-03-30 2:57 ` Doug Anderson 2021-03-30 3:19 ` Laurent Pinchart 2021-03-30 3:19 ` Laurent Pinchart 2021-03-05 10:00 ` [PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify refclk handling Robert Foss 2021-03-05 10:00 ` Robert Foss 2021-03-12 2:49 ` Bjorn Andersson 2021-03-12 2:49 ` Bjorn Andersson 2021-03-13 20:23 ` Stephen Boyd 2021-03-13 20:23 ` Stephen Boyd 2021-03-13 21:02 ` Laurent Pinchart 2021-03-13 21:02 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YE+OO0m8iW8oS3cq@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dianders@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jernej.skrabec@siol.net \ --cc=jonas@kwiboo.se \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=narmstrong@baylibre.com \ --cc=robdclark@chromium.org \ --cc=sam@ravnborg.org \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.