From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> To: Vivek Goyal <vgoyal@redhat.com> Cc: virtio-fs-list <virtio-fs@redhat.com>, qemu-devel@nongnu.org, eric.g.ernst@gmail.com Subject: Re: [PATCH] virtiofsd: Add qemu version and copyright info Date: Mon, 15 Mar 2021 15:04:19 +0000 [thread overview] Message-ID: <YE93cwGU75LPUx2N@work-vm> (raw) In-Reply-To: <20210303195339.GB3793@redhat.com> * Vivek Goyal (vgoyal@redhat.com) wrote: > Option "-V" currently displays the fuse protocol version virtiofsd is > using. For example, I see this. > > $ ./virtiofsd -V > "using FUSE kernel interface version 7.33" > > People also want to know software version of virtiofsd so that they can > figure out if a certain fix is part of currently running virtiofsd or > not. Eric Ernst ran into this issue. > > David Gilbert thinks that it probably is best that we simply carry the > qemu version and display that information given we are part of qemu > tree. > > So this patch enhances version information and also adds qemu version > and copyright info. Not sure if copyright information is supposed > to be displayed along with version info. Given qemu-storage-daemon > and other utilities are doing it, so I continued with same pattern. > This is how now output looks like. > > $ ./virtiofsd -V > virtiofsd version 5.2.50 (v5.2.0-2357-gcbcf09872a-dirty) > Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers > using FUSE kernel interface version 7.33 > > Reported-by: Eric Ernst <eric.g.ernst@gmail.com> > Signed-off-by: Vivek Goyal <vgoyal@redhat.com> Queued > --- > tools/virtiofsd/passthrough_ll.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > Index: rhvgoyal-qemu/tools/virtiofsd/passthrough_ll.c > =================================================================== > --- rhvgoyal-qemu.orig/tools/virtiofsd/passthrough_ll.c 2021-03-03 14:28:04.893672524 -0500 > +++ rhvgoyal-qemu/tools/virtiofsd/passthrough_ll.c 2021-03-03 14:37:29.381712706 -0500 > @@ -37,6 +37,8 @@ > > #include "qemu/osdep.h" > #include "qemu/timer.h" > +#include "qemu-version.h" > +#include "qemu-common.h" > #include "fuse_virtio.h" > #include "fuse_log.h" > #include "fuse_lowlevel.h" > @@ -3591,6 +3593,11 @@ static void fuse_lo_data_cleanup(struct > free(lo->source); > } > > +static void qemu_version(void) > +{ > + printf("virtiofsd version " QEMU_FULL_VERSION "\n" QEMU_COPYRIGHT "\n"); > +} > + > int main(int argc, char *argv[]) > { > struct fuse_args args = FUSE_ARGS_INIT(argc, argv); > @@ -3662,6 +3669,7 @@ int main(int argc, char *argv[]) > ret = 0; > goto err_out1; > } else if (opts.show_version) { > + qemu_version(); > fuse_lowlevel_version(); > ret = 0; > goto err_out1; > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com> To: Vivek Goyal <vgoyal@redhat.com> Cc: virtio-fs-list <virtio-fs@redhat.com>, qemu-devel@nongnu.org Subject: Re: [Virtio-fs] [PATCH] virtiofsd: Add qemu version and copyright info Date: Mon, 15 Mar 2021 15:04:19 +0000 [thread overview] Message-ID: <YE93cwGU75LPUx2N@work-vm> (raw) In-Reply-To: <20210303195339.GB3793@redhat.com> * Vivek Goyal (vgoyal@redhat.com) wrote: > Option "-V" currently displays the fuse protocol version virtiofsd is > using. For example, I see this. > > $ ./virtiofsd -V > "using FUSE kernel interface version 7.33" > > People also want to know software version of virtiofsd so that they can > figure out if a certain fix is part of currently running virtiofsd or > not. Eric Ernst ran into this issue. > > David Gilbert thinks that it probably is best that we simply carry the > qemu version and display that information given we are part of qemu > tree. > > So this patch enhances version information and also adds qemu version > and copyright info. Not sure if copyright information is supposed > to be displayed along with version info. Given qemu-storage-daemon > and other utilities are doing it, so I continued with same pattern. > This is how now output looks like. > > $ ./virtiofsd -V > virtiofsd version 5.2.50 (v5.2.0-2357-gcbcf09872a-dirty) > Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers > using FUSE kernel interface version 7.33 > > Reported-by: Eric Ernst <eric.g.ernst@gmail.com> > Signed-off-by: Vivek Goyal <vgoyal@redhat.com> Queued > --- > tools/virtiofsd/passthrough_ll.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > Index: rhvgoyal-qemu/tools/virtiofsd/passthrough_ll.c > =================================================================== > --- rhvgoyal-qemu.orig/tools/virtiofsd/passthrough_ll.c 2021-03-03 14:28:04.893672524 -0500 > +++ rhvgoyal-qemu/tools/virtiofsd/passthrough_ll.c 2021-03-03 14:37:29.381712706 -0500 > @@ -37,6 +37,8 @@ > > #include "qemu/osdep.h" > #include "qemu/timer.h" > +#include "qemu-version.h" > +#include "qemu-common.h" > #include "fuse_virtio.h" > #include "fuse_log.h" > #include "fuse_lowlevel.h" > @@ -3591,6 +3593,11 @@ static void fuse_lo_data_cleanup(struct > free(lo->source); > } > > +static void qemu_version(void) > +{ > + printf("virtiofsd version " QEMU_FULL_VERSION "\n" QEMU_COPYRIGHT "\n"); > +} > + > int main(int argc, char *argv[]) > { > struct fuse_args args = FUSE_ARGS_INIT(argc, argv); > @@ -3662,6 +3669,7 @@ int main(int argc, char *argv[]) > ret = 0; > goto err_out1; > } else if (opts.show_version) { > + qemu_version(); > fuse_lowlevel_version(); > ret = 0; > goto err_out1; > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-03-15 15:06 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-03 19:53 [PATCH] virtiofsd: Add qemu version and copyright info Vivek Goyal 2021-03-03 19:53 ` [Virtio-fs] " Vivek Goyal 2021-03-04 10:41 ` Dr. David Alan Gilbert 2021-03-04 10:41 ` [Virtio-fs] " Dr. David Alan Gilbert 2021-03-08 7:54 ` Sergio Lopez 2021-03-08 7:54 ` [Virtio-fs] " Sergio Lopez 2021-03-08 16:17 ` Stefan Hajnoczi 2021-03-15 15:04 ` Dr. David Alan Gilbert [this message] 2021-03-15 15:04 ` Dr. David Alan Gilbert
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YE93cwGU75LPUx2N@work-vm \ --to=dgilbert@redhat.com \ --cc=eric.g.ernst@gmail.com \ --cc=qemu-devel@nongnu.org \ --cc=vgoyal@redhat.com \ --cc=virtio-fs@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.