* [PATCH -next] usb: typec: stusb160x: fix return value check in stusb160x_probe()
@ 2021-03-08 9:48 'Wei Yongjun
2021-03-08 11:04 ` Heikki Krogerus
2021-03-08 12:41 ` Amelie DELAUNAY
0 siblings, 2 replies; 3+ messages in thread
From: 'Wei Yongjun @ 2021-03-08 9:48 UTC (permalink / raw)
To: weiyongjun1, Heikki Krogerus, Greg Kroah-Hartman, Liam Girdwood,
Mark Brown, Amelie Delaunay
Cc: linux-usb, kernel-janitors, Hulk Robot
From: Wei Yongjun <weiyongjun1@huawei.com>
In case of error, the function device_get_named_child_node() returns
NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.
Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/usb/typec/stusb160x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c
index d21750bbbb44..6eaeba9b096e 100644
--- a/drivers/usb/typec/stusb160x.c
+++ b/drivers/usb/typec/stusb160x.c
@@ -682,8 +682,8 @@ static int stusb160x_probe(struct i2c_client *client)
}
fwnode = device_get_named_child_node(chip->dev, "connector");
- if (IS_ERR(fwnode))
- return PTR_ERR(fwnode);
+ if (!fwnode)
+ return -ENODEV;
/*
* When both VDD and VSYS power supplies are present, the low power
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] usb: typec: stusb160x: fix return value check in stusb160x_probe()
2021-03-08 9:48 [PATCH -next] usb: typec: stusb160x: fix return value check in stusb160x_probe() 'Wei Yongjun
@ 2021-03-08 11:04 ` Heikki Krogerus
2021-03-08 12:41 ` Amelie DELAUNAY
1 sibling, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2021-03-08 11:04 UTC (permalink / raw)
To: 'Wei Yongjun
Cc: Greg Kroah-Hartman, Liam Girdwood, Mark Brown, Amelie Delaunay,
linux-usb, kernel-janitors, Hulk Robot
On Mon, Mar 08, 2021 at 09:48:39AM +0000, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> In case of error, the function device_get_named_child_node() returns
> NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
>
> Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/stusb160x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c
> index d21750bbbb44..6eaeba9b096e 100644
> --- a/drivers/usb/typec/stusb160x.c
> +++ b/drivers/usb/typec/stusb160x.c
> @@ -682,8 +682,8 @@ static int stusb160x_probe(struct i2c_client *client)
> }
>
> fwnode = device_get_named_child_node(chip->dev, "connector");
> - if (IS_ERR(fwnode))
> - return PTR_ERR(fwnode);
> + if (!fwnode)
> + return -ENODEV;
>
> /*
> * When both VDD and VSYS power supplies are present, the low power
thanks,
--
heikki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] usb: typec: stusb160x: fix return value check in stusb160x_probe()
2021-03-08 9:48 [PATCH -next] usb: typec: stusb160x: fix return value check in stusb160x_probe() 'Wei Yongjun
2021-03-08 11:04 ` Heikki Krogerus
@ 2021-03-08 12:41 ` Amelie DELAUNAY
1 sibling, 0 replies; 3+ messages in thread
From: Amelie DELAUNAY @ 2021-03-08 12:41 UTC (permalink / raw)
To: 'Wei Yongjun, Heikki Krogerus, Greg Kroah-Hartman,
Liam Girdwood, Mark Brown, Amelie Delaunay
Cc: linux-usb, kernel-janitors, Hulk Robot
On 3/8/21 10:48 AM, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> In case of error, the function device_get_named_child_node() returns
> NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
>
> Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks for the patch,
Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
> ---
> drivers/usb/typec/stusb160x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/stusb160x.c b/drivers/usb/typec/stusb160x.c
> index d21750bbbb44..6eaeba9b096e 100644
> --- a/drivers/usb/typec/stusb160x.c
> +++ b/drivers/usb/typec/stusb160x.c
> @@ -682,8 +682,8 @@ static int stusb160x_probe(struct i2c_client *client)
> }
>
> fwnode = device_get_named_child_node(chip->dev, "connector");
> - if (IS_ERR(fwnode))
> - return PTR_ERR(fwnode);
> + if (!fwnode)
> + return -ENODEV;
>
> /*
> * When both VDD and VSYS power supplies are present, the low power
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-08 12:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 9:48 [PATCH -next] usb: typec: stusb160x: fix return value check in stusb160x_probe() 'Wei Yongjun
2021-03-08 11:04 ` Heikki Krogerus
2021-03-08 12:41 ` Amelie DELAUNAY
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.