All of lore.kernel.org
 help / color / mirror / Atom feed
From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Arun Sharma <arun@sharma-home.net>
Cc: git@vger.kernel.org
Subject: Re: bug report: mutual recursion in the git-subtree shell script
Date: Sat, 13 Mar 2021 17:02:50 +0000	[thread overview]
Message-ID: <YEzwOqgFcva4fmoV@camp.crustytoothpaste.net> (raw)
In-Reply-To: <CAN7rbOve-EFOGPjr1wrD77r-3RQ+3+qso82_oV5Qud-skobL7w@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]

On 2021-03-13 at 16:06:18, Arun Sharma wrote:
> [ resending bug report from git-users since there weren't any responses ]
> 
> So I'm trying to split out a directory from postgres source code
> (which has 52k commits). I was able to split a directory into a
> separate subtree (with 1685 commits). All good so far.
> 
> Now I do a pull from upstream and want to push the directory to my
> subtree. The command fails with:
> 
> $ git subtree push --prefix=src/interfaces/libpq libpq master
> /usr/lib/git-core/git-subtree: 647: Maximum function recursion depth
> (1000) reached
> 
> As far as I can see, it seems to be a mutual recursion between
> 
> process_split_commit() and check_parents()
> 
> If this diagnosis is correct, are there any known workarounds? I've
> tried increasing ulimit -s and FUNCNEST=10000, but it didn't fix the
> problem.
> 
> Can this flow be coded without using recursion? Are there
> implementations of git-subtree in another language which doesn't have
> this problem?

I don't use git-subtree, but there's some additional information which
would probably be helpful here to someone who does.  What OS are you
using, what version of Git, and what shell is the shell you have as
/bin/sh (or, if you've compiled using a custom shell, the shell you're
using for that)?
-- 
brian m. carlson (he/him or they/them)
Houston, Texas, US

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2021-03-13 17:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-13 16:06 bug report: mutual recursion in the git-subtree shell script Arun Sharma
2021-03-13 17:02 ` brian m. carlson [this message]
2021-03-14 17:31   ` Arun Sharma
2021-03-15  5:19     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEzwOqgFcva4fmoV@camp.crustytoothpaste.net \
    --to=sandals@crustytoothpaste.net \
    --cc=arun@sharma-home.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.