From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/2] power: supply: axp20x_usb_power: fix work-queue init
Date: Fri, 26 Mar 2021 15:48:41 +0100 [thread overview]
Message-ID: <YF30Sf0Z8mSjA0s+@kroah.com> (raw)
In-Reply-To: <20210324102506.3ta2zstmrwq4wswb@earth.universe>
On Wed, Mar 24, 2021 at 11:25:06AM +0100, Sebastian Reichel wrote:
> Hi,
>
> On Wed, Mar 24, 2021 at 11:21:34AM +0200, Matti Vaittinen wrote:
> > The commit 6d0c5de2fd84
> > ("power: supply: Clean-up few drivers by using managed work init")
> > Re-introduced wrong order of initializing work-queue and requesting
> > the IRQs which was originally fixed by the commit b5e8642ed95f
> > ("power: supply: axp20x_usb_power: Init work before enabling IRQs")
> >
> > In addition this caused the work queue to be initialized twice.
> >
> > Fix it again.
> >
> > Fixes: 6d0c5de2fd84 ("power: supply: Clean-up few drivers by using managed work init")
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > Reported-by: Chen-Yu Tsai <wens@csie.org>
> > ---
>
> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>
> Needs to be merged by Greg, since I do not have 6d0c5de2fd84 in
> my tree.
Now merged, thanks.
greg k-h
prev parent reply other threads:[~2021-03-26 14:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 9:20 [PATCH 0/2] Fixes to device-managed work-queue series Matti Vaittinen
2021-03-24 9:21 ` [PATCH 1/2] extcon: extcon-gpio: Log error if work-queue init fails Matti Vaittinen
2021-03-24 9:25 ` Hans de Goede
2021-03-24 9:51 ` Vaittinen, Matti
2021-03-25 0:49 ` Chanwoo Choi
2021-03-25 4:52 ` Vaittinen, Matti
2021-03-25 14:01 ` gregkh
2021-03-24 9:21 ` [PATCH 2/2] power: supply: axp20x_usb_power: fix work-queue init Matti Vaittinen
2021-03-24 10:25 ` Sebastian Reichel
2021-03-26 14:48 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF30Sf0Z8mSjA0s+@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cw00.choi@samsung.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.