All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
	"Deucher, Alexander" <alexander.deucher@amd.com>,
	Christian Koenig <christian.koenig@amd.com>,
	Dave Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	Hawking Zhang <Hawking.Zhang@amd.com>,
	John Clements <John.Clements@amd.com>,
	"Chen, Guchun" <guchun.chen@amd.com>,
	Tao Zhou <tao.zhou1@amd.com>, Likun Gao <Likun.Gao@amd.com>,
	Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
	Jiansong Chen <Jiansong.Chen@amd.com>,
	Huang Rui <ray.huang@amd.com>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>,
	Maling list - DRI developers  <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: Fix a typo
Date: Fri, 19 Mar 2021 01:55:21 +0530	[thread overview]
Message-ID: <YFO3MYXwWbXwTgUh@Gentoo> (raw)
In-Reply-To: <CADnq5_OsrHGxmXeuEiV06qas7jJ0pvExqdrw-PmqpKvWi=0jOg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1741 bytes --]

On 14:12 Thu 18 Mar 2021, Alex Deucher wrote:
>On Thu, Mar 18, 2021 at 2:08 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> On 3/18/21 4:33 AM, Bhaskar Chowdhury wrote:
>> >
>> > s/traing/training/
>> >
>> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> > ---
>> >  drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
>> > index c325d6f53a71..db18e4f6cf5f 100644
>> > --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
>> > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
>> > @@ -661,7 +661,7 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
>> >
>> >       if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
>> >               /*
>> > -              * Long traing will encroach certain mount of bottom VRAM,
>> > +              * Long training will encroach certain mount of bottom VRAM,
>>
>>                                                        amount
>> I think.
>
>Yeah, I think it should read something like:
>
>Long training will encroach a certain amount on the bottom of VRAM;
>save the content from the bottom VRAM to system memory
>before training, and restore it after training to avoid
>VRAM corruption.
>
>Alex
>
>>
>> >                * saving the content of this bottom VRAM to system memory
>> >                * before training, and restoring it after training to avoid
>> >                * VRAM corruption.

Thanks.

>> > --
>> > 2.26.2
>> >
>>
>>
>> --
>> ~Randy
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Tao Zhou <tao.zhou1@amd.com>,
	"Chen, Guchun" <guchun.chen@amd.com>,
	Dave Airlie <airlied@linux.ie>,
	Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>,
	Huang Rui <ray.huang@amd.com>,
	Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
	Jiansong Chen <Jiansong.Chen@amd.com>,
	"Deucher, Alexander" <alexander.deucher@amd.com>,
	Likun Gao <Likun.Gao@amd.com>,
	John Clements <John.Clements@amd.com>,
	Christian Koenig <christian.koenig@amd.com>,
	Hawking Zhang <Hawking.Zhang@amd.com>
Subject: Re: [PATCH] drm/amdgpu: Fix a typo
Date: Fri, 19 Mar 2021 01:55:21 +0530	[thread overview]
Message-ID: <YFO3MYXwWbXwTgUh@Gentoo> (raw)
In-Reply-To: <CADnq5_OsrHGxmXeuEiV06qas7jJ0pvExqdrw-PmqpKvWi=0jOg@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1741 bytes --]

On 14:12 Thu 18 Mar 2021, Alex Deucher wrote:
>On Thu, Mar 18, 2021 at 2:08 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> On 3/18/21 4:33 AM, Bhaskar Chowdhury wrote:
>> >
>> > s/traing/training/
>> >
>> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> > ---
>> >  drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
>> > index c325d6f53a71..db18e4f6cf5f 100644
>> > --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
>> > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
>> > @@ -661,7 +661,7 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
>> >
>> >       if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
>> >               /*
>> > -              * Long traing will encroach certain mount of bottom VRAM,
>> > +              * Long training will encroach certain mount of bottom VRAM,
>>
>>                                                        amount
>> I think.
>
>Yeah, I think it should read something like:
>
>Long training will encroach a certain amount on the bottom of VRAM;
>save the content from the bottom VRAM to system memory
>before training, and restore it after training to avoid
>VRAM corruption.
>
>Alex
>
>>
>> >                * saving the content of this bottom VRAM to system memory
>> >                * before training, and restoring it after training to avoid
>> >                * VRAM corruption.

Thanks.

>> > --
>> > 2.26.2
>> >
>>
>>
>> --
>> ~Randy
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Tao Zhou <tao.zhou1@amd.com>,
	"Chen, Guchun" <guchun.chen@amd.com>,
	Dave Airlie <airlied@linux.ie>,
	Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>,
	Huang Rui <ray.huang@amd.com>,
	Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
	Daniel Vetter <daniel@ffwll.ch>,
	Jiansong Chen <Jiansong.Chen@amd.com>,
	"Deucher, Alexander" <alexander.deucher@amd.com>,
	Likun Gao <Likun.Gao@amd.com>,
	John Clements <John.Clements@amd.com>,
	Christian Koenig <christian.koenig@amd.com>,
	Hawking Zhang <Hawking.Zhang@amd.com>
Subject: Re: [PATCH] drm/amdgpu: Fix a typo
Date: Fri, 19 Mar 2021 01:55:21 +0530	[thread overview]
Message-ID: <YFO3MYXwWbXwTgUh@Gentoo> (raw)
In-Reply-To: <CADnq5_OsrHGxmXeuEiV06qas7jJ0pvExqdrw-PmqpKvWi=0jOg@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1741 bytes --]

On 14:12 Thu 18 Mar 2021, Alex Deucher wrote:
>On Thu, Mar 18, 2021 at 2:08 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> On 3/18/21 4:33 AM, Bhaskar Chowdhury wrote:
>> >
>> > s/traing/training/
>> >
>> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> > ---
>> >  drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
>> > index c325d6f53a71..db18e4f6cf5f 100644
>> > --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
>> > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
>> > @@ -661,7 +661,7 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
>> >
>> >       if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
>> >               /*
>> > -              * Long traing will encroach certain mount of bottom VRAM,
>> > +              * Long training will encroach certain mount of bottom VRAM,
>>
>>                                                        amount
>> I think.
>
>Yeah, I think it should read something like:
>
>Long training will encroach a certain amount on the bottom of VRAM;
>save the content from the bottom VRAM to system memory
>before training, and restore it after training to avoid
>VRAM corruption.
>
>Alex
>
>>
>> >                * saving the content of this bottom VRAM to system memory
>> >                * before training, and restoring it after training to avoid
>> >                * VRAM corruption.

Thanks.

>> > --
>> > 2.26.2
>> >
>>
>>
>> --
>> ~Randy
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  reply	other threads:[~2021-03-18 20:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 11:33 [PATCH] drm/amdgpu: Fix a typo Bhaskar Chowdhury
2021-03-18 11:33 ` Bhaskar Chowdhury
2021-03-18 11:33 ` Bhaskar Chowdhury
2021-03-18 18:07 ` Randy Dunlap
2021-03-18 18:07   ` Randy Dunlap
2021-03-18 18:07   ` Randy Dunlap
2021-03-18 18:12   ` Alex Deucher
2021-03-18 18:12     ` Alex Deucher
2021-03-18 18:12     ` Alex Deucher
2021-03-18 20:25     ` Bhaskar Chowdhury [this message]
2021-03-18 20:25       ` Bhaskar Chowdhury
2021-03-18 20:25       ` Bhaskar Chowdhury
2021-03-18 23:18 Bhaskar Chowdhury
2021-03-18 23:18 ` Bhaskar Chowdhury
2021-03-18 23:18 ` Bhaskar Chowdhury
2021-03-19  3:35 ` Alex Deucher
2021-03-19  3:35   ` Alex Deucher
2021-03-19  3:35   ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFO3MYXwWbXwTgUh@Gentoo \
    --to=unixbhaskar@gmail.com \
    --cc=Bhawanpreet.Lakha@amd.com \
    --cc=Hawking.Zhang@amd.com \
    --cc=Jiansong.Chen@amd.com \
    --cc=John.Clements@amd.com \
    --cc=Likun.Gao@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=guchun.chen@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ray.huang@amd.com \
    --cc=rdunlap@infradead.org \
    --cc=tao.zhou1@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.