All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Marek Behún" <kabel@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: cosmetic fix
Date: Fri, 19 Mar 2021 19:35:40 +0100	[thread overview]
Message-ID: <YFTu/NCDv75z7n0T@lunn.ch> (raw)
In-Reply-To: <20210319143149.823-1-kabel@kernel.org>

On Fri, Mar 19, 2021 at 03:31:49PM +0100, Marek Behún wrote:
> We know that the `lane == MV88E6393X_PORT0_LANE`, so we can pass `lane`
> to mv88e6390_serdes_read() instead of MV88E6393X_PORT0_LANE.
> 
> All other occurances in this function are using the `lane` variable.
> 
> It seems I forgot to change it at this one place after refactoring.
> 
> Signed-off-by: Marek Behún <kabel@kernel.org>
> Fixes: de776d0d316f7 ("net: dsa: mv88e6xxx: add support for ...")

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  reply	other threads:[~2021-03-19 18:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 14:31 [PATCH net-next] net: dsa: mv88e6xxx: cosmetic fix Marek Behún
2021-03-19 18:35 ` Andrew Lunn [this message]
2021-03-19 18:58 ` Vladimir Oltean
2021-03-19 19:47   ` Marek Behún
2021-03-19 22:14     ` Florian Fainelli
2021-03-19 22:54       ` Marek Behún
2021-03-20  0:46         ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFTu/NCDv75z7n0T@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=kabel@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.