* [PATCH net-next v2] net: dsa: hellcreek: Report switch name and ID
@ 2021-03-22 18:51 Kurt Kanzenbach
2021-03-22 19:14 ` Florian Fainelli
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Kurt Kanzenbach @ 2021-03-22 18:51 UTC (permalink / raw)
To: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean
Cc: David S. Miller, Jakub Kicinski, netdev, Kurt Kanzenbach
Report the driver name, ASIC ID and the switch name via devlink. This is a
useful information for user space tooling.
Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
---
Changes since v1:
* Include just the model name in ASIC ID
drivers/net/dsa/hirschmann/hellcreek.c | 18 ++++++++++++++++++
.../linux/platform_data/hirschmann-hellcreek.h | 1 +
2 files changed, 19 insertions(+)
diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c
index 64a73dd045c0..918be7eb626f 100644
--- a/drivers/net/dsa/hirschmann/hellcreek.c
+++ b/drivers/net/dsa/hirschmann/hellcreek.c
@@ -1082,6 +1082,22 @@ static int hellcreek_setup_fdb(struct hellcreek *hellcreek)
return ret;
}
+static int hellcreek_devlink_info_get(struct dsa_switch *ds,
+ struct devlink_info_req *req,
+ struct netlink_ext_ack *extack)
+{
+ struct hellcreek *hellcreek = ds->priv;
+ int ret;
+
+ ret = devlink_info_driver_name_put(req, "hellcreek");
+ if (ret)
+ return ret;
+
+ return devlink_info_version_fixed_put(req,
+ DEVLINK_INFO_VERSION_GENERIC_ASIC_ID,
+ hellcreek->pdata->name);
+}
+
static u64 hellcreek_devlink_vlan_table_get(void *priv)
{
struct hellcreek *hellcreek = priv;
@@ -1732,6 +1748,7 @@ static int hellcreek_port_setup_tc(struct dsa_switch *ds, int port,
}
static const struct dsa_switch_ops hellcreek_ds_ops = {
+ .devlink_info_get = hellcreek_devlink_info_get,
.get_ethtool_stats = hellcreek_get_ethtool_stats,
.get_sset_count = hellcreek_get_sset_count,
.get_strings = hellcreek_get_strings,
@@ -1909,6 +1926,7 @@ static int hellcreek_remove(struct platform_device *pdev)
}
static const struct hellcreek_platform_data de1soc_r1_pdata = {
+ .name = "r4c30",
.num_ports = 4,
.is_100_mbits = 1,
.qbv_support = 1,
diff --git a/include/linux/platform_data/hirschmann-hellcreek.h b/include/linux/platform_data/hirschmann-hellcreek.h
index 388846766bb2..6a000df5541f 100644
--- a/include/linux/platform_data/hirschmann-hellcreek.h
+++ b/include/linux/platform_data/hirschmann-hellcreek.h
@@ -12,6 +12,7 @@
#include <linux/types.h>
struct hellcreek_platform_data {
+ const char *name; /* Switch name */
int num_ports; /* Amount of switch ports */
int is_100_mbits; /* Is it configured to 100 or 1000 mbit/s */
int qbv_support; /* Qbv support on front TSN ports */
--
2.31.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2] net: dsa: hellcreek: Report switch name and ID
2021-03-22 18:51 [PATCH net-next v2] net: dsa: hellcreek: Report switch name and ID Kurt Kanzenbach
@ 2021-03-22 19:14 ` Florian Fainelli
2021-03-22 19:28 ` Andrew Lunn
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2021-03-22 19:14 UTC (permalink / raw)
To: Kurt Kanzenbach, Andrew Lunn, Vivien Didelot, Vladimir Oltean
Cc: David S. Miller, Jakub Kicinski, netdev
On 3/22/2021 11:51 AM, Kurt Kanzenbach wrote:
> Report the driver name, ASIC ID and the switch name via devlink. This is a
> useful information for user space tooling.
>
> Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2] net: dsa: hellcreek: Report switch name and ID
2021-03-22 18:51 [PATCH net-next v2] net: dsa: hellcreek: Report switch name and ID Kurt Kanzenbach
2021-03-22 19:14 ` Florian Fainelli
@ 2021-03-22 19:28 ` Andrew Lunn
2021-03-22 19:31 ` Vladimir Oltean
2021-03-23 21:20 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2021-03-22 19:28 UTC (permalink / raw)
To: Kurt Kanzenbach
Cc: Vivien Didelot, Florian Fainelli, Vladimir Oltean,
David S. Miller, Jakub Kicinski, netdev
On Mon, Mar 22, 2021 at 07:51:13PM +0100, Kurt Kanzenbach wrote:
> Report the driver name, ASIC ID and the switch name via devlink. This is a
> useful information for user space tooling.
>
> Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2] net: dsa: hellcreek: Report switch name and ID
2021-03-22 18:51 [PATCH net-next v2] net: dsa: hellcreek: Report switch name and ID Kurt Kanzenbach
2021-03-22 19:14 ` Florian Fainelli
2021-03-22 19:28 ` Andrew Lunn
@ 2021-03-22 19:31 ` Vladimir Oltean
2021-03-23 21:20 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Vladimir Oltean @ 2021-03-22 19:31 UTC (permalink / raw)
To: Kurt Kanzenbach
Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, David S. Miller,
Jakub Kicinski, netdev
On Mon, Mar 22, 2021 at 07:51:13PM +0100, Kurt Kanzenbach wrote:
> Report the driver name, ASIC ID and the switch name via devlink. This is a
> useful information for user space tooling.
>
> Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v2] net: dsa: hellcreek: Report switch name and ID
2021-03-22 18:51 [PATCH net-next v2] net: dsa: hellcreek: Report switch name and ID Kurt Kanzenbach
` (2 preceding siblings ...)
2021-03-22 19:31 ` Vladimir Oltean
@ 2021-03-23 21:20 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-23 21:20 UTC (permalink / raw)
To: Kurt Kanzenbach
Cc: andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba, netdev
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 22 Mar 2021 19:51:13 +0100 you wrote:
> Report the driver name, ASIC ID and the switch name via devlink. This is a
> useful information for user space tooling.
>
> Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
> ---
> Changes since v1:
>
> [...]
Here is the summary with links:
- [net-next,v2] net: dsa: hellcreek: Report switch name and ID
https://git.kernel.org/netdev/net-next/c/1ab568e92bf8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-23 21:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-22 18:51 [PATCH net-next v2] net: dsa: hellcreek: Report switch name and ID Kurt Kanzenbach
2021-03-22 19:14 ` Florian Fainelli
2021-03-22 19:28 ` Andrew Lunn
2021-03-22 19:31 ` Vladimir Oltean
2021-03-23 21:20 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.