[PATCH 0/3] w1: ds2438: adding support for calibration of current measurements

[PATCH 0/3] w1: ds2438: adding support for calibration of current measurements

[Luiz Sampaio]

The following patches aim to make a user able to calibrate the current measurement of the ds2438. This chip uses a offset register in page1, which is added to the current register to give the user the current measurement. If this value is wrong, the user will get an offset current value, even if the current is zero, for instance. This patch gives support to read the page1 registers (including the offset register) and to write to the offset register. The ds2438 datasheet shows a calibration routine, and with this patch, the user can to this quickly by write the correct value to the offset register.
This patch was tested on real hardware using a power supply and an electronic load.
Please help to review this series of patches.

Best regards!
Sampaio

Luiz Sampaio (3):
  w1: ds2438: fixed a coding style issues
  w1: ds2438: fixed bug in get_page function
  w1: ds2438: adding support for accessing page1 registers

 drivers/w1/slaves/w1_ds2438.c | 120 +++++++++++++++++++++++++++++-----
 1 file changed, 104 insertions(+), 16 deletions(-)

-- 
2.30.1

Re: [PATCH 0/3] w1: ds2438: adding support for calibration of current measurements

[Greg KH]

On Mon, Mar 22, 2021 at 11:40:37PM -0300, Luiz Sampaio wrote:
> The following patches aim to make a user able to calibrate the current measurement of the ds2438. This chip uses a offset register in page1, which is added to the current register to give the user the current measurement. If this value is wrong, the user will get an offset current value, even if the current is zero, for instance. This patch gives support to read the page1 registers (including the offset register) and to write to the offset register. The ds2438 datasheet shows a calibration routine, and with this patch, the user can to this quickly by write the correct value to the offset register.
> This patch was tested on real hardware using a power supply and an electronic load.
> Please help to review this series of patches.

Please properly wrap your email lines :(

Also, this was not sent threaded, so I missing some of the patches, how
did you send them?  Tools like 'git send-email' should do this
automatically.

Can you fix up and resend all 3.

thanks,

greg k-h