All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Jeffle Xu <jefflexu@linux.alibaba.com>,
	dm-devel@redhat.com
Subject: Re: [RFC PATCH V2 04/13] block: create io poll context for submission and poll task
Date: Tue, 23 Mar 2021 19:23:32 +0800	[thread overview]
Message-ID: <YFnPtHiFnojajCUK@T590> (raw)
In-Reply-To: <20210319170509.GB9938@redhat.com>

On Fri, Mar 19, 2021 at 01:05:09PM -0400, Mike Snitzer wrote:
> On Thu, Mar 18 2021 at 12:48pm -0400,
> Ming Lei <ming.lei@redhat.com> wrote:
> 
> > Create per-task io poll context for both IO submission and poll task
> > if the queue is bio based and supports polling.
> > 
> > This io polling context includes two queues:
> 1) submission queue(sq) for storing HIPRI bio submission result(cookie)
>    and the bio, written by submission task and read by poll task.

BTW, V2 has switched to store bio only, and cookie is actually stored in
side bio.

> 2) polling queue(pq) for holding data moved from sq, only used in poll
>    context for running bio polling.
>  
> (nit, but it just reads a bit clearer to enumerate the 2 queues)

OK.

-- 
Ming


WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	Jeffle Xu <jefflexu@linux.alibaba.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [dm-devel] [RFC PATCH V2 04/13] block: create io poll context for submission and poll task
Date: Tue, 23 Mar 2021 19:23:32 +0800	[thread overview]
Message-ID: <YFnPtHiFnojajCUK@T590> (raw)
In-Reply-To: <20210319170509.GB9938@redhat.com>

On Fri, Mar 19, 2021 at 01:05:09PM -0400, Mike Snitzer wrote:
> On Thu, Mar 18 2021 at 12:48pm -0400,
> Ming Lei <ming.lei@redhat.com> wrote:
> 
> > Create per-task io poll context for both IO submission and poll task
> > if the queue is bio based and supports polling.
> > 
> > This io polling context includes two queues:
> 1) submission queue(sq) for storing HIPRI bio submission result(cookie)
>    and the bio, written by submission task and read by poll task.

BTW, V2 has switched to store bio only, and cookie is actually stored in
side bio.

> 2) polling queue(pq) for holding data moved from sq, only used in poll
>    context for running bio polling.
>  
> (nit, but it just reads a bit clearer to enumerate the 2 queues)

OK.

-- 
Ming

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2021-03-23 11:24 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18 16:48 [RFC PATCH V2 00/13] block: support bio based io polling Ming Lei
2021-03-18 16:48 ` [dm-devel] " Ming Lei
2021-03-18 16:48 ` [RFC PATCH V2 01/13] block: add helper of blk_queue_poll Ming Lei
2021-03-18 16:48   ` [dm-devel] " Ming Lei
2021-03-19 16:52   ` Mike Snitzer
2021-03-19 16:52     ` [dm-devel] " Mike Snitzer
2021-03-23 11:17     ` Ming Lei
2021-03-23 11:17       ` [dm-devel] " Ming Lei
2021-03-18 16:48 ` [RFC PATCH V2 02/13] block: add one helper to free io_context Ming Lei
2021-03-18 16:48   ` [dm-devel] " Ming Lei
2021-03-18 16:48 ` [RFC PATCH V2 03/13] block: add helper of blk_create_io_context Ming Lei
2021-03-18 16:48   ` [dm-devel] " Ming Lei
2021-03-18 16:48 ` [RFC PATCH V2 04/13] block: create io poll context for submission and poll task Ming Lei
2021-03-18 16:48   ` [dm-devel] " Ming Lei
2021-03-19 17:05   ` Mike Snitzer
2021-03-19 17:05     ` [dm-devel] " Mike Snitzer
2021-03-23 11:23     ` Ming Lei [this message]
2021-03-23 11:23       ` Ming Lei
2021-03-18 16:48 ` [RFC PATCH V2 05/13] block: add req flag of REQ_TAG Ming Lei
2021-03-18 16:48   ` [dm-devel] " Ming Lei
2021-03-19  7:59   ` JeffleXu
2021-03-19  7:59     ` [dm-devel] " JeffleXu
2021-03-19  8:48     ` Ming Lei
2021-03-19  8:48       ` [dm-devel] " Ming Lei
2021-03-19  9:47       ` JeffleXu
2021-03-19  9:47         ` [dm-devel] " JeffleXu
2021-03-19 17:38   ` Mike Snitzer
2021-03-19 17:38     ` [dm-devel] " Mike Snitzer
2021-03-23 11:26     ` Ming Lei
2021-03-23 11:26       ` [dm-devel] " Ming Lei
2021-03-18 16:48 ` [RFC PATCH V2 06/13] block: add new field into 'struct bvec_iter' Ming Lei
2021-03-18 16:48   ` [dm-devel] " Ming Lei
2021-03-19 17:44   ` Mike Snitzer
2021-03-19 17:44     ` [dm-devel] " Mike Snitzer
2021-03-23 11:29     ` Ming Lei
2021-03-23 11:29       ` [dm-devel] " Ming Lei
2021-03-18 16:48 ` [RFC PATCH V2 07/13] block/mq: extract one helper function polling hw queue Ming Lei
2021-03-18 16:48   ` [dm-devel] " Ming Lei
2021-03-18 16:48 ` [RFC PATCH V2 08/13] block: prepare for supporting bio_list via other link Ming Lei
2021-03-18 16:48   ` [dm-devel] " Ming Lei
2021-03-18 16:48 ` [RFC PATCH V2 09/13] block: use per-task poll context to implement bio based io poll Ming Lei
2021-03-18 16:48   ` [dm-devel] " Ming Lei
2021-03-18 17:26   ` Mike Snitzer
2021-03-18 17:26     ` [dm-devel] " Mike Snitzer
2021-03-18 17:38     ` Mike Snitzer
2021-03-18 17:38       ` Mike Snitzer
2021-03-19  0:30     ` Ming Lei
2021-03-19  0:30       ` [dm-devel] " Ming Lei
2021-03-19  9:38   ` JeffleXu
2021-03-19  9:38     ` [dm-devel] " JeffleXu
2021-03-19 13:46     ` Ming Lei
2021-03-19 13:46       ` [dm-devel] " Ming Lei
2021-03-20  5:56       ` JeffleXu
2021-03-20  5:56         ` [dm-devel] " JeffleXu
2021-03-23 11:39         ` Ming Lei
2021-03-23 11:39           ` [dm-devel] " Ming Lei
2021-03-19 18:38   ` Mike Snitzer
2021-03-19 18:38     ` [dm-devel] " Mike Snitzer
2021-03-23 11:55     ` Ming Lei
2021-03-23 11:55       ` [dm-devel] " Ming Lei
2021-03-23  3:46   ` Sagi Grimberg
2021-03-23  3:46     ` [dm-devel] " Sagi Grimberg
2021-03-23 12:01     ` Ming Lei
2021-03-23 12:01       ` [dm-devel] " Ming Lei
2021-03-23 16:54       ` Sagi Grimberg
2021-03-23 16:54         ` [dm-devel] " Sagi Grimberg
2021-03-24  0:10         ` Ming Lei
2021-03-24  0:10           ` [dm-devel] " Ming Lei
2021-03-24 15:43           ` Sagi Grimberg
2021-03-24 15:43             ` [dm-devel] " Sagi Grimberg
2021-03-18 16:48 ` [RFC PATCH V2 10/13] block: add queue_to_disk() to get gendisk from request_queue Ming Lei
2021-03-18 16:48   ` [dm-devel] " Ming Lei
2021-03-18 16:48 ` [RFC PATCH V2 11/13] block: add poll_capable method to support bio-based IO polling Ming Lei
2021-03-18 16:48   ` [dm-devel] " Ming Lei
2021-03-18 16:48 ` [RFC PATCH V2 12/13] dm: support IO polling for bio-based dm device Ming Lei
2021-03-18 16:48   ` [dm-devel] " Ming Lei
2021-03-18 16:48 ` [RFC PATCH V2 13/13] blk-mq: limit hw queues to be polled in each blk_poll() Ming Lei
2021-03-18 16:48   ` [dm-devel] " Ming Lei
2021-03-19  5:50 ` [RFC PATCH V2 00/13] block: support bio based io polling JeffleXu
2021-03-19  5:50   ` [dm-devel] " JeffleXu
2021-03-19 18:45 ` Mike Snitzer
2021-03-19 18:45   ` [dm-devel] " Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YFnPtHiFnojajCUK@T590 \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=jefflexu@linux.alibaba.com \
    --cc=linux-block@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.