From: Andrew Lunn <andrew@lunn.ch>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: davem@davemloft.net, kuba@kernel.org, vivien.didelot@gmail.com,
f.fainelli@gmail.com, olteanv@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: Allow dynamic reconfiguration of tag protocol
Date: Tue, 23 Mar 2021 13:41:05 +0100 [thread overview]
Message-ID: <YFnh4dEap/lGX4ix@lunn.ch> (raw)
In-Reply-To: <20210323102326.3677940-1-tobias@waldekranz.com>
On Tue, Mar 23, 2021 at 11:23:26AM +0100, Tobias Waldekranz wrote:
> All devices are capable of using regular DSA tags. Support for
> Ethertyped DSA tags sort into three categories:
>
> 1. No support. Older chips fall into this category.
>
> 2. Full support. Datasheet explicitly supports configuring the CPU
> port to receive FORWARDs with a DSA tag.
>
> 3. Undocumented support. Datasheet lists the configuration from
> category 2 as "reserved for future use", but does empirically
> behave like a category 2 device.
>
> Because there are ethernet controllers that do not handle regular DSA
> tags in all cases, it is sometimes preferable to rely on the
> undocumented behavior, as the alternative is a very crippled
> system. But, in those cases, make sure to log the fact that an
> undocumented feature has been enabled.
Hi Tobias
I wonder if dynamic reconfiguration is the correct solution here. By
default it will be wrong for this board, and you need user space to
flip it.
Maybe a DT property would be better. Extend dsa_switch_parse_of() to
look for the optional property dsa,tag-protocol, a string containing
the name of the tag ops to be used.
Andrew
next prev parent reply other threads:[~2021-03-23 12:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 10:23 [PATCH net-next] net: dsa: mv88e6xxx: Allow dynamic reconfiguration of tag protocol Tobias Waldekranz
2021-03-23 11:35 ` Vladimir Oltean
2021-03-23 12:32 ` Andrew Lunn
2021-03-23 14:48 ` Tobias Waldekranz
2021-03-23 16:30 ` Florian Fainelli
2021-03-23 19:03 ` Vladimir Oltean
2021-03-23 21:17 ` Tobias Waldekranz
2021-03-23 23:15 ` Vladimir Oltean
2021-03-24 10:52 ` Tobias Waldekranz
2021-03-24 11:34 ` Vladimir Oltean
2021-03-24 13:01 ` Tobias Waldekranz
2021-03-24 13:24 ` Vladimir Oltean
2021-03-24 14:03 ` Vladimir Oltean
2021-03-24 14:10 ` Vladimir Oltean
2021-03-24 15:02 ` Tobias Waldekranz
2021-03-24 15:08 ` Vladimir Oltean
2021-03-24 16:07 ` Tobias Waldekranz
2021-03-25 1:34 ` Vladimir Oltean
2021-03-25 8:04 ` Tobias Waldekranz
2021-03-23 12:41 ` Andrew Lunn [this message]
2021-03-23 14:49 ` Tobias Waldekranz
2021-03-23 16:53 ` Florian Fainelli
2021-03-23 20:50 ` Tobias Waldekranz
2021-03-24 0:44 ` Andrew Lunn
2021-03-24 12:53 ` Tobias Waldekranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFnh4dEap/lGX4ix@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.