* [PATCH] omap3isp.h: fix kernel-doc warnings
@ 2021-03-23 8:12 Hans Verkuil
2021-03-23 21:52 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Hans Verkuil @ 2021-03-23 8:12 UTC (permalink / raw)
To: Linux Media Mailing List; +Cc: Laurent Pinchart
Add missing documentation for two field. This fixes these kernel-doc
warnings:
drivers/media/platform/omap3isp/omap3isp.h:107: warning: Function parameter or member 'vp_clk_pol' not described in 'isp_ccp2_cfg'
drivers/media/platform/omap3isp/omap3isp.h:107: warning: Function parameter or member 'lanecfg' not described in 'isp_ccp2_cfg'
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
diff --git a/drivers/media/platform/omap3isp/omap3isp.h b/drivers/media/platform/omap3isp/omap3isp.h
index 214f94c46a9d..4a003c8263ed 100644
--- a/drivers/media/platform/omap3isp/omap3isp.h
+++ b/drivers/media/platform/omap3isp/omap3isp.h
@@ -95,6 +95,8 @@ struct isp_csiphy_lanes_cfg {
* ISP_CCP2_PHY_DATA_CLOCK - Data/clock physical layer
* ISP_CCP2_PHY_DATA_STROBE - Data/strobe physical layer
* @vpclk_div: Video port output clock control
+ * @vp_clk_pol: Video port output clock polarity
+ * @lanecfg: CCP2/CSI2 lane configuration
*/
struct isp_ccp2_cfg {
unsigned int strobe_clk_pol:1;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] omap3isp.h: fix kernel-doc warnings
2021-03-23 8:12 [PATCH] omap3isp.h: fix kernel-doc warnings Hans Verkuil
@ 2021-03-23 21:52 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2021-03-23 21:52 UTC (permalink / raw)
To: Hans Verkuil; +Cc: Linux Media Mailing List
Hi Hans,
Thank you for the patch.
On Tue, Mar 23, 2021 at 09:12:47AM +0100, Hans Verkuil wrote:
> Add missing documentation for two field. This fixes these kernel-doc
> warnings:
>
> drivers/media/platform/omap3isp/omap3isp.h:107: warning: Function parameter or member 'vp_clk_pol' not described in 'isp_ccp2_cfg'
> drivers/media/platform/omap3isp/omap3isp.h:107: warning: Function parameter or member 'lanecfg' not described in 'isp_ccp2_cfg'
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> diff --git a/drivers/media/platform/omap3isp/omap3isp.h b/drivers/media/platform/omap3isp/omap3isp.h
> index 214f94c46a9d..4a003c8263ed 100644
> --- a/drivers/media/platform/omap3isp/omap3isp.h
> +++ b/drivers/media/platform/omap3isp/omap3isp.h
> @@ -95,6 +95,8 @@ struct isp_csiphy_lanes_cfg {
> * ISP_CCP2_PHY_DATA_CLOCK - Data/clock physical layer
> * ISP_CCP2_PHY_DATA_STROBE - Data/strobe physical layer
> * @vpclk_div: Video port output clock control
> + * @vp_clk_pol: Video port output clock polarity
> + * @lanecfg: CCP2/CSI2 lane configuration
> */
> struct isp_ccp2_cfg {
> unsigned int strobe_clk_pol:1;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-23 21:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 8:12 [PATCH] omap3isp.h: fix kernel-doc warnings Hans Verkuil
2021-03-23 21:52 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.