* [Intel-gfx] [PATCH 1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level()
@ 2021-03-25 0:44 Ville Syrjala
2021-03-25 0:44 ` [Intel-gfx] [PATCH 2/2] drm/i915: Stop adding planes to the commit needlessly Ville Syrjala
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Ville Syrjala @ 2021-03-25 0:44 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Accidentally transposed the arguments to skl_plane_wm_level()
which is causing us to mistakenly think that the plane watermarks
have/have not changed when the opposite may be true. Swap the
arguments so this actually works.
The other uses of this look OK.
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Fixes: 2871b2fde449 ("drm/i915: Fix TGL+ plane SAGV watermark programming")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 820f850d5cbb..b2aede2be89d 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -6017,8 +6017,8 @@ static bool skl_plane_selected_wm_equals(struct intel_plane *plane,
* use it. It only gets used for calculating the required
* ddb allocation.
*/
- if (!skl_wm_level_equals(skl_plane_wm_level(old_pipe_wm, level, plane->id),
- skl_plane_wm_level(new_pipe_wm, level, plane->id)))
+ if (!skl_wm_level_equals(skl_plane_wm_level(old_pipe_wm, plane->id, level),
+ skl_plane_wm_level(new_pipe_wm, plane->id, level)))
return false;
}
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915: Stop adding planes to the commit needlessly
2021-03-25 0:44 [Intel-gfx] [PATCH 1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level() Ville Syrjala
@ 2021-03-25 0:44 ` Ville Syrjala
2021-03-25 9:35 ` Lisovskiy, Stanislav
2021-03-25 8:35 ` [Intel-gfx] [PATCH 1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level() Lisovskiy, Stanislav
` (3 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Ville Syrjala @ 2021-03-25 0:44 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The dbuf bandwidth calculations don't need the planes to be
added to the state. Each plane's data rate has already been
precalculated and stored in the crtc state, and that with
the dbuf slice usage for each plane is all the dbuf bandwidth
code needs to figure out what the minimum cdclk is.
What we're trying to do here is make sure each plane recalculates
its minimum cdclk (ie. plane->min_cdclk()) on those platforms where
the number of active planes affects the result of said calculation.
Nothing to do with any dbuf cdclk requirements.
Not sure if we had stuff in slightly different order or what,
but at least in the current scheme this is not necessary.
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 17490d29dc13..2300d58ba47f 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -9811,7 +9811,7 @@ static bool active_planes_affects_min_cdclk(struct drm_i915_private *dev_priv)
/* See {hsw,vlv,ivb}_plane_ratio() */
return IS_BROADWELL(dev_priv) || IS_HASWELL(dev_priv) ||
IS_CHERRYVIEW(dev_priv) || IS_VALLEYVIEW(dev_priv) ||
- IS_IVYBRIDGE(dev_priv) || (DISPLAY_VER(dev_priv) >= 11);
+ IS_IVYBRIDGE(dev_priv);
}
static int intel_crtc_add_bigjoiner_planes(struct intel_atomic_state *state,
@@ -9898,13 +9898,7 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
old_active_planes = old_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
new_active_planes = new_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
- /*
- * Not only the number of planes, but if the plane configuration had
- * changed might already mean we need to recompute min CDCLK,
- * because different planes might consume different amount of Dbuf bandwidth
- * according to formula: Bw per plane = Pixel rate * bpp * pipe/plane scale factor
- */
- if (old_active_planes == new_active_planes)
+ if (hweight8(old_active_planes) == hweight8(new_active_planes))
continue;
ret = intel_crtc_add_planes_to_state(state, crtc, new_active_planes);
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level()
2021-03-25 0:44 [Intel-gfx] [PATCH 1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level() Ville Syrjala
2021-03-25 0:44 ` [Intel-gfx] [PATCH 2/2] drm/i915: Stop adding planes to the commit needlessly Ville Syrjala
@ 2021-03-25 8:35 ` Lisovskiy, Stanislav
2021-03-25 19:03 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Lisovskiy, Stanislav @ 2021-03-25 8:35 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
On Thu, Mar 25, 2021 at 02:44:14AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Accidentally transposed the arguments to skl_plane_wm_level()
> which is causing us to mistakenly think that the plane watermarks
> have/have not changed when the opposite may be true. Swap the
> arguments so this actually works.
>
> The other uses of this look OK.
Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Fixes: 2871b2fde449 ("drm/i915: Fix TGL+ plane SAGV watermark programming")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 820f850d5cbb..b2aede2be89d 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -6017,8 +6017,8 @@ static bool skl_plane_selected_wm_equals(struct intel_plane *plane,
> * use it. It only gets used for calculating the required
> * ddb allocation.
> */
> - if (!skl_wm_level_equals(skl_plane_wm_level(old_pipe_wm, level, plane->id),
> - skl_plane_wm_level(new_pipe_wm, level, plane->id)))
> + if (!skl_wm_level_equals(skl_plane_wm_level(old_pipe_wm, plane->id, level),
> + skl_plane_wm_level(new_pipe_wm, plane->id, level)))
> return false;
> }
>
> --
> 2.26.2
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Stop adding planes to the commit needlessly
2021-03-25 0:44 ` [Intel-gfx] [PATCH 2/2] drm/i915: Stop adding planes to the commit needlessly Ville Syrjala
@ 2021-03-25 9:35 ` Lisovskiy, Stanislav
2021-03-25 11:37 ` Ville Syrjälä
0 siblings, 1 reply; 9+ messages in thread
From: Lisovskiy, Stanislav @ 2021-03-25 9:35 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
On Thu, Mar 25, 2021 at 02:44:15AM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The dbuf bandwidth calculations don't need the planes to be
> added to the state. Each plane's data rate has already been
> precalculated and stored in the crtc state, and that with
> the dbuf slice usage for each plane is all the dbuf bandwidth
> code needs to figure out what the minimum cdclk is.
>
> What we're trying to do here is make sure each plane recalculates
> its minimum cdclk (ie. plane->min_cdclk()) on those platforms where
> the number of active planes affects the result of said calculation.
> Nothing to do with any dbuf cdclk requirements.
So does it mean that if we lets say had active plane mask as
011(planes 0, 1 were active) and new active planes are 101(planes 0, 2
are active) - we should not add plane 2 to the state?
Because hamming weight will be obviously same, however I think it would
be wrong not have plane 2 in the state at all then..
Or will it be added somewhere else?
Stan
>
> Not sure if we had stuff in slightly different order or what,
> but at least in the current scheme this is not necessary.
>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 17490d29dc13..2300d58ba47f 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -9811,7 +9811,7 @@ static bool active_planes_affects_min_cdclk(struct drm_i915_private *dev_priv)
> /* See {hsw,vlv,ivb}_plane_ratio() */
> return IS_BROADWELL(dev_priv) || IS_HASWELL(dev_priv) ||
> IS_CHERRYVIEW(dev_priv) || IS_VALLEYVIEW(dev_priv) ||
> - IS_IVYBRIDGE(dev_priv) || (DISPLAY_VER(dev_priv) >= 11);
> + IS_IVYBRIDGE(dev_priv);
> }
>
> static int intel_crtc_add_bigjoiner_planes(struct intel_atomic_state *state,
> @@ -9898,13 +9898,7 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
> old_active_planes = old_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
> new_active_planes = new_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
>
> - /*
> - * Not only the number of planes, but if the plane configuration had
> - * changed might already mean we need to recompute min CDCLK,
> - * because different planes might consume different amount of Dbuf bandwidth
> - * according to formula: Bw per plane = Pixel rate * bpp * pipe/plane scale factor
> - */
> - if (old_active_planes == new_active_planes)
> + if (hweight8(old_active_planes) == hweight8(new_active_planes))
> continue;
>
> ret = intel_crtc_add_planes_to_state(state, crtc, new_active_planes);
> --
> 2.26.2
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Stop adding planes to the commit needlessly
2021-03-25 9:35 ` Lisovskiy, Stanislav
@ 2021-03-25 11:37 ` Ville Syrjälä
2021-03-29 9:01 ` Lisovskiy, Stanislav
0 siblings, 1 reply; 9+ messages in thread
From: Ville Syrjälä @ 2021-03-25 11:37 UTC (permalink / raw)
To: Lisovskiy, Stanislav; +Cc: intel-gfx
On Thu, Mar 25, 2021 at 11:35:53AM +0200, Lisovskiy, Stanislav wrote:
> On Thu, Mar 25, 2021 at 02:44:15AM +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The dbuf bandwidth calculations don't need the planes to be
> > added to the state. Each plane's data rate has already been
> > precalculated and stored in the crtc state, and that with
> > the dbuf slice usage for each plane is all the dbuf bandwidth
> > code needs to figure out what the minimum cdclk is.
> >
> > What we're trying to do here is make sure each plane recalculates
> > its minimum cdclk (ie. plane->min_cdclk()) on those platforms where
> > the number of active planes affects the result of said calculation.
> > Nothing to do with any dbuf cdclk requirements.
>
> So does it mean that if we lets say had active plane mask as
> 011(planes 0, 1 were active) and new active planes are 101(planes 0, 2
> are active) - we should not add plane 2 to the state?
> Because hamming weight will be obviously same, however I think it would
> be wrong not have plane 2 in the state at all then..
>
> Or will it be added somewhere else?
If someone is asking to disable plane 2 then it will be added to
the state already during the atomic/setplance ioctl handling.
>
>
> Stan
>
> >
> > Not sure if we had stuff in slightly different order or what,
> > but at least in the current scheme this is not necessary.
> >
> > Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 10 ++--------
> > 1 file changed, 2 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > index 17490d29dc13..2300d58ba47f 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -9811,7 +9811,7 @@ static bool active_planes_affects_min_cdclk(struct drm_i915_private *dev_priv)
> > /* See {hsw,vlv,ivb}_plane_ratio() */
> > return IS_BROADWELL(dev_priv) || IS_HASWELL(dev_priv) ||
> > IS_CHERRYVIEW(dev_priv) || IS_VALLEYVIEW(dev_priv) ||
> > - IS_IVYBRIDGE(dev_priv) || (DISPLAY_VER(dev_priv) >= 11);
> > + IS_IVYBRIDGE(dev_priv);
> > }
> >
> > static int intel_crtc_add_bigjoiner_planes(struct intel_atomic_state *state,
> > @@ -9898,13 +9898,7 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
> > old_active_planes = old_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
> > new_active_planes = new_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
> >
> > - /*
> > - * Not only the number of planes, but if the plane configuration had
> > - * changed might already mean we need to recompute min CDCLK,
> > - * because different planes might consume different amount of Dbuf bandwidth
> > - * according to formula: Bw per plane = Pixel rate * bpp * pipe/plane scale factor
> > - */
> > - if (old_active_planes == new_active_planes)
> > + if (hweight8(old_active_planes) == hweight8(new_active_planes))
> > continue;
> >
> > ret = intel_crtc_add_planes_to_state(state, crtc, new_active_planes);
> > --
> > 2.26.2
> >
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level()
2021-03-25 0:44 [Intel-gfx] [PATCH 1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level() Ville Syrjala
2021-03-25 0:44 ` [Intel-gfx] [PATCH 2/2] drm/i915: Stop adding planes to the commit needlessly Ville Syrjala
2021-03-25 8:35 ` [Intel-gfx] [PATCH 1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level() Lisovskiy, Stanislav
@ 2021-03-25 19:03 ` Patchwork
2021-03-25 19:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-26 0:14 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2021-03-25 19:03 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level()
URL : https://patchwork.freedesktop.org/series/88420/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'shadow_map' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'batch_map' not described in 'intel_engine_cmd_parser'
./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser'
/home/cidrm/kernel/Documentation/gpu/i915:22: ./drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level()
2021-03-25 0:44 [Intel-gfx] [PATCH 1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level() Ville Syrjala
` (2 preceding siblings ...)
2021-03-25 19:03 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] " Patchwork
@ 2021-03-25 19:28 ` Patchwork
2021-03-26 0:14 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2021-03-25 19:28 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 4985 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level()
URL : https://patchwork.freedesktop.org/series/88420/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9895 -> Patchwork_19851
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/index.html
Known issues
------------
Here are the changes found in Patchwork_19851 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@read:
- fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/fi-tgl-y/igt@fbdev@read.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/fi-tgl-y/igt@fbdev@read.html
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271]) +24 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][5] ([i915#1886] / [i915#2291])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827]) +8 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][7] -> [FAIL][8] ([i915#1372])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#533])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-y: [DMESG-WARN][10] ([i915#2411] / [i915#402]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
* igt@i915_getparams_basic@basic-subslice-total:
- fi-tgl-y: [DMESG-WARN][12] ([i915#402]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/fi-tgl-y/igt@i915_getparams_basic@basic-subslice-total.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#3180]: https://gitlab.freedesktop.org/drm/intel/issues/3180
[i915#3278]: https://gitlab.freedesktop.org/drm/intel/issues/3278
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Participating hosts (46 -> 42)
------------------------------
Additional (1): fi-kbl-soraka
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9895 -> Patchwork_19851
CI-20190529: 20190529
CI_DRM_9895: bb187b1b292c637c3ef195f46d6e5c74f60df8f4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6046: e76039273b1524147c43dba061756f06003d56ae @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19851: bb530435a8e128e1d2d7b292efea3289d3b63b82 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
bb530435a8e1 drm/i915: Stop adding planes to the commit needlessly
f91462ea538d drm/i915: Fix transposed arguments to skl_plane_wm_level()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/index.html
[-- Attachment #1.2: Type: text/html, Size: 5949 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level()
2021-03-25 0:44 [Intel-gfx] [PATCH 1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level() Ville Syrjala
` (3 preceding siblings ...)
2021-03-25 19:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-03-26 0:14 ` Patchwork
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2021-03-26 0:14 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30308 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level()
URL : https://patchwork.freedesktop.org/series/88420/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9895_full -> Patchwork_19851_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_19851_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-queued:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-snb5/igt@gem_ctx_persistence@legacy-engines-queued.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][2] -> [FAIL][3] ([i915#2846])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl1/igt@gem_exec_fair@basic-deadline.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl6/igt@gem_exec_fair@basic-deadline.html
- shard-apl: NOTRUN -> [FAIL][4] ([i915#2846])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl3/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: NOTRUN -> [FAIL][5] ([i915#2842])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-glk5/igt@gem_exec_fair@basic-none@rcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-glk9/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][8] -> [FAIL][9] ([i915#2842]) +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl6/igt@gem_exec_fair@basic-none@vcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl2/igt@gem_exec_fair@basic-none@vcs0.html
- shard-apl: NOTRUN -> [FAIL][10] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl6/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglb: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-tglb5/igt@gem_exec_fair@basic-pace@rcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-tglb5/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][13] -> [FAIL][14] ([i915#2849])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_params@no-bsd:
- shard-iclb: NOTRUN -> [SKIP][15] ([fdo#109283])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@gem_exec_params@no-bsd.html
* igt@gem_exec_reloc@basic-parallel:
- shard-kbl: NOTRUN -> [TIMEOUT][16] ([i915#3183])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl3/igt@gem_exec_reloc@basic-parallel.html
* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-snb: NOTRUN -> [FAIL][17] ([i915#2389]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-snb5/igt@gem_exec_reloc@basic-wide-active@rcs0.html
* igt@gem_mmap_gtt@big-copy:
- shard-skl: [PASS][18] -> [FAIL][19] ([i915#307])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl8/igt@gem_mmap_gtt@big-copy.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl4/igt@gem_mmap_gtt@big-copy.html
* igt@gem_mmap_gtt@cpuset-basic-small-copy:
- shard-iclb: [PASS][20] -> [FAIL][21] ([i915#307])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb3/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@gem_mmap_gtt@cpuset-basic-small-copy.html
* igt@gem_pwrite@basic-exhaustion:
- shard-kbl: NOTRUN -> [WARN][22] ([i915#2658])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl6/igt@gem_pwrite@basic-exhaustion.html
* igt@gen9_exec_parse@batch-invalid-length:
- shard-snb: NOTRUN -> [SKIP][23] ([fdo#109271]) +175 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-snb5/igt@gen9_exec_parse@batch-invalid-length.html
* igt@gen9_exec_parse@secure-batches:
- shard-iclb: NOTRUN -> [SKIP][24] ([fdo#112306])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@gen9_exec_parse@secure-batches.html
* igt@i915_pm_dc@dc6-dpms:
- shard-skl: NOTRUN -> [FAIL][25] ([i915#454])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl7/igt@i915_pm_dc@dc6-dpms.html
* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [PASS][26] -> [FAIL][27] ([i915#2597])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-tglb7/igt@kms_async_flips@test-time-stamp.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-tglb1/igt@kms_async_flips@test-time-stamp.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo:
- shard-skl: NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111304])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl7/igt@kms_ccs@pipe-c-ccs-on-another-bo.html
* igt@kms_chamelium@dp-crc-multiple:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +26 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl6/igt@kms_chamelium@dp-crc-multiple.html
* igt@kms_chamelium@dp-hpd-storm:
- shard-iclb: NOTRUN -> [SKIP][30] ([fdo#109284] / [fdo#111827]) +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@kms_chamelium@dp-hpd-storm.html
* igt@kms_chamelium@hdmi-mode-timings:
- shard-snb: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +13 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-snb7/igt@kms_chamelium@hdmi-mode-timings.html
* igt@kms_color_chamelium@pipe-b-ctm-limited-range:
- shard-kbl: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827]) +5 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl4/igt@kms_color_chamelium@pipe-b-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-skl: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +7 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl9/igt@kms_color_chamelium@pipe-d-ctm-0-25.html
* igt@kms_content_protection@atomic-dpms:
- shard-kbl: NOTRUN -> [TIMEOUT][34] ([i915#1319])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl3/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@legacy:
- shard-apl: NOTRUN -> [TIMEOUT][35] ([i915#1319])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl6/igt@kms_content_protection@legacy.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][36] -> [DMESG-WARN][37] ([i915#180]) +8 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][38] ([i915#180])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen:
- shard-kbl: NOTRUN -> [SKIP][39] ([fdo#109271]) +74 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl6/igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen.html
* igt@kms_cursor_crc@pipe-d-cursor-64x64-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][40] ([fdo#109278]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@kms_cursor_crc@pipe-d-cursor-64x64-rapid-movement.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic:
- shard-iclb: NOTRUN -> [SKIP][41] ([fdo#109274] / [fdo#109278])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic.html
* igt@kms_flip@2x-blocking-wf_vblank:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109274]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@kms_flip@2x-blocking-wf_vblank.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2:
- shard-glk: [PASS][43] -> [FAIL][44] ([i915#79])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [PASS][45] -> [DMESG-WARN][46] ([i915#180]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl3/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1:
- shard-skl: [PASS][47] -> [FAIL][48] ([i915#2122])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl4/igt@kms_flip@plain-flip-fb-recreate-interruptible@a-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#2587])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-tglb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#2672])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile:
- shard-apl: NOTRUN -> [FAIL][51] ([i915#2641])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-wc:
- shard-tglb: NOTRUN -> [SKIP][52] ([fdo#111825]) +4 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109280]) +5 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu:
- shard-skl: NOTRUN -> [SKIP][54] ([fdo#109271]) +72 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_hdr@static-toggle-dpms:
- shard-iclb: NOTRUN -> [SKIP][55] ([i915#1187])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@kms_hdr@static-toggle-dpms.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#533]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl6/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#533])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl9/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html
* igt@kms_pipe_crc_basic@read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#533])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl3/igt@kms_pipe_crc_basic@read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][59] ([fdo#108145] / [i915#265]) +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: NOTRUN -> [FAIL][60] ([fdo#108145] / [i915#265])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][61] ([i915#265])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl6/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_prime@basic-crc@first-to-second:
- shard-iclb: NOTRUN -> [SKIP][62] ([i915#1836])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@kms_prime@basic-crc@first-to-second.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
- shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#658]) +5 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#658]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][65] -> [SKIP][66] ([fdo#109441]) +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_vblank@pipe-d-wait-forked-hang:
- shard-apl: NOTRUN -> [SKIP][67] ([fdo#109271]) +218 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl3/igt@kms_vblank@pipe-d-wait-forked-hang.html
* igt@kms_writeback@writeback-fb-id:
- shard-skl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2437])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl7/igt@kms_writeback@writeback-fb-id.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#2437])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl1/igt@kms_writeback@writeback-pixel-formats.html
* igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
- shard-iclb: NOTRUN -> [SKIP][70] ([i915#2530])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html
* igt@nouveau_crc@pipe-d-source-outp-inactive:
- shard-iclb: NOTRUN -> [SKIP][71] ([fdo#109278] / [i915#2530])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@nouveau_crc@pipe-d-source-outp-inactive.html
* igt@prime_nv_api@i915_nv_import_vs_close:
- shard-tglb: NOTRUN -> [SKIP][72] ([fdo#109291])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-tglb2/igt@prime_nv_api@i915_nv_import_vs_close.html
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109291])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@prime_nv_api@i915_nv_import_vs_close.html
* igt@sysfs_clients@split-10:
- shard-iclb: NOTRUN -> [SKIP][74] ([i915#2994])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@sysfs_clients@split-10.html
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-skl: [INCOMPLETE][75] ([i915#198]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl9/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl7/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_eio@in-flight-10ms:
- shard-skl: [TIMEOUT][77] ([i915#2502]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl8/igt@gem_eio@in-flight-10ms.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl9/igt@gem_eio@in-flight-10ms.html
* igt@gem_eio@in-flight-contexts-10ms:
- shard-tglb: [TIMEOUT][79] ([i915#3063]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-tglb8/igt@gem_eio@in-flight-contexts-10ms.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-tglb8/igt@gem_eio@in-flight-contexts-10ms.html
* igt@gem_eio@in-flight-contexts-immediate:
- shard-skl: [TIMEOUT][81] ([i915#3063]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl2/igt@gem_eio@in-flight-contexts-immediate.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl7/igt@gem_eio@in-flight-contexts-immediate.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][83] ([i915#2842]) -> [PASS][84] +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb1/igt@gem_exec_fair@basic-none-share@rcs0.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [FAIL][85] ([i915#2842]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl2/igt@gem_exec_fair@basic-pace@vcs0.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [FAIL][87] ([i915#2842]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-tglb5/igt@gem_exec_fair@basic-pace@vecs0.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-tglb5/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_reloc@basic-many-active@vecs0:
- shard-apl: [FAIL][89] ([i915#2389]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-apl2/igt@gem_exec_reloc@basic-many-active@vecs0.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl7/igt@gem_exec_reloc@basic-many-active@vecs0.html
* igt@gem_exec_whisper@basic-queues-forked-all:
- shard-iclb: [INCOMPLETE][91] -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb4/igt@gem_exec_whisper@basic-queues-forked-all.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb4/igt@gem_exec_whisper@basic-queues-forked-all.html
* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-iclb: [FAIL][93] ([i915#2428]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb1/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb2/igt@gem_mmap_gtt@cpuset-big-copy-odd.html
* igt@gem_mmap_gtt@cpuset-medium-copy-odd:
- shard-iclb: [FAIL][95] ([i915#307]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb6/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb8/igt@gem_mmap_gtt@cpuset-medium-copy-odd.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- shard-skl: [DMESG-WARN][97] ([i915#1982]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-iclb: [FAIL][99] ([i915#2346]) -> [PASS][100] +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
- shard-glk: [FAIL][101] ([i915#2346]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: [FAIL][103] ([i915#2346] / [i915#533]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-glk5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-skl: [DMESG-FAIL][105] ([IGT#6]) -> [PASS][106] +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
- shard-kbl: [DMESG-FAIL][107] ([IGT#6]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl4/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl3/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- shard-apl: [DMESG-FAIL][109] ([IGT#6]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled:
- shard-glk: [FAIL][111] ([i915#52] / [i915#54]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-glk9/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-glk4/igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][113] ([i915#79]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank@b-edp1:
- shard-skl: [FAIL][115] ([i915#79]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl5/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl1/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][117] ([i915#180]) -> [PASS][118] +3 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][119] ([fdo#108145] / [i915#265]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][121] ([fdo#109441]) -> [PASS][122] +2 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb4/igt@kms_psr@psr2_no_drrs.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@prime_vgem@sync@rcs0:
- shard-tglb: [INCOMPLETE][123] ([i915#409]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-tglb2/igt@prime_vgem@sync@rcs0.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-tglb2/igt@prime_vgem@sync@rcs0.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][125] ([i915#1804] / [i915#2684]) -> [WARN][126] ([i915#2681] / [i915#2684])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb8/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][127] ([i915#2684]) -> [FAIL][128] ([i915#2680])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][129] ([i915#1226]) -> [SKIP][130] ([fdo#109349])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb1/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
- shard-iclb: [SKIP][131] ([i915#2920]) -> [SKIP][132] ([i915#658]) +2 similar issues
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb1/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][133] ([i915#658]) -> [SKIP][134] ([i915#2920]) +2 similar issues
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-iclb1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#602]) -> ([FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl4/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl2/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl3/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl7/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl3/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl3/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl3/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9895/shard-kbl4/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl4/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl2/igt@runner@aborted.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl3/igt@runner@aborted.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl4/igt@runner@aborted.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl3/igt@runner@aborted.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/shard-kbl2/igt@runner@aborted.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19851/index.html
[-- Attachment #1.2: Type: text/html, Size: 33950 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Stop adding planes to the commit needlessly
2021-03-25 11:37 ` Ville Syrjälä
@ 2021-03-29 9:01 ` Lisovskiy, Stanislav
0 siblings, 0 replies; 9+ messages in thread
From: Lisovskiy, Stanislav @ 2021-03-29 9:01 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Thu, Mar 25, 2021 at 01:37:31PM +0200, Ville Syrjälä wrote:
> On Thu, Mar 25, 2021 at 11:35:53AM +0200, Lisovskiy, Stanislav wrote:
> > On Thu, Mar 25, 2021 at 02:44:15AM +0200, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > The dbuf bandwidth calculations don't need the planes to be
> > > added to the state. Each plane's data rate has already been
> > > precalculated and stored in the crtc state, and that with
> > > the dbuf slice usage for each plane is all the dbuf bandwidth
> > > code needs to figure out what the minimum cdclk is.
> > >
> > > What we're trying to do here is make sure each plane recalculates
> > > its minimum cdclk (ie. plane->min_cdclk()) on those platforms where
> > > the number of active planes affects the result of said calculation.
> > > Nothing to do with any dbuf cdclk requirements.
> >
> > So does it mean that if we lets say had active plane mask as
> > 011(planes 0, 1 were active) and new active planes are 101(planes 0, 2
> > are active) - we should not add plane 2 to the state?
> > Because hamming weight will be obviously same, however I think it would
> > be wrong not have plane 2 in the state at all then..
> >
> > Or will it be added somewhere else?
>
> If someone is asking to disable plane 2 then it will be added to
> the state already during the atomic/setplance ioctl handling.
Ok, I thought intel_atomic_check_planes function is intended for checking
which planes had changed and need to be added to the state.
It is a bit non-obvious as we are adding them only when their amount changes,
but not themself.
Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
>
> >
> >
> > Stan
> >
> > >
> > > Not sure if we had stuff in slightly different order or what,
> > > but at least in the current scheme this is not necessary.
> > >
> > > Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_display.c | 10 ++--------
> > > 1 file changed, 2 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > > index 17490d29dc13..2300d58ba47f 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > > @@ -9811,7 +9811,7 @@ static bool active_planes_affects_min_cdclk(struct drm_i915_private *dev_priv)
> > > /* See {hsw,vlv,ivb}_plane_ratio() */
> > > return IS_BROADWELL(dev_priv) || IS_HASWELL(dev_priv) ||
> > > IS_CHERRYVIEW(dev_priv) || IS_VALLEYVIEW(dev_priv) ||
> > > - IS_IVYBRIDGE(dev_priv) || (DISPLAY_VER(dev_priv) >= 11);
> > > + IS_IVYBRIDGE(dev_priv);
> > > }
> > >
> > > static int intel_crtc_add_bigjoiner_planes(struct intel_atomic_state *state,
> > > @@ -9898,13 +9898,7 @@ static int intel_atomic_check_planes(struct intel_atomic_state *state)
> > > old_active_planes = old_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
> > > new_active_planes = new_crtc_state->active_planes & ~BIT(PLANE_CURSOR);
> > >
> > > - /*
> > > - * Not only the number of planes, but if the plane configuration had
> > > - * changed might already mean we need to recompute min CDCLK,
> > > - * because different planes might consume different amount of Dbuf bandwidth
> > > - * according to formula: Bw per plane = Pixel rate * bpp * pipe/plane scale factor
> > > - */
> > > - if (old_active_planes == new_active_planes)
> > > + if (hweight8(old_active_planes) == hweight8(new_active_planes))
> > > continue;
> > >
> > > ret = intel_crtc_add_planes_to_state(state, crtc, new_active_planes);
> > > --
> > > 2.26.2
> > >
>
> --
> Ville Syrjälä
> Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-03-29 8:58 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25 0:44 [Intel-gfx] [PATCH 1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level() Ville Syrjala
2021-03-25 0:44 ` [Intel-gfx] [PATCH 2/2] drm/i915: Stop adding planes to the commit needlessly Ville Syrjala
2021-03-25 9:35 ` Lisovskiy, Stanislav
2021-03-25 11:37 ` Ville Syrjälä
2021-03-29 9:01 ` Lisovskiy, Stanislav
2021-03-25 8:35 ` [Intel-gfx] [PATCH 1/2] drm/i915: Fix transposed arguments to skl_plane_wm_level() Lisovskiy, Stanislav
2021-03-25 19:03 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] " Patchwork
2021-03-25 19:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-26 0:14 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.