[bug report] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*

[bug report] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*

[Dan Carpenter]

Hello Fabio Aiuto,

The patch 65f183001f6e: "staging: rtl8723bs: remove unused code
blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*" from
Mar 16, 2021, leads to the following static checker warning:

	drivers/staging/rtl8723bs/core/rtw_ap.c:911 start_bss_network()
	warn: inconsistent indenting

drivers/staging/rtl8723bs/core/rtw_ap.c
   904                  rtw_get_capability((struct wlan_bssid_ex *)pnetwork)
   905          );
   906  
   907          if (pmlmeext->bstart_bss) {
   908                  update_beacon(padapter, WLAN_EID_TIM, NULL, true);
   909  
   910          /* issue beacon frame */

The patch accidentally deleted these extra tab for this block.

   911          if (send_beacon(padapter) == _FAIL)
   912                  DBG_871X("issue_beacon, fail!\n");
   913  
   914          }
   915  
   916          /* update bc/mc sta_info */
   917          update_bmc_sta(padapter);
   918  

regards,
dan carpenter

[PATCH] staging: rtl8723bs: fix indentation broken by previous patch

[Fabio Aiuto]

fix indentation broken by patch removing conditional
code blocks checked by unused
CONFIG_INTERRUPT_BASED_TXBCN family defines

https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 3cd9c61eec99..dc56477eb084 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -907,9 +907,9 @@ void start_bss_network(struct adapter *padapter, u8 *pbuf)
 	if (pmlmeext->bstart_bss) {
 		update_beacon(padapter, WLAN_EID_TIM, NULL, true);
 
-	/* issue beacon frame */
-	if (send_beacon(padapter) == _FAIL)
-		DBG_871X("issue_beacon, fail!\n");
+		/* issue beacon frame */
+		if (send_beacon(padapter) == _FAIL)
+			DBG_871X("issue_beacon, fail!\n");
 
 	}
 
-- 
2.20.1

Re: [bug report] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*

[Fabio Aiuto]

On Thu, Mar 25, 2021 at 11:56:40AM +0300, Dan Carpenter wrote:
> Hello Fabio Aiuto,
> 
> The patch 65f183001f6e: "staging: rtl8723bs: remove unused code
> blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*" from
> Mar 16, 2021, leads to the following static checker warning:
> 
> 	drivers/staging/rtl8723bs/core/rtw_ap.c:911 start_bss_network()
> 	warn: inconsistent indenting
> 
> drivers/staging/rtl8723bs/core/rtw_ap.c
>    904                  rtw_get_capability((struct wlan_bssid_ex *)pnetwork)
>    905          );
>    906  
>    907          if (pmlmeext->bstart_bss) {
>    908                  update_beacon(padapter, WLAN_EID_TIM, NULL, true);
>    909  
>    910          /* issue beacon frame */
> 
> The patch accidentally deleted these extra tab for this block.
> 
>    911          if (send_beacon(padapter) == _FAIL)
>    912                  DBG_871X("issue_beacon, fail!\n");
>    913  
>    914          }
>    915  
>    916          /* update bc/mc sta_info */
>    917          update_bmc_sta(padapter);
>    918  
> 
> regards,
> dan carpenter

Thank you Dan,

sent yesterday a fix,

sorry for late,

fabio

[PATCH] staging: rtl8723bs: fix indentation broken by previous patch

[Fabio Aiuto]

fix indentation broken by patch removing conditional
code blocks checked by unused
CONFIG_INTERRUPT_BASED_TXBCN family defines

https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com

Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 3cd9c61eec99..dc56477eb084 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -907,9 +907,9 @@ void start_bss_network(struct adapter *padapter, u8 *pbuf)
 	if (pmlmeext->bstart_bss) {
 		update_beacon(padapter, WLAN_EID_TIM, NULL, true);
 
-	/* issue beacon frame */
-	if (send_beacon(padapter) == _FAIL)
-		DBG_871X("issue_beacon, fail!\n");
+		/* issue beacon frame */
+		if (send_beacon(padapter) == _FAIL)
+			DBG_871X("issue_beacon, fail!\n");
 
 	}
 
-- 
2.20.1

Re: [bug report] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*

[Dan Carpenter]

On Fri, Mar 26, 2021 at 09:24:43AM +0100, Fabio Aiuto wrote:
> On Thu, Mar 25, 2021 at 11:56:40AM +0300, Dan Carpenter wrote:
> > Hello Fabio Aiuto,
> > 
> > The patch 65f183001f6e: "staging: rtl8723bs: remove unused code
> > blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*" from
> > Mar 16, 2021, leads to the following static checker warning:
> > 
> > 	drivers/staging/rtl8723bs/core/rtw_ap.c:911 start_bss_network()
> > 	warn: inconsistent indenting
> > 
> > drivers/staging/rtl8723bs/core/rtw_ap.c
> >    904                  rtw_get_capability((struct wlan_bssid_ex *)pnetwork)
> >    905          );
> >    906  
> >    907          if (pmlmeext->bstart_bss) {
> >    908                  update_beacon(padapter, WLAN_EID_TIM, NULL, true);
> >    909  
> >    910          /* issue beacon frame */
> > 
> > The patch accidentally deleted these extra tab for this block.
> > 
> >    911          if (send_beacon(padapter) == _FAIL)
> >    912                  DBG_871X("issue_beacon, fail!\n");
> >    913  
> >    914          }
> >    915  
> >    916          /* update bc/mc sta_info */
> >    917          update_bmc_sta(padapter);
> >    918  
> > 
> > regards,
> > dan carpenter
> 
> Thank you Dan,
> 
> sent yesterday a fix,
> 

Thanks!

regards,
dan carpenter

Re: [PATCH] staging: rtl8723bs: fix indentation broken by previous patch

[Greg KH]

On Fri, Mar 26, 2021 at 10:17:16AM +0100, Fabio Aiuto wrote:
> fix indentation broken by patch removing conditional
> code blocks checked by unused
> CONFIG_INTERRUPT_BASED_TXBCN family defines
> 
> https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com
> 
> Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>

"previous patch" is not very descriptive :(

Please put a "Fixes:" tag in here to point out exactly what commit this
fixed, and maybe a "Reported-by:" tag if someone pointed this out to
you...

thanks,

greg k-h

[PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*)

[Fabio Aiuto]

fix indentation broken by patch removing conditional
code blocks checked by unused
CONFIG_INTERRUPT_BASED_TXBCN family defines

https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 3cd9c61eec99..dc56477eb084 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -907,9 +907,9 @@ void start_bss_network(struct adapter *padapter, u8 *pbuf)
 	if (pmlmeext->bstart_bss) {
 		update_beacon(padapter, WLAN_EID_TIM, NULL, true);
 
-	/* issue beacon frame */
-	if (send_beacon(padapter) == _FAIL)
-		DBG_871X("issue_beacon, fail!\n");
+		/* issue beacon frame */
+		if (send_beacon(padapter) == _FAIL)
+			DBG_871X("issue_beacon, fail!\n");
 
 	}
 
-- 
2.20.1

Re: [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*)

[Greg KH]

On Fri, Mar 26, 2021 at 04:52:52PM +0100, Fabio Aiuto wrote:
> fix indentation broken by patch removing conditional
> code blocks checked by unused
> CONFIG_INTERRUPT_BASED_TXBCN family defines
> 
> https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com

No, please use a "Fixes:" tag that points to the git commit id that this
commit fixes.  Look in the kernel tree for loads of examples of how to
do this, and it's even documented in the Documentation/ process guide as
well.

thanks,

greg k-h

Re: [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*)

[Fabio Aiuto]

On Fri, Mar 26, 2021 at 05:20:40PM +0100, Greg KH wrote:
> On Fri, Mar 26, 2021 at 04:52:52PM +0100, Fabio Aiuto wrote:
> > fix indentation broken by patch removing conditional
> > code blocks checked by unused
> > CONFIG_INTERRUPT_BASED_TXBCN family defines
> > 
> > https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com
> 
> No, please use a "Fixes:" tag that points to the git commit id that this
> commit fixes.  Look in the kernel tree for loads of examples of how to
> do this, and it's even documented in the Documentation/ process guide as
> well.
> 
> thanks,
> 
> greg k-h

is what I did, as you can see in the subject. Or I did wrong?

thank you,

fabio

Re: [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*)

[Fabio Aiuto]

On Fri, Mar 26, 2021 at 06:43:28PM +0100, Fabio Aiuto wrote:
> On Fri, Mar 26, 2021 at 05:20:40PM +0100, Greg KH wrote:
> > On Fri, Mar 26, 2021 at 04:52:52PM +0100, Fabio Aiuto wrote:
> > > fix indentation broken by patch removing conditional
> > > code blocks checked by unused
> > > CONFIG_INTERRUPT_BASED_TXBCN family defines
> > > 
> > > https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiuto83@gmail.com
> > 
> > No, please use a "Fixes:" tag that points to the git commit id that this
> > commit fixes.  Look in the kernel tree for loads of examples of how to
> > do this, and it's even documented in the Documentation/ process guide as
> > well.
> > 
> > thanks,
> > 
> > greg k-h
> 
> is what I did, as you can see in the subject. Or I did wrong?
> 
> thank you,
> 
> fabio

forget this message :( I will send you the patch correctly formatted,
just seen some examples. I thought the 'Fixes: ...' was the one line
desc.

thank you

fabio

[PATCH] staging: rtl8723bs: fix broken indentation

[Fabio Aiuto]

fix indentation broken by patch removing conditional
code blocks checked by unused
CONFIG_INTERRUPT_BASED_TXBCN family defines

Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 3cd9c61eec99..dc56477eb084 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -907,9 +907,9 @@ void start_bss_network(struct adapter *padapter, u8 *pbuf)
 	if (pmlmeext->bstart_bss) {
 		update_beacon(padapter, WLAN_EID_TIM, NULL, true);
 
-	/* issue beacon frame */
-	if (send_beacon(padapter) == _FAIL)
-		DBG_871X("issue_beacon, fail!\n");
+		/* issue beacon frame */
+		if (send_beacon(padapter) == _FAIL)
+			DBG_871X("issue_beacon, fail!\n");
 
 	}
 
-- 
2.20.1