* [PATCH v1] soc/tegra: regulators: Fix locking up when voltage-spread is out of range
@ 2021-03-02 13:18 Dmitry Osipenko
2021-03-25 14:04 ` Thierry Reding
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Osipenko @ 2021-03-02 13:18 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter, Peter Geis, Matt Merhar
Cc: linux-tegra, linux-kernel
Fix voltage coupler lockup which happens when voltage-spread is out
of range due to a bug in the code. The max-spread requirement shall be
accounted when CPU regulator doesn't have consumers. This problem is
observed on Tegra30 Ouya game console once system-wide DVFS is enabled
in a device-tree.
Fixes: 783807436f36 ("soc/tegra: regulators: Add regulators coupler for Tegra30")
Cc: stable@vger.kernel.org
Reported-by: Peter Geis <pgwipeout@gmail.com>
Tested-by: Peter Geis <pgwipeout@gmail.com> # Ouya T30
Tested-by: Matt Merhar <mattmerhar@protonmail.com> # Ouya T30
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/soc/tegra/regulators-tegra30.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/tegra/regulators-tegra30.c b/drivers/soc/tegra/regulators-tegra30.c
index 7f21f31de09d..0e776b20f625 100644
--- a/drivers/soc/tegra/regulators-tegra30.c
+++ b/drivers/soc/tegra/regulators-tegra30.c
@@ -178,7 +178,7 @@ static int tegra30_voltage_update(struct tegra_regulator_coupler *tegra,
* survive the voltage drop if it's running on a higher frequency.
*/
if (!cpu_min_uV_consumers)
- cpu_min_uV = cpu_uV;
+ cpu_min_uV = max(cpu_uV, cpu_min_uV);
/*
* Bootloader shall set up voltages correctly, but if it
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] soc/tegra: regulators: Fix locking up when voltage-spread is out of range
2021-03-02 13:18 [PATCH v1] soc/tegra: regulators: Fix locking up when voltage-spread is out of range Dmitry Osipenko
@ 2021-03-25 14:04 ` Thierry Reding
0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2021-03-25 14:04 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Jonathan Hunter, Peter Geis, Matt Merhar, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
On Tue, Mar 02, 2021 at 04:18:00PM +0300, Dmitry Osipenko wrote:
> Fix voltage coupler lockup which happens when voltage-spread is out
> of range due to a bug in the code. The max-spread requirement shall be
> accounted when CPU regulator doesn't have consumers. This problem is
> observed on Tegra30 Ouya game console once system-wide DVFS is enabled
> in a device-tree.
>
> Fixes: 783807436f36 ("soc/tegra: regulators: Add regulators coupler for Tegra30")
> Cc: stable@vger.kernel.org
> Reported-by: Peter Geis <pgwipeout@gmail.com>
> Tested-by: Peter Geis <pgwipeout@gmail.com> # Ouya T30
> Tested-by: Matt Merhar <mattmerhar@protonmail.com> # Ouya T30
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/soc/tegra/regulators-tegra30.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-25 14:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-02 13:18 [PATCH v1] soc/tegra: regulators: Fix locking up when voltage-spread is out of range Dmitry Osipenko
2021-03-25 14:04 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.