From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: kernel test robot <lkp@intel.com> Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, kbuild-all@lists.01.org, Jens Axboe <axboe@kernel.dk> Subject: Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header Date: Wed, 7 Apr 2021 19:03:58 +0300 [thread overview] Message-ID: <YG3X7ogK/Oq2Hv4J@smile.fi.intel.com> (raw) In-Reply-To: <202104072325.Zv0JLqbH-lkp@intel.com> On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: > Hi Andy, > > I love your patch! Yet something to improve: > > [auto build test ERROR on block/for-next] > [also build test ERROR on v5.12-rc6 next-20210407] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 > base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next > config: x86_64-randconfig-s021-20210407 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce: > # apt-get install sparse > # sparse version: v0.6.3-279-g6d5d9b42-dirty > # https://github.com/0day-ci/linux/commit/d2574103b692b4fc73f1ed36ee9e4d3324902fd9 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 > git checkout d2574103b692b4fc73f1ed36ee9e4d3324902fd9 > # save the attached .config to linux build tree > make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): Thanks, we need to include bits.h. (It passed my simple build, but appears I have no such driver included) Jens, I saw your message, should I send a follow up fix, or a v2? > In file included from drivers/hwmon/drivetemp.c:98: > include/linux/ata.h: In function 'ata_id_has_ncq_send_and_recv': > >> include/linux/ata.h:929:40: error: implicit declaration of function 'BIT' [-Werror=implicit-function-declaration] > 929 | return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6); > | ^~~ > cc1: some warnings being treated as errors > > > vim +/BIT +929 include/linux/ata.h > > 4bca3286433585 Martin K. Petersen 2009-05-15 926 > ed36911c747c18 Marc Carino 2013-08-24 927 static inline bool ata_id_has_ncq_send_and_recv(const u16 *id) > ed36911c747c18 Marc Carino 2013-08-24 928 { > ed36911c747c18 Marc Carino 2013-08-24 @929 return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6); > ed36911c747c18 Marc Carino 2013-08-24 930 } > ed36911c747c18 Marc Carino 2013-08-24 931 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- With Best Regards, Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header Date: Wed, 07 Apr 2021 19:03:58 +0300 [thread overview] Message-ID: <YG3X7ogK/Oq2Hv4J@smile.fi.intel.com> (raw) In-Reply-To: <202104072325.Zv0JLqbH-lkp@intel.com> [-- Attachment #1: Type: text/plain, Size: 2807 bytes --] On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: > Hi Andy, > > I love your patch! Yet something to improve: > > [auto build test ERROR on block/for-next] > [also build test ERROR on v5.12-rc6 next-20210407] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 > base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next > config: x86_64-randconfig-s021-20210407 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce: > # apt-get install sparse > # sparse version: v0.6.3-279-g6d5d9b42-dirty > # https://github.com/0day-ci/linux/commit/d2574103b692b4fc73f1ed36ee9e4d3324902fd9 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 > git checkout d2574103b692b4fc73f1ed36ee9e4d3324902fd9 > # save the attached .config to linux build tree > make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@intel.com> > > All errors (new ones prefixed by >>): Thanks, we need to include bits.h. (It passed my simple build, but appears I have no such driver included) Jens, I saw your message, should I send a follow up fix, or a v2? > In file included from drivers/hwmon/drivetemp.c:98: > include/linux/ata.h: In function 'ata_id_has_ncq_send_and_recv': > >> include/linux/ata.h:929:40: error: implicit declaration of function 'BIT' [-Werror=implicit-function-declaration] > 929 | return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6); > | ^~~ > cc1: some warnings being treated as errors > > > vim +/BIT +929 include/linux/ata.h > > 4bca3286433585 Martin K. Petersen 2009-05-15 926 > ed36911c747c18 Marc Carino 2013-08-24 927 static inline bool ata_id_has_ncq_send_and_recv(const u16 *id) > ed36911c747c18 Marc Carino 2013-08-24 928 { > ed36911c747c18 Marc Carino 2013-08-24 @929 return id[ATA_ID_SATA_CAPABILITY_2] & BIT(6); > ed36911c747c18 Marc Carino 2013-08-24 930 } > ed36911c747c18 Marc Carino 2013-08-24 931 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -- With Best Regards, Andy Shevchenko
next prev parent reply other threads:[~2021-04-07 16:04 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-07 13:47 [PATCH v1 1/1] ata: Drop unneeded inclusion of kernel.h in the header Andy Shevchenko 2021-04-07 15:42 ` Jens Axboe 2021-04-07 15:51 ` kernel test robot 2021-04-07 15:51 ` kernel test robot 2021-04-07 16:03 ` Andy Shevchenko [this message] 2021-04-07 16:03 ` Andy Shevchenko 2021-04-07 16:04 ` Jens Axboe 2021-04-07 16:04 ` Jens Axboe 2021-04-07 16:27 ` Andy Shevchenko 2021-04-07 16:27 ` Andy Shevchenko 2021-04-07 16:43 ` Jens Axboe 2021-04-07 16:43 ` Jens Axboe 2021-04-07 17:10 ` Andy Shevchenko 2021-04-07 17:10 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YG3X7ogK/Oq2Hv4J@smile.fi.intel.com \ --to=andriy.shevchenko@linux.intel.com \ --cc=axboe@kernel.dk \ --cc=kbuild-all@lists.01.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lkp@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.