* [PATCH] gpio: sim: actually use the OF module table
@ 2021-03-30 10:21 Bartosz Golaszewski
2021-03-30 11:11 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2021-03-30 10:21 UTC (permalink / raw)
To: Linus Walleij, Andy Shevchenko
Cc: linux-gpio, Bartosz Golaszewski, kernel test robot
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
We don't assign the of_device_id table to the platform driver resulting
in the following build warning:
>> drivers/gpio/gpio-sim.c:388:34: warning: unused variable 'gpio_sim_of_match' [-Wunused-const-variable]
static const struct of_device_id gpio_sim_of_match[] = {
This fixes it.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/gpio/gpio-sim.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
index a1807f518837..ea17289a869c 100644
--- a/drivers/gpio/gpio-sim.c
+++ b/drivers/gpio/gpio-sim.c
@@ -394,6 +394,7 @@ MODULE_DEVICE_TABLE(of, gpio_sim_of_match);
static struct platform_driver gpio_sim_driver = {
.driver = {
.name = "gpio-sim",
+ .of_match_table = gpio_sim_of_match,
},
.probe = gpio_sim_probe,
};
--
2.30.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: sim: actually use the OF module table
2021-03-30 10:21 [PATCH] gpio: sim: actually use the OF module table Bartosz Golaszewski
@ 2021-03-30 11:11 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2021-03-30 11:11 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Linus Walleij, linux-gpio, Bartosz Golaszewski, kernel test robot
On Tue, Mar 30, 2021 at 12:21:10PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> We don't assign the of_device_id table to the platform driver resulting
> in the following build warning:
>
> >> drivers/gpio/gpio-sim.c:388:34: warning: unused variable 'gpio_sim_of_match' [-Wunused-const-variable]
> static const struct of_device_id gpio_sim_of_match[] = {
>
> This fixes it.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> drivers/gpio/gpio-sim.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index a1807f518837..ea17289a869c 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -394,6 +394,7 @@ MODULE_DEVICE_TABLE(of, gpio_sim_of_match);
> static struct platform_driver gpio_sim_driver = {
> .driver = {
> .name = "gpio-sim",
> + .of_match_table = gpio_sim_of_match,
> },
> .probe = gpio_sim_probe,
> };
> --
> 2.30.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-30 11:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-30 10:21 [PATCH] gpio: sim: actually use the OF module table Bartosz Golaszewski
2021-03-30 11:11 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.