All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf: util/mem-events.h: Remove unnecessary struct declaration
@ 2021-04-06 10:51 Wan Jiabing
  2021-04-06 16:33 ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-04-06 10:51 UTC (permalink / raw)
  To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
	Kan Liang, Leo Yan, Wan Jiabing, Ian Rogers, linux-kernel
  Cc: kael_w

struct mem_info is defined at 22nd line.
The declaration here is unnecessary. Remove it.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 tools/perf/util/mem-events.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
index 755cef7e0625..5ddbeaa057b0 100644
--- a/tools/perf/util/mem-events.h
+++ b/tools/perf/util/mem-events.h
@@ -44,7 +44,6 @@ bool is_mem_loads_aux_event(struct evsel *leader);
 
 void perf_mem_events__list(void);
 
-struct mem_info;
 int perf_mem__tlb_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
 int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
 int perf_mem__snp_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] perf: util/mem-events.h: Remove unnecessary struct declaration
  2021-04-06 10:51 [PATCH] perf: util/mem-events.h: Remove unnecessary struct declaration Wan Jiabing
@ 2021-04-06 16:33 ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-04-06 16:33 UTC (permalink / raw)
  To: Wan Jiabing
  Cc: Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin,
	Jiri Olsa, Namhyung Kim, Kan Liang, Leo Yan, Ian Rogers,
	linux-kernel, kael_w

Em Tue, Apr 06, 2021 at 06:51:02PM +0800, Wan Jiabing escreveu:
> struct mem_info is defined at 22nd line.
> The declaration here is unnecessary. Remove it.
 

Thanks, applied.

- Arnaldo

> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  tools/perf/util/mem-events.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
> index 755cef7e0625..5ddbeaa057b0 100644
> --- a/tools/perf/util/mem-events.h
> +++ b/tools/perf/util/mem-events.h
> @@ -44,7 +44,6 @@ bool is_mem_loads_aux_event(struct evsel *leader);
>  
>  void perf_mem_events__list(void);
>  
> -struct mem_info;
>  int perf_mem__tlb_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
>  int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
>  int perf_mem__snp_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
> -- 
> 2.25.1
> 

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-06 16:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 10:51 [PATCH] perf: util/mem-events.h: Remove unnecessary struct declaration Wan Jiabing
2021-04-06 16:33 ` Arnaldo Carvalho de Melo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.