* [PATCH for-rc] RDMA/cxgb4: check for ipv6 address properly while destroying listener
@ 2021-03-31 13:57 Potnuri Bharat Teja
2021-04-06 18:14 ` Potnuri Bharat Teja
2021-04-07 23:04 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Potnuri Bharat Teja @ 2021-03-31 13:57 UTC (permalink / raw)
To: jgg, dledford; +Cc: linux-rdma, bharat
ipv6 bit is wrongly set by commit '3408be145a5d' which causes fatal adapter
lookup engine errors for ipv4 connections while destroying listener.
Current patch properly checks the local address for ipv6 and fixes the
blunder introduced by commit '3408be145a5d'.
Fixes: 3408be145a5d ("RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server")
Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
---
drivers/infiniband/hw/cxgb4/cm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 81903749d241..e42c812e74c3 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -3616,7 +3616,8 @@ int c4iw_destroy_listen(struct iw_cm_id *cm_id)
c4iw_init_wr_wait(ep->com.wr_waitp);
err = cxgb4_remove_server(
ep->com.dev->rdev.lldi.ports[0], ep->stid,
- ep->com.dev->rdev.lldi.rxq_ids[0], true);
+ ep->com.dev->rdev.lldi.rxq_ids[0],
+ ep->com.local_addr.ss_family == AF_INET6);
if (err)
goto done;
err = c4iw_wait_for_reply(&ep->com.dev->rdev, ep->com.wr_waitp,
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH for-rc] RDMA/cxgb4: check for ipv6 address properly while destroying listener
2021-03-31 13:57 [PATCH for-rc] RDMA/cxgb4: check for ipv6 address properly while destroying listener Potnuri Bharat Teja
@ 2021-04-06 18:14 ` Potnuri Bharat Teja
2021-04-07 23:04 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Potnuri Bharat Teja @ 2021-04-06 18:14 UTC (permalink / raw)
To: jgg, dledford; +Cc: linux-rdma
On Wednesday, March 03/31/21, 2021 at 19:27:15 +0530, Potnuri Bharat Teja wrote:
> ipv6 bit is wrongly set by commit '3408be145a5d' which causes fatal adapter
> lookup engine errors for ipv4 connections while destroying listener.
> Current patch properly checks the local address for ipv6 and fixes the
> blunder introduced by commit '3408be145a5d'.
>
> Fixes: 3408be145a5d ("RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server")
> Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
Gentle reminder.
> ---
> drivers/infiniband/hw/cxgb4/cm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index 81903749d241..e42c812e74c3 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -3616,7 +3616,8 @@ int c4iw_destroy_listen(struct iw_cm_id *cm_id)
> c4iw_init_wr_wait(ep->com.wr_waitp);
> err = cxgb4_remove_server(
> ep->com.dev->rdev.lldi.ports[0], ep->stid,
> - ep->com.dev->rdev.lldi.rxq_ids[0], true);
> + ep->com.dev->rdev.lldi.rxq_ids[0],
> + ep->com.local_addr.ss_family == AF_INET6);
> if (err)
> goto done;
> err = c4iw_wait_for_reply(&ep->com.dev->rdev, ep->com.wr_waitp,
> --
> 2.24.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH for-rc] RDMA/cxgb4: check for ipv6 address properly while destroying listener
2021-03-31 13:57 [PATCH for-rc] RDMA/cxgb4: check for ipv6 address properly while destroying listener Potnuri Bharat Teja
2021-04-06 18:14 ` Potnuri Bharat Teja
@ 2021-04-07 23:04 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2021-04-07 23:04 UTC (permalink / raw)
To: Potnuri Bharat Teja; +Cc: dledford, linux-rdma
On Wed, Mar 31, 2021 at 07:27:15PM +0530, Potnuri Bharat Teja wrote:
> ipv6 bit is wrongly set by commit '3408be145a5d' which causes fatal adapter
> lookup engine errors for ipv4 connections while destroying listener.
> Current patch properly checks the local address for ipv6 and fixes the
> blunder introduced by commit '3408be145a5d'.
>
> Fixes: 3408be145a5d ("RDMA/cxgb4: Fix adapter LE hash errors while destroying ipv6 listening server")
> Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
> ---
> drivers/infiniband/hw/cxgb4/cm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to for-rc, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-07 23:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 13:57 [PATCH for-rc] RDMA/cxgb4: check for ipv6 address properly while destroying listener Potnuri Bharat Teja
2021-04-06 18:14 ` Potnuri Bharat Teja
2021-04-07 23:04 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.