* [LTP] [PATCH 1/1] zram01.sh: Skip tmpfs
@ 2021-04-20 6:17 Petr Vorel
2021-04-20 8:01 ` Li Wang
0 siblings, 1 reply; 4+ messages in thread
From: Petr Vorel @ 2021-04-20 6:17 UTC (permalink / raw)
To: ltp
This fixes error: mkfs.tmpfs: command not found
It does not make much sense to adapt test to tmpfs, thus skip it.
Fixes: 012fac904 ("zram: Move test specific functions out of zram_lib.sh")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/kernel/device-drivers/zram/zram01.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/testcases/kernel/device-drivers/zram/zram01.sh b/testcases/kernel/device-drivers/zram/zram01.sh
index 7de8b4b2a..ad9a9a2be 100755
--- a/testcases/kernel/device-drivers/zram/zram01.sh
+++ b/testcases/kernel/device-drivers/zram/zram01.sh
@@ -40,6 +40,7 @@ initialize_vars()
dev_num=0
for fs in $(tst_supported_fs); do
+ [ "$fs" = "tmpfs" ] && continue
size="26214400"
limit="25M"
if [ "$fs" = "btrfs" ]; then
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] zram01.sh: Skip tmpfs
2021-04-20 6:17 [LTP] [PATCH 1/1] zram01.sh: Skip tmpfs Petr Vorel
@ 2021-04-20 8:01 ` Li Wang
2021-04-20 8:20 ` Petr Vorel
2021-04-20 8:24 ` Petr Vorel
0 siblings, 2 replies; 4+ messages in thread
From: Li Wang @ 2021-04-20 8:01 UTC (permalink / raw)
To: ltp
Hi Petr,
This patch looks good.
Reviewed-by: Li Wang <liwang@redhat.com>
I am now thinking, does that make sense to add FS skiplist to
tst_test.sh just like we have done for C lib?
--
Regards,
Li Wang
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] zram01.sh: Skip tmpfs
2021-04-20 8:01 ` Li Wang
@ 2021-04-20 8:20 ` Petr Vorel
2021-04-20 8:24 ` Petr Vorel
1 sibling, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2021-04-20 8:20 UTC (permalink / raw)
To: ltp
Hi Li,
> Hi Petr,
> This patch looks good.
> Reviewed-by: Li Wang <liwang@redhat.com>
Thanks a lot, I'll merge it shortly.
> I am now thinking, does that make sense to add FS skiplist to
> tst_test.sh just like we have done for C lib?
Yes. I was planning to do that since it's needed by more tests.
But I'll merge this to get it fixed now.
Feel free to work on that (just let me know if you do).
Kind regards,
Petr
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] zram01.sh: Skip tmpfs
2021-04-20 8:01 ` Li Wang
2021-04-20 8:20 ` Petr Vorel
@ 2021-04-20 8:24 ` Petr Vorel
1 sibling, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2021-04-20 8:24 UTC (permalink / raw)
To: ltp
FYI merged.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-20 8:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 6:17 [LTP] [PATCH 1/1] zram01.sh: Skip tmpfs Petr Vorel
2021-04-20 8:01 ` Li Wang
2021-04-20 8:20 ` Petr Vorel
2021-04-20 8:24 ` Petr Vorel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.