* [Intel-gfx] [PATCH] drm/i915/selftests: Rename pm_ prefixed functions names
@ 2021-04-20 13:08 Jani Nikula
2021-04-20 13:19 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Jani Nikula @ 2021-04-20 13:08 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, Hsin-Yi Wang
From: Hsin-Yi Wang <hsinyi@chromium.org>
pm_resume and pm_suspend might be conflict with the ones defined in
include/linux/suspend.h. Rename all pm_* to igt_pm_* in selftests since
they are only used here.
v2 by Jani:
- Use igt_ prefix instead of i915_ to avoid colliding with existing
i915_pm_* functions
- Rename all pm_ prefixed functions in the file
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/selftests/i915_gem.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c
index dc394fb7ccfa..152d9ab135b1 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem.c
@@ -87,14 +87,14 @@ static void simulate_hibernate(struct drm_i915_private *i915)
intel_runtime_pm_put(&i915->runtime_pm, wakeref);
}
-static int pm_prepare(struct drm_i915_private *i915)
+static int igt_pm_prepare(struct drm_i915_private *i915)
{
i915_gem_suspend(i915);
return 0;
}
-static void pm_suspend(struct drm_i915_private *i915)
+static void igt_pm_suspend(struct drm_i915_private *i915)
{
intel_wakeref_t wakeref;
@@ -104,7 +104,7 @@ static void pm_suspend(struct drm_i915_private *i915)
}
}
-static void pm_hibernate(struct drm_i915_private *i915)
+static void igt_pm_hibernate(struct drm_i915_private *i915)
{
intel_wakeref_t wakeref;
@@ -116,7 +116,7 @@ static void pm_hibernate(struct drm_i915_private *i915)
}
}
-static void pm_resume(struct drm_i915_private *i915)
+static void igt_pm_resume(struct drm_i915_private *i915)
{
intel_wakeref_t wakeref;
@@ -148,16 +148,16 @@ static int igt_gem_suspend(void *arg)
if (err)
goto out;
- err = pm_prepare(i915);
+ err = igt_pm_prepare(i915);
if (err)
goto out;
- pm_suspend(i915);
+ igt_pm_suspend(i915);
/* Here be dragons! Note that with S3RST any S3 may become S4! */
simulate_hibernate(i915);
- pm_resume(i915);
+ igt_pm_resume(i915);
err = switch_to_context(ctx);
out:
@@ -183,16 +183,16 @@ static int igt_gem_hibernate(void *arg)
if (err)
goto out;
- err = pm_prepare(i915);
+ err = igt_pm_prepare(i915);
if (err)
goto out;
- pm_hibernate(i915);
+ igt_pm_hibernate(i915);
/* Here be dragons! */
simulate_hibernate(i915);
- pm_resume(i915);
+ igt_pm_resume(i915);
err = switch_to_context(ctx);
out:
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/selftests: Rename pm_ prefixed functions names 2021-04-20 13:08 [Intel-gfx] [PATCH] drm/i915/selftests: Rename pm_ prefixed functions names Jani Nikula @ 2021-04-20 13:19 ` Patchwork 2021-04-20 13:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2021-04-20 13:19 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx == Series Details == Series: drm/i915/selftests: Rename pm_ prefixed functions names URL : https://patchwork.freedesktop.org/series/89261/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'shadow_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'batch_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Rename pm_ prefixed functions names 2021-04-20 13:08 [Intel-gfx] [PATCH] drm/i915/selftests: Rename pm_ prefixed functions names Jani Nikula 2021-04-20 13:19 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork @ 2021-04-20 13:45 ` Patchwork 2021-04-20 13:49 ` [Intel-gfx] [PATCH] " Rodrigo Vivi 2021-04-20 15:05 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork 3 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2021-04-20 13:45 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 2299 bytes --] == Series Details == Series: drm/i915/selftests: Rename pm_ prefixed functions names URL : https://patchwork.freedesktop.org/series/89261/ State : success == Summary == CI Bug Log - changes from CI_DRM_9985 -> Patchwork_19955 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/index.html Known issues ------------ Here are the changes found in Patchwork_19955 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@semaphore: - fi-bdw-5557u: NOTRUN -> [SKIP][1] ([fdo#109271]) +23 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html * igt@core_hotunplug@unbind-rebind: - fi-bdw-5557u: NOTRUN -> [WARN][2] ([i915#2283]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s3: - fi-tgl-u2: [FAIL][3] ([i915#1888]) -> [PASS][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283 Participating hosts (42 -> 39) ------------------------------ Missing (3): fi-icl-y fi-bsw-cyan fi-bdw-samus Build changes ------------- * Linux: CI_DRM_9985 -> Patchwork_19955 CI-20190529: 20190529 CI_DRM_9985: cc92ce47fdeaf67b9a47c4a291b501d30ae5a79e @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6071: d293ad78a035dcf681345ca15e0256e0c3b1e7bb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19955: 363ea2dc92e8511e5b75c03b5aa721f630eb7e98 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 363ea2dc92e8 drm/i915/selftests: Rename pm_ prefixed functions names == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/index.html [-- Attachment #1.2: Type: text/html, Size: 2952 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Rename pm_ prefixed functions names 2021-04-20 13:08 [Intel-gfx] [PATCH] drm/i915/selftests: Rename pm_ prefixed functions names Jani Nikula 2021-04-20 13:19 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork 2021-04-20 13:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2021-04-20 13:49 ` Rodrigo Vivi 2021-04-20 14:41 ` Jani Nikula 2021-04-20 15:05 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork 3 siblings, 1 reply; 8+ messages in thread From: Rodrigo Vivi @ 2021-04-20 13:49 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx, Hsin-Yi Wang On Tue, Apr 20, 2021 at 04:08:53PM +0300, Jani Nikula wrote: > From: Hsin-Yi Wang <hsinyi@chromium.org> > > pm_resume and pm_suspend might be conflict with the ones defined in > include/linux/suspend.h. Rename all pm_* to igt_pm_* in selftests since > they are only used here. > > v2 by Jani: > - Use igt_ prefix instead of i915_ to avoid colliding with existing > i915_pm_* functions what about i915_st_pm?! > - Rename all pm_ prefixed functions in the file > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/selftests/i915_gem.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c > index dc394fb7ccfa..152d9ab135b1 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_gem.c > +++ b/drivers/gpu/drm/i915/selftests/i915_gem.c > @@ -87,14 +87,14 @@ static void simulate_hibernate(struct drm_i915_private *i915) > intel_runtime_pm_put(&i915->runtime_pm, wakeref); > } > > -static int pm_prepare(struct drm_i915_private *i915) > +static int igt_pm_prepare(struct drm_i915_private *i915) > { > i915_gem_suspend(i915); > > return 0; > } > > -static void pm_suspend(struct drm_i915_private *i915) > +static void igt_pm_suspend(struct drm_i915_private *i915) > { > intel_wakeref_t wakeref; > > @@ -104,7 +104,7 @@ static void pm_suspend(struct drm_i915_private *i915) > } > } > > -static void pm_hibernate(struct drm_i915_private *i915) > +static void igt_pm_hibernate(struct drm_i915_private *i915) > { > intel_wakeref_t wakeref; > > @@ -116,7 +116,7 @@ static void pm_hibernate(struct drm_i915_private *i915) > } > } > > -static void pm_resume(struct drm_i915_private *i915) > +static void igt_pm_resume(struct drm_i915_private *i915) > { > intel_wakeref_t wakeref; > > @@ -148,16 +148,16 @@ static int igt_gem_suspend(void *arg) > if (err) > goto out; > > - err = pm_prepare(i915); > + err = igt_pm_prepare(i915); > if (err) > goto out; > > - pm_suspend(i915); > + igt_pm_suspend(i915); > > /* Here be dragons! Note that with S3RST any S3 may become S4! */ > simulate_hibernate(i915); > > - pm_resume(i915); > + igt_pm_resume(i915); > > err = switch_to_context(ctx); > out: > @@ -183,16 +183,16 @@ static int igt_gem_hibernate(void *arg) > if (err) > goto out; > > - err = pm_prepare(i915); > + err = igt_pm_prepare(i915); > if (err) > goto out; > > - pm_hibernate(i915); > + igt_pm_hibernate(i915); > > /* Here be dragons! */ > simulate_hibernate(i915); > > - pm_resume(i915); > + igt_pm_resume(i915); > > err = switch_to_context(ctx); > out: > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Rename pm_ prefixed functions names 2021-04-20 13:49 ` [Intel-gfx] [PATCH] " Rodrigo Vivi @ 2021-04-20 14:41 ` Jani Nikula 2021-04-20 14:52 ` Rodrigo Vivi 0 siblings, 1 reply; 8+ messages in thread From: Jani Nikula @ 2021-04-20 14:41 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx, Hsin-Yi Wang On Tue, 20 Apr 2021, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > On Tue, Apr 20, 2021 at 04:08:53PM +0300, Jani Nikula wrote: >> From: Hsin-Yi Wang <hsinyi@chromium.org> >> >> pm_resume and pm_suspend might be conflict with the ones defined in >> include/linux/suspend.h. Rename all pm_* to igt_pm_* in selftests since >> they are only used here. >> >> v2 by Jani: >> - Use igt_ prefix instead of i915_ to avoid colliding with existing >> i915_pm_* functions > > what about i915_st_pm?! Honestly I don't really care, as long as they don't conflict with what's in suspend.h or i915_drv.c. They are called from functions named igt_gem_suspend() and igt_gem_hibernate(), so I went with igt_. *shrug* BR, Jani. > >> - Rename all pm_ prefixed functions in the file >> >> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> >> Reported-by: kernel test robot <lkp@intel.com> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> --- >> drivers/gpu/drm/i915/selftests/i915_gem.c | 20 ++++++++++---------- >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c >> index dc394fb7ccfa..152d9ab135b1 100644 >> --- a/drivers/gpu/drm/i915/selftests/i915_gem.c >> +++ b/drivers/gpu/drm/i915/selftests/i915_gem.c >> @@ -87,14 +87,14 @@ static void simulate_hibernate(struct drm_i915_private *i915) >> intel_runtime_pm_put(&i915->runtime_pm, wakeref); >> } >> >> -static int pm_prepare(struct drm_i915_private *i915) >> +static int igt_pm_prepare(struct drm_i915_private *i915) >> { >> i915_gem_suspend(i915); >> >> return 0; >> } >> >> -static void pm_suspend(struct drm_i915_private *i915) >> +static void igt_pm_suspend(struct drm_i915_private *i915) >> { >> intel_wakeref_t wakeref; >> >> @@ -104,7 +104,7 @@ static void pm_suspend(struct drm_i915_private *i915) >> } >> } >> >> -static void pm_hibernate(struct drm_i915_private *i915) >> +static void igt_pm_hibernate(struct drm_i915_private *i915) >> { >> intel_wakeref_t wakeref; >> >> @@ -116,7 +116,7 @@ static void pm_hibernate(struct drm_i915_private *i915) >> } >> } >> >> -static void pm_resume(struct drm_i915_private *i915) >> +static void igt_pm_resume(struct drm_i915_private *i915) >> { >> intel_wakeref_t wakeref; >> >> @@ -148,16 +148,16 @@ static int igt_gem_suspend(void *arg) >> if (err) >> goto out; >> >> - err = pm_prepare(i915); >> + err = igt_pm_prepare(i915); >> if (err) >> goto out; >> >> - pm_suspend(i915); >> + igt_pm_suspend(i915); >> >> /* Here be dragons! Note that with S3RST any S3 may become S4! */ >> simulate_hibernate(i915); >> >> - pm_resume(i915); >> + igt_pm_resume(i915); >> >> err = switch_to_context(ctx); >> out: >> @@ -183,16 +183,16 @@ static int igt_gem_hibernate(void *arg) >> if (err) >> goto out; >> >> - err = pm_prepare(i915); >> + err = igt_pm_prepare(i915); >> if (err) >> goto out; >> >> - pm_hibernate(i915); >> + igt_pm_hibernate(i915); >> >> /* Here be dragons! */ >> simulate_hibernate(i915); >> >> - pm_resume(i915); >> + igt_pm_resume(i915); >> >> err = switch_to_context(ctx); >> out: >> -- >> 2.20.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Rename pm_ prefixed functions names 2021-04-20 14:41 ` Jani Nikula @ 2021-04-20 14:52 ` Rodrigo Vivi 2021-04-21 8:20 ` Jani Nikula 0 siblings, 1 reply; 8+ messages in thread From: Rodrigo Vivi @ 2021-04-20 14:52 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx, Hsin-Yi Wang On Tue, Apr 20, 2021 at 05:41:47PM +0300, Jani Nikula wrote: > On Tue, 20 Apr 2021, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > > On Tue, Apr 20, 2021 at 04:08:53PM +0300, Jani Nikula wrote: > >> From: Hsin-Yi Wang <hsinyi@chromium.org> > >> > >> pm_resume and pm_suspend might be conflict with the ones defined in > >> include/linux/suspend.h. Rename all pm_* to igt_pm_* in selftests since > >> they are only used here. > >> > >> v2 by Jani: > >> - Use igt_ prefix instead of i915_ to avoid colliding with existing > >> i915_pm_* functions > > > > what about i915_st_pm?! > > Honestly I don't really care, as long as they don't conflict with what's > in suspend.h or i915_drv.c. > > They are called from functions named igt_gem_suspend() and > igt_gem_hibernate(), so I went with igt_. *shrug* oh... there was the precedence indeed... let's go with this for now at least... maybe an overal sed later.. Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > BR, > Jani. > > > > > >> - Rename all pm_ prefixed functions in the file > >> > >> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > >> Reported-by: kernel test robot <lkp@intel.com> > >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > >> --- > >> drivers/gpu/drm/i915/selftests/i915_gem.c | 20 ++++++++++---------- > >> 1 file changed, 10 insertions(+), 10 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c > >> index dc394fb7ccfa..152d9ab135b1 100644 > >> --- a/drivers/gpu/drm/i915/selftests/i915_gem.c > >> +++ b/drivers/gpu/drm/i915/selftests/i915_gem.c > >> @@ -87,14 +87,14 @@ static void simulate_hibernate(struct drm_i915_private *i915) > >> intel_runtime_pm_put(&i915->runtime_pm, wakeref); > >> } > >> > >> -static int pm_prepare(struct drm_i915_private *i915) > >> +static int igt_pm_prepare(struct drm_i915_private *i915) > >> { > >> i915_gem_suspend(i915); > >> > >> return 0; > >> } > >> > >> -static void pm_suspend(struct drm_i915_private *i915) > >> +static void igt_pm_suspend(struct drm_i915_private *i915) > >> { > >> intel_wakeref_t wakeref; > >> > >> @@ -104,7 +104,7 @@ static void pm_suspend(struct drm_i915_private *i915) > >> } > >> } > >> > >> -static void pm_hibernate(struct drm_i915_private *i915) > >> +static void igt_pm_hibernate(struct drm_i915_private *i915) > >> { > >> intel_wakeref_t wakeref; > >> > >> @@ -116,7 +116,7 @@ static void pm_hibernate(struct drm_i915_private *i915) > >> } > >> } > >> > >> -static void pm_resume(struct drm_i915_private *i915) > >> +static void igt_pm_resume(struct drm_i915_private *i915) > >> { > >> intel_wakeref_t wakeref; > >> > >> @@ -148,16 +148,16 @@ static int igt_gem_suspend(void *arg) > >> if (err) > >> goto out; > >> > >> - err = pm_prepare(i915); > >> + err = igt_pm_prepare(i915); > >> if (err) > >> goto out; > >> > >> - pm_suspend(i915); > >> + igt_pm_suspend(i915); > >> > >> /* Here be dragons! Note that with S3RST any S3 may become S4! */ > >> simulate_hibernate(i915); > >> > >> - pm_resume(i915); > >> + igt_pm_resume(i915); > >> > >> err = switch_to_context(ctx); > >> out: > >> @@ -183,16 +183,16 @@ static int igt_gem_hibernate(void *arg) > >> if (err) > >> goto out; > >> > >> - err = pm_prepare(i915); > >> + err = igt_pm_prepare(i915); > >> if (err) > >> goto out; > >> > >> - pm_hibernate(i915); > >> + igt_pm_hibernate(i915); > >> > >> /* Here be dragons! */ > >> simulate_hibernate(i915); > >> > >> - pm_resume(i915); > >> + igt_pm_resume(i915); > >> > >> err = switch_to_context(ctx); > >> out: > >> -- > >> 2.20.1 > >> > >> _______________________________________________ > >> Intel-gfx mailing list > >> Intel-gfx@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > -- > Jani Nikula, Intel Open Source Graphics Center > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Rename pm_ prefixed functions names 2021-04-20 14:52 ` Rodrigo Vivi @ 2021-04-21 8:20 ` Jani Nikula 0 siblings, 0 replies; 8+ messages in thread From: Jani Nikula @ 2021-04-21 8:20 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx, Hsin-Yi Wang On Tue, 20 Apr 2021, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: > On Tue, Apr 20, 2021 at 05:41:47PM +0300, Jani Nikula wrote: >> On Tue, 20 Apr 2021, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote: >> > On Tue, Apr 20, 2021 at 04:08:53PM +0300, Jani Nikula wrote: >> >> From: Hsin-Yi Wang <hsinyi@chromium.org> >> >> >> >> pm_resume and pm_suspend might be conflict with the ones defined in >> >> include/linux/suspend.h. Rename all pm_* to igt_pm_* in selftests since >> >> they are only used here. >> >> >> >> v2 by Jani: >> >> - Use igt_ prefix instead of i915_ to avoid colliding with existing >> >> i915_pm_* functions >> > >> > what about i915_st_pm?! >> >> Honestly I don't really care, as long as they don't conflict with what's >> in suspend.h or i915_drv.c. >> >> They are called from functions named igt_gem_suspend() and >> igt_gem_hibernate(), so I went with igt_. *shrug* > > oh... there was the precedence indeed... > let's go with this for now at least... maybe an overal sed later.. > > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Thanks, pushed. BR, Jani. > > >> >> >> BR, >> Jani. >> >> >> > >> >> - Rename all pm_ prefixed functions in the file >> >> >> >> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> >> >> Reported-by: kernel test robot <lkp@intel.com> >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> >> >> --- >> >> drivers/gpu/drm/i915/selftests/i915_gem.c | 20 ++++++++++---------- >> >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> >> >> diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c >> >> index dc394fb7ccfa..152d9ab135b1 100644 >> >> --- a/drivers/gpu/drm/i915/selftests/i915_gem.c >> >> +++ b/drivers/gpu/drm/i915/selftests/i915_gem.c >> >> @@ -87,14 +87,14 @@ static void simulate_hibernate(struct drm_i915_private *i915) >> >> intel_runtime_pm_put(&i915->runtime_pm, wakeref); >> >> } >> >> >> >> -static int pm_prepare(struct drm_i915_private *i915) >> >> +static int igt_pm_prepare(struct drm_i915_private *i915) >> >> { >> >> i915_gem_suspend(i915); >> >> >> >> return 0; >> >> } >> >> >> >> -static void pm_suspend(struct drm_i915_private *i915) >> >> +static void igt_pm_suspend(struct drm_i915_private *i915) >> >> { >> >> intel_wakeref_t wakeref; >> >> >> >> @@ -104,7 +104,7 @@ static void pm_suspend(struct drm_i915_private *i915) >> >> } >> >> } >> >> >> >> -static void pm_hibernate(struct drm_i915_private *i915) >> >> +static void igt_pm_hibernate(struct drm_i915_private *i915) >> >> { >> >> intel_wakeref_t wakeref; >> >> >> >> @@ -116,7 +116,7 @@ static void pm_hibernate(struct drm_i915_private *i915) >> >> } >> >> } >> >> >> >> -static void pm_resume(struct drm_i915_private *i915) >> >> +static void igt_pm_resume(struct drm_i915_private *i915) >> >> { >> >> intel_wakeref_t wakeref; >> >> >> >> @@ -148,16 +148,16 @@ static int igt_gem_suspend(void *arg) >> >> if (err) >> >> goto out; >> >> >> >> - err = pm_prepare(i915); >> >> + err = igt_pm_prepare(i915); >> >> if (err) >> >> goto out; >> >> >> >> - pm_suspend(i915); >> >> + igt_pm_suspend(i915); >> >> >> >> /* Here be dragons! Note that with S3RST any S3 may become S4! */ >> >> simulate_hibernate(i915); >> >> >> >> - pm_resume(i915); >> >> + igt_pm_resume(i915); >> >> >> >> err = switch_to_context(ctx); >> >> out: >> >> @@ -183,16 +183,16 @@ static int igt_gem_hibernate(void *arg) >> >> if (err) >> >> goto out; >> >> >> >> - err = pm_prepare(i915); >> >> + err = igt_pm_prepare(i915); >> >> if (err) >> >> goto out; >> >> >> >> - pm_hibernate(i915); >> >> + igt_pm_hibernate(i915); >> >> >> >> /* Here be dragons! */ >> >> simulate_hibernate(i915); >> >> >> >> - pm_resume(i915); >> >> + igt_pm_resume(i915); >> >> >> >> err = switch_to_context(ctx); >> >> out: >> >> -- >> >> 2.20.1 >> >> >> >> _______________________________________________ >> >> Intel-gfx mailing list >> >> Intel-gfx@lists.freedesktop.org >> >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx >> >> -- >> Jani Nikula, Intel Open Source Graphics Center >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Rename pm_ prefixed functions names 2021-04-20 13:08 [Intel-gfx] [PATCH] drm/i915/selftests: Rename pm_ prefixed functions names Jani Nikula ` (2 preceding siblings ...) 2021-04-20 13:49 ` [Intel-gfx] [PATCH] " Rodrigo Vivi @ 2021-04-20 15:05 ` Patchwork 3 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2021-04-20 15:05 UTC (permalink / raw) To: Jani Nikula; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30278 bytes --] == Series Details == Series: drm/i915/selftests: Rename pm_ prefixed functions names URL : https://patchwork.freedesktop.org/series/89261/ State : success == Summary == CI Bug Log - changes from CI_DRM_9985_full -> Patchwork_19955_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_19955_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_create@create-massive: - shard-snb: NOTRUN -> [DMESG-WARN][1] ([i915#3002]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-snb6/igt@gem_create@create-massive.html - shard-skl: NOTRUN -> [DMESG-WARN][2] ([i915#3002]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl1/igt@gem_create@create-massive.html * igt@gem_ctx_persistence@smoketest: - shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +3 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-snb6/igt@gem_ctx_persistence@smoketest.html * igt@gem_ctx_sseu@invalid-args: - shard-apl: NOTRUN -> [SKIP][4] ([fdo#109271]) +165 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl1/igt@gem_ctx_sseu@invalid-args.html * igt@gem_eio@in-flight-suspend: - shard-kbl: NOTRUN -> [DMESG-WARN][5] ([i915#180]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl3/igt@gem_eio@in-flight-suspend.html * igt@gem_exec_fair@basic-deadline: - shard-apl: NOTRUN -> [FAIL][6] ([i915#2846]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl2/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-tglb5/igt@gem_exec_fair@basic-pace@rcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-tglb7/igt@gem_exec_fair@basic-pace@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-iclb: [PASS][9] -> [FAIL][10] ([i915#2842]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-iclb7/igt@gem_exec_fair@basic-pace@vcs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_whisper@basic-contexts-all: - shard-glk: [PASS][11] -> [DMESG-WARN][12] ([i915#118] / [i915#95]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-glk6/igt@gem_exec_whisper@basic-contexts-all.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-glk6/igt@gem_exec_whisper@basic-contexts-all.html * igt@gem_huc_copy@huc-copy: - shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#2190]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl2/igt@gem_huc_copy@huc-copy.html * igt@gem_pread@exhaustion: - shard-skl: NOTRUN -> [WARN][14] ([i915#2658]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl4/igt@gem_pread@exhaustion.html * igt@gem_pwrite@basic-exhaustion: - shard-apl: NOTRUN -> [WARN][15] ([i915#2658]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl1/igt@gem_pwrite@basic-exhaustion.html * igt@gem_spin_batch@engines@rcs0: - shard-apl: NOTRUN -> [FAIL][16] ([i915#2898]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl2/igt@gem_spin_batch@engines@rcs0.html * igt@gem_userptr_blits@access-control: - shard-tglb: NOTRUN -> [SKIP][17] ([i915#3297]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-tglb7/igt@gem_userptr_blits@access-control.html * igt@gem_vm_create@destroy-race: - shard-tglb: [PASS][18] -> [FAIL][19] ([i915#2822]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-tglb3/igt@gem_vm_create@destroy-race.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-tglb7/igt@gem_vm_create@destroy-race.html * igt@gem_workarounds@suspend-resume-fd: - shard-kbl: [PASS][20] -> [DMESG-WARN][21] ([i915#180]) +2 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-kbl2/igt@gem_workarounds@suspend-resume-fd.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl7/igt@gem_workarounds@suspend-resume-fd.html * igt@gen9_exec_parse@bb-large: - shard-apl: NOTRUN -> [FAIL][22] ([i915#3296]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl2/igt@gen9_exec_parse@bb-large.html * igt@i915_selftest@live@gt_pm: - shard-skl: NOTRUN -> [DMESG-FAIL][23] ([i915#1886] / [i915#2291]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl4/igt@i915_selftest@live@gt_pm.html * igt@i915_suspend@fence-restore-untiled: - shard-apl: [PASS][24] -> [DMESG-WARN][25] ([i915#180]) +2 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-apl3/igt@i915_suspend@fence-restore-untiled.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl1/igt@i915_suspend@fence-restore-untiled.html * igt@kms_async_flips@test-time-stamp: - shard-tglb: [PASS][26] -> [FAIL][27] ([i915#2574]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-tglb7/igt@kms_async_flips@test-time-stamp.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-tglb5/igt@kms_async_flips@test-time-stamp.html * igt@kms_ccs@pipe-b-bad-aux-stride: - shard-snb: NOTRUN -> [SKIP][28] ([fdo#109271]) +352 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-snb2/igt@kms_ccs@pipe-b-bad-aux-stride.html * igt@kms_chamelium@hdmi-hpd-for-each-pipe: - shard-kbl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +5 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl3/igt@kms_chamelium@hdmi-hpd-for-each-pipe.html * igt@kms_color@pipe-a-ctm-0-25: - shard-skl: [PASS][30] -> [DMESG-WARN][31] ([i915#1982]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-skl7/igt@kms_color@pipe-a-ctm-0-25.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl10/igt@kms_color@pipe-a-ctm-0-25.html * igt@kms_color@pipe-b-degamma: - shard-tglb: NOTRUN -> [FAIL][32] ([i915#1149]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-tglb7/igt@kms_color@pipe-b-degamma.html * igt@kms_color_chamelium@pipe-c-ctm-0-5: - shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [fdo#111827]) +14 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl1/igt@kms_color_chamelium@pipe-c-ctm-0-5.html * igt@kms_color_chamelium@pipe-d-ctm-0-75: - shard-skl: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +10 similar issues [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl1/igt@kms_color_chamelium@pipe-d-ctm-0-75.html * igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes: - shard-snb: NOTRUN -> [SKIP][35] ([fdo#109271] / [fdo#111827]) +17 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-snb2/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html * igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes: - shard-tglb: NOTRUN -> [SKIP][36] ([fdo#109284] / [fdo#111827]) +3 similar issues [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-tglb7/igt@kms_color_chamelium@pipe-invalid-degamma-lut-sizes.html * igt@kms_content_protection@lic: - shard-tglb: NOTRUN -> [SKIP][37] ([fdo#111828]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-tglb7/igt@kms_content_protection@lic.html - shard-kbl: NOTRUN -> [TIMEOUT][38] ([i915#1319]) [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl4/igt@kms_content_protection@lic.html * igt@kms_content_protection@srm: - shard-apl: NOTRUN -> [TIMEOUT][39] ([i915#1319]) +1 similar issue [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl1/igt@kms_content_protection@srm.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-apl: NOTRUN -> [DMESG-WARN][40] ([i915#180]) [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl8/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen: - shard-skl: NOTRUN -> [FAIL][41] ([i915#54]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html * igt@kms_cursor_crc@pipe-c-cursor-32x10-rapid-movement: - shard-tglb: NOTRUN -> [SKIP][42] ([i915#3359]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-tglb7/igt@kms_cursor_crc@pipe-c-cursor-32x10-rapid-movement.html * igt@kms_cursor_legacy@cursorb-vs-flipb-atomic: - shard-tglb: NOTRUN -> [SKIP][43] ([fdo#111825]) +6 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-tglb7/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic.html * igt@kms_cursor_legacy@pipe-d-torture-bo: - shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#533]) +1 similar issue [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl1/igt@kms_cursor_legacy@pipe-d-torture-bo.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1: - shard-skl: [PASS][45] -> [FAIL][46] ([i915#79]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html * igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1: - shard-skl: [PASS][47] -> [FAIL][48] ([i915#2122]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-skl9/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl9/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs: - shard-skl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#2672]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl4/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html * igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt: - shard-skl: NOTRUN -> [SKIP][50] ([fdo#109271]) +140 similar issues [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl4/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt: - shard-kbl: NOTRUN -> [SKIP][51] ([fdo#109271]) +91 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl4/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt.html * igt@kms_hdr@static-toggle-dpms: - shard-tglb: NOTRUN -> [SKIP][52] ([i915#1187]) [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-tglb7/igt@kms_hdr@static-toggle-dpms.html * igt@kms_pipe_crc_basic@read-crc-pipe-d: - shard-skl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#533]) +1 similar issue [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl4/igt@kms_pipe_crc_basic@read-crc-pipe-d.html * igt@kms_plane@plane-position-hole-dpms-pipe-a-planes: - shard-iclb: [PASS][54] -> [FAIL][55] ([i915#2472]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-iclb4/igt@kms_plane@plane-position-hole-dpms-pipe-a-planes.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-iclb3/igt@kms_plane@plane-position-hole-dpms-pipe-a-planes.html * igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb: - shard-kbl: NOTRUN -> [FAIL][56] ([fdo#108145] / [i915#265]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl2/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb: - shard-apl: NOTRUN -> [FAIL][57] ([i915#265]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl1/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html * igt@kms_plane_alpha_blend@pipe-c-alpha-7efc: - shard-apl: NOTRUN -> [FAIL][58] ([fdo#108145] / [i915#265]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-7efc.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: NOTRUN -> [FAIL][59] ([fdo#108145] / [i915#265]) +2 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2: - shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#658]) +2 similar issues [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3: - shard-kbl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#658]) +1 similar issue [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html - shard-skl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#658]) +3 similar issues [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl4/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][63] -> [SKIP][64] ([fdo#109441]) +2 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html * igt@kms_setmode@basic: - shard-snb: NOTRUN -> [FAIL][65] ([i915#31]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-snb7/igt@kms_setmode@basic.html * igt@kms_vblank@pipe-c-accuracy-idle: - shard-glk: [PASS][66] -> [FAIL][67] ([i915#43]) [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-glk9/igt@kms_vblank@pipe-c-accuracy-idle.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-glk2/igt@kms_vblank@pipe-c-accuracy-idle.html * igt@kms_writeback@writeback-invalid-parameters: - shard-skl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#2437]) +1 similar issue [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl8/igt@kms_writeback@writeback-invalid-parameters.html * igt@perf@unprivileged-single-ctx-counters: - shard-tglb: NOTRUN -> [SKIP][69] ([fdo#109289]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-tglb7/igt@perf@unprivileged-single-ctx-counters.html * igt@sysfs_clients@recycle-many: - shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#2994]) +2 similar issues [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl7/igt@sysfs_clients@recycle-many.html #### Possible fixes #### * igt@gem_exec_fair@basic-deadline: - shard-glk: [FAIL][71] ([i915#2846]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-glk8/igt@gem_exec_fair@basic-deadline.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-glk3/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [FAIL][73] ([i915#2842]) -> [PASS][74] +2 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-tglb1/igt@gem_exec_fair@basic-flow@rcs0.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-tglb6/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-kbl: [SKIP][75] ([fdo#109271]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs1.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_fair@basic-pace@vecs0: - shard-kbl: [FAIL][77] ([i915#2842]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-kbl3/igt@gem_exec_fair@basic-pace@vecs0.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl4/igt@gem_exec_fair@basic-pace@vecs0.html * igt@gen9_exec_parse@allowed-single: - shard-skl: [DMESG-WARN][79] ([i915#1436] / [i915#716]) -> [PASS][80] [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-skl7/igt@gen9_exec_parse@allowed-single.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl8/igt@gen9_exec_parse@allowed-single.html * igt@i915_module_load@reload-with-fault-injection: - shard-snb: [INCOMPLETE][81] ([i915#2880]) -> [PASS][82] [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-snb5/igt@i915_module_load@reload-with-fault-injection.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-snb7/igt@i915_module_load@reload-with-fault-injection.html * igt@kms_color@pipe-c-ctm-0-25: - shard-skl: [DMESG-WARN][83] ([i915#1982]) -> [PASS][84] +1 similar issue [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-skl6/igt@kms_color@pipe-c-ctm-0-25.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl6/igt@kms_color@pipe-c-ctm-0-25.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-apl: [DMESG-WARN][85] ([i915#180]) -> [PASS][86] [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl8/igt@kms_cursor_crc@pipe-b-cursor-suspend.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-skl: [FAIL][87] ([i915#2346] / [i915#533]) -> [PASS][88] [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@flip-vs-cursor-legacy: - shard-skl: [FAIL][89] ([i915#2346]) -> [PASS][90] [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html * igt@kms_frontbuffer_tracking@psr-suspend: - shard-tglb: [INCOMPLETE][91] ([i915#2411] / [i915#456]) -> [PASS][92] [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-tglb5/igt@kms_frontbuffer_tracking@psr-suspend.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-tglb7/igt@kms_frontbuffer_tracking@psr-suspend.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [FAIL][93] ([i915#1188]) -> [PASS][94] [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-skl6/igt@kms_hdr@bpc-switch-dpms.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes: - shard-kbl: [DMESG-WARN][95] ([i915#180] / [i915#533]) -> [PASS][96] [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-apl: [FAIL][97] ([fdo#108145] / [i915#265]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-apl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html * igt@kms_psr@psr2_dpms: - shard-iclb: [SKIP][99] ([fdo#109441]) -> [PASS][100] [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-iclb7/igt@kms_psr@psr2_dpms.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-iclb2/igt@kms_psr@psr2_dpms.html * igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend: - shard-skl: [INCOMPLETE][101] ([i915#198]) -> [PASS][102] [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-skl7/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl4/igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend.html * igt@kms_vblank@pipe-b-ts-continuation-suspend: - shard-kbl: [DMESG-WARN][103] ([i915#180]) -> [PASS][104] +3 similar issues [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-kbl3/igt@kms_vblank@pipe-b-ts-continuation-suspend.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl4/igt@kms_vblank@pipe-b-ts-continuation-suspend.html #### Warnings #### * igt@gem_exec_fair@basic-pace@vcs0: - shard-kbl: [FAIL][105] ([i915#2842]) -> [SKIP][106] ([fdo#109271]) [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs0.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs0.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [WARN][107] ([i915#1804] / [i915#2684]) -> [WARN][108] ([i915#2681] / [i915#2684]) [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html * igt@kms_dp_dsc@basic-dsc-enable-edp: - shard-iclb: [DMESG-WARN][109] ([i915#1226]) -> [SKIP][110] ([fdo#109349]) [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-iclb6/igt@kms_dp_dsc@basic-dsc-enable-edp.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3: - shard-iclb: [SKIP][111] ([i915#2920]) -> [SKIP][112] ([i915#658]) +2 similar issues [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-iclb2/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-iclb8/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3.html * igt@kms_psr2_sf@plane-move-sf-dmg-area-3: - shard-iclb: [SKIP][113] ([i915#658]) -> [SKIP][114] ([i915#2920]) +2 similar issues [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-iclb6/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html * igt@runner@aborted: - shard-kbl: ([FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#602]) -> ([FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#602]) [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-kbl7/igt@runner@aborted.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-kbl3/igt@runner@aborted.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-kbl3/igt@runner@aborted.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-kbl1/igt@runner@aborted.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-kbl7/igt@runner@aborted.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-kbl3/igt@runner@aborted.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-kbl3/igt@runner@aborted.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-kbl7/igt@runner@aborted.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl2/igt@runner@aborted.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl3/igt@runner@aborted.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl3/igt@runner@aborted.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl3/igt@runner@aborted.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl7/igt@runner@aborted.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl3/igt@runner@aborted.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl6/igt@runner@aborted.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl4/igt@runner@aborted.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-kbl7/igt@runner@aborted.html - shard-apl: ([FAIL][132], [FAIL][133], [FAIL][134]) ([i915#1814] / [i915#3002]) -> ([FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140]) ([i915#1610] / [i915#180] / [i915#1814] / [i915#3002]) [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-apl3/igt@runner@aborted.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-apl1/igt@runner@aborted.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-apl1/igt@runner@aborted.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl2/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl8/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl6/igt@runner@aborted.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl8/igt@runner@aborted.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl1/igt@runner@aborted.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-apl8/igt@runner@aborted.html - shard-skl: ([FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144]) ([i915#1436] / [i915#2029]) -> ([FAIL][145], [FAIL][146]) ([i915#1814] / [i915#2029] / [i915#3002]) [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-skl2/igt@runner@aborted.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-skl3/igt@runner@aborted.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-skl7/igt@runner@aborted.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9985/shard-skl3/igt@runner@aborted.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl1/igt@runner@aborted.html [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/shard-skl2/igt@runner@aborted.html [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#111828]: https://bugs.freedesktop.org/show_bug.cgi?id=111828 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1187]: https://gitlab.freedesktop.org/drm/intel/issues/1187 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804 [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814 [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411 [i915#2437]: https://gitlab.freedesktop.org/d == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19955/index.html [-- Attachment #1.2: Type: text/html, Size: 36474 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-04-21 8:20 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-20 13:08 [Intel-gfx] [PATCH] drm/i915/selftests: Rename pm_ prefixed functions names Jani Nikula 2021-04-20 13:19 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork 2021-04-20 13:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-04-20 13:49 ` [Intel-gfx] [PATCH] " Rodrigo Vivi 2021-04-20 14:41 ` Jani Nikula 2021-04-20 14:52 ` Rodrigo Vivi 2021-04-21 8:20 ` Jani Nikula 2021-04-20 15:05 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.